Skip to content

Commit bd802a0

Browse files
Merge pull request #491 from benluddy/grpc-server-flakes
Start listening on test server port before running tests.
2 parents ec53e23 + f12b003 commit bd802a0

File tree

1 file changed

+6
-7
lines changed

1 file changed

+6
-7
lines changed

pkg/server/server_test.go

Lines changed: 6 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -26,12 +26,8 @@ const (
2626
dbName = "test.db"
2727
)
2828

29-
func server() {
29+
func server(lis net.Listener) {
3030
_ = os.Remove(dbName)
31-
lis, err := net.Listen("tcp", port)
32-
if err != nil {
33-
logrus.Fatalf("failed to listen: %v", err)
34-
}
3531
s := grpc.NewServer()
3632

3733
db, err := sql.Open("sqlite3", dbName)
@@ -66,7 +62,11 @@ func server() {
6662
}
6763

6864
func TestMain(m *testing.M) {
69-
go server()
65+
lis, err := net.Listen("tcp", port)
66+
if err != nil {
67+
logrus.Fatalf("failed to listen: %v", err)
68+
}
69+
go server(lis)
7070
exit := m.Run()
7171
if err := os.Remove(dbName); err != nil {
7272
logrus.Fatalf("couldn't remove db")
@@ -842,7 +842,6 @@ func TestListBundles(t *testing.T) {
842842
"etcdoperator.v0.9.0",
843843
}
844844

845-
846845
var names []string
847846
var gotBundles = make([]*api.Bundle, 0)
848847

0 commit comments

Comments
 (0)