Skip to content

Commit da66554

Browse files
Merge pull request #251 from djzager/registryrm
bug(opm): packages flag on registry rm required
2 parents ce63aa3 + 9a0adbe commit da66554

File tree

1 file changed

+5
-2
lines changed

1 file changed

+5
-2
lines changed

cmd/opm/registry/rm.go

Lines changed: 5 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -25,7 +25,10 @@ func newRegistryRmCmd() *cobra.Command {
2525

2626
rootCmd.Flags().Bool("debug", false, "enable debug logging")
2727
rootCmd.Flags().StringP("database", "d", "bundles.db", "relative path to database file")
28-
rootCmd.Flags().StringSliceP("packages", "o", []string{}, "comma separated list of package names to be deleted")
28+
rootCmd.Flags().StringSliceP("packages", "o", nil, "comma separated list of package names to be deleted")
29+
if err := rootCmd.MarkFlagRequired("packages"); err != nil {
30+
logrus.Panic("Failed to set required `packages` flag for `registry rm`")
31+
}
2932
rootCmd.Flags().Bool("permissive", false, "allow registry load errors")
3033

3134
return rootCmd
@@ -53,7 +56,7 @@ func rmFunc(cmd *cobra.Command, args []string) error {
5356

5457
logger := logrus.WithFields(logrus.Fields{"packages": packages})
5558

56-
logger.Info("adding to the registry")
59+
logger.Info("removing from the registry")
5760

5861
registryDeleter := registry.NewRegistryDeleter(logger)
5962

0 commit comments

Comments
 (0)