Add UniqueID to XML Output (#5092)

Ish Shah · web-flow · commit 05d58e209d36 · 2021-09-01T08:41:54.000-07:00
diff --git a/changelog/fragments/uid-output.yaml b/changelog/fragments/uid-output.yaml
@@ -0,0 +1,5 @@
+entries:
+  - description: >
+      If an optional UniqueID is provided by a user in the scorecard config and the user generates XML output the UID will be appended to the test result output.
+    kind: "addition"
+    breaking: false
diff --git a/internal/cmd/operator-sdk/scorecard/cmd.go b/internal/cmd/operator-sdk/scorecard/cmd.go
@@ -142,8 +142,11 @@ func (c *scorecardCmd) convertXunit(output v1alpha3.TestList) xunit.TestSuites {
 			}
 			tSuite.TestCases = append(tSuite.TestCases, tCase)
 			tSuite.URL = item.Spec.Image
-			//TODO: Add TestStuite ID when API updates version
-			//tSuite.ID = item.Spec.UniqueID
+			if item.Spec.UniqueID != "" {
+				tSuite.ID = item.Spec.UniqueID
+			} else {
+				tSuite.ID = res.Name
+			}
 			resultSuite.TestSuite = append(resultSuite.TestSuite, tSuite)
 		}
 	}

Original file line number	Diff line number	Diff line change
`@@ -142,8 +142,11 @@ func (c *scorecardCmd) convertXunit(output v1alpha3.TestList) xunit.TestSuites {`
`142`	`142`	`}`
`143`	`143`	`tSuite.TestCases = append(tSuite.TestCases, tCase)`
`144`	`144`	`tSuite.URL = item.Spec.Image`
`145`		`- //TODO: Add TestStuite ID when API updates version`
`146`		`- //tSuite.ID = item.Spec.UniqueID`
	`145`	`+ if item.Spec.UniqueID != "" {`
	`146`	`+ tSuite.ID = item.Spec.UniqueID`
	`147`	`+ } else {`
	`148`	`+ tSuite.ID = res.Name`
	`149`	`+ }`
`147`	`150`	`resultSuite.TestSuite = append(resultSuite.TestSuite, tSuite)`
`148`	`151`	`}`
`149`	`152`	`}`