Skip to content

Commit 09d7ff9

Browse files
authored
Merge pull request #105 from fanminshi/improve_commands_output
*: operator-sdk new now outputs progress
2 parents 48caa79 + 374ea7a commit 09d7ff9

File tree

2 files changed

+25
-15
lines changed

2 files changed

+25
-15
lines changed

commands/operator-sdk/cmd/new.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -137,13 +137,14 @@ func verifyFlags() {
137137
}
138138

139139
func pullDep() {
140+
fmt.Fprintln(os.Stdout, "Run dep ensure ...")
140141
dc := exec.Command(dep, ensureCmd)
141142
dc.Dir = filepath.Join(mustGetwd(), projectName)
142143
o, err := dc.CombinedOutput()
143144
if err != nil {
144145
cmdError.ExitWithError(cmdError.ExitError, fmt.Errorf("failed to ensure dependencies: (%v)", string(o)))
145146
}
146-
fmt.Fprintln(os.Stdout, string(o))
147+
fmt.Fprintln(os.Stdout, "Run dep ensure done")
147148
}
148149

149150
func mustGetwd() string {

pkg/generator/generator.go

Lines changed: 23 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -16,6 +16,7 @@ package generator
1616

1717
import (
1818
"bytes"
19+
"fmt"
1920
"io/ioutil"
2021
"os"
2122
"path/filepath"
@@ -110,15 +111,15 @@ func (g *Generator) renderGoDep() error {
110111
if err := renderGopkgTomlFile(buf); err != nil {
111112
return err
112113
}
113-
if err := ioutil.WriteFile(filepath.Join(g.projectName, gopkgtoml), buf.Bytes(), defaultFileMode); err != nil {
114+
if err := writeFileAndPrint(filepath.Join(g.projectName, gopkgtoml), buf.Bytes(), defaultFileMode); err != nil {
114115
return err
115116
}
116117

117118
buf = &bytes.Buffer{}
118119
if err := renderGopkgLockFile(buf); err != nil {
119120
return err
120121
}
121-
return ioutil.WriteFile(filepath.Join(g.projectName, gopkglock), buf.Bytes(), defaultFileMode)
122+
return writeFileAndPrint(filepath.Join(g.projectName, gopkglock), buf.Bytes(), defaultFileMode)
122123
}
123124

124125
func (g *Generator) renderCmd() error {
@@ -134,7 +135,7 @@ func renderCmdFiles(cmdProjectDir, repoPath string) error {
134135
if err := renderMainFile(buf, repoPath); err != nil {
135136
return err
136137
}
137-
return ioutil.WriteFile(filepath.Join(cmdProjectDir, main), buf.Bytes(), defaultFileMode)
138+
return writeFileAndPrint(filepath.Join(cmdProjectDir, main), buf.Bytes(), defaultFileMode)
138139
}
139140

140141
func (g *Generator) renderConfig() error {
@@ -150,7 +151,7 @@ func renderConfigFiles(configDir, apiVersion, kind, projectName string) error {
150151
if err := renderConfigFile(buf, apiVersion, kind, projectName); err != nil {
151152
return err
152153
}
153-
return ioutil.WriteFile(filepath.Join(configDir, config), buf.Bytes(), defaultFileMode)
154+
return writeFileAndPrint(filepath.Join(configDir, config), buf.Bytes(), defaultFileMode)
154155
}
155156

156157
func (g *Generator) renderDeploy() error {
@@ -166,7 +167,7 @@ func renderRBAC(deployDir, projectName string) error {
166167
if err := renderRBACYaml(buf, projectName); err != nil {
167168
return err
168169
}
169-
return ioutil.WriteFile(filepath.Join(deployDir, rbacYaml), buf.Bytes(), defaultFileMode)
170+
return writeFileAndPrint(filepath.Join(deployDir, rbacYaml), buf.Bytes(), defaultFileMode)
170171
}
171172

172173
// RenderDeployFiles generates "deploy/operator.yaml"
@@ -200,39 +201,39 @@ func renderBuildFiles(buildDir, repoPath, projectName string) error {
200201
if err := renderBuildFile(buf, repoPath, projectName); err != nil {
201202
return err
202203
}
203-
if err := ioutil.WriteFile(filepath.Join(buildDir, build), buf.Bytes(), defaultExecFileMode); err != nil {
204+
if err := writeFileAndPrint(filepath.Join(buildDir, build), buf.Bytes(), defaultExecFileMode); err != nil {
204205
return err
205206
}
206207

207208
buf = &bytes.Buffer{}
208209
if err := renderDockerBuildFile(buf); err != nil {
209210
return err
210211
}
211-
if err := ioutil.WriteFile(filepath.Join(buildDir, dockerBuild), buf.Bytes(), defaultExecFileMode); err != nil {
212+
if err := writeFileAndPrint(filepath.Join(buildDir, dockerBuild), buf.Bytes(), defaultExecFileMode); err != nil {
212213
return err
213214
}
214215

215216
buf = &bytes.Buffer{}
216217
if err := renderDockerFile(buf, projectName); err != nil {
217218
return err
218219
}
219-
return ioutil.WriteFile(filepath.Join(buildDir, dockerfile), buf.Bytes(), defaultFileMode)
220+
return writeFileAndPrint(filepath.Join(buildDir, dockerfile), buf.Bytes(), defaultFileMode)
220221
}
221222

222223
func renderCodegenFiles(codegenDir, repoPath, apiDirName, version, projectName string) error {
223224
buf := &bytes.Buffer{}
224225
if err := renderBoilerplateFile(buf, projectName); err != nil {
225226
return err
226227
}
227-
if err := ioutil.WriteFile(filepath.Join(codegenDir, boilerplate), buf.Bytes(), defaultFileMode); err != nil {
228+
if err := writeFileAndPrint(filepath.Join(codegenDir, boilerplate), buf.Bytes(), defaultFileMode); err != nil {
228229
return err
229230
}
230231

231232
buf = &bytes.Buffer{}
232233
if err := renderUpdateGeneratedFile(buf, repoPath, apiDirName, version); err != nil {
233234
return err
234235
}
235-
return ioutil.WriteFile(filepath.Join(codegenDir, updateGenerated), buf.Bytes(), defaultExecFileMode)
236+
return writeFileAndPrint(filepath.Join(codegenDir, updateGenerated), buf.Bytes(), defaultExecFileMode)
236237
}
237238

238239
func (g *Generator) renderPkg() error {
@@ -257,31 +258,31 @@ func renderAPIFiles(apiDir, groupName, version, kind string) error {
257258
if err := renderAPIDocFile(buf, groupName, version); err != nil {
258259
return err
259260
}
260-
if err := ioutil.WriteFile(filepath.Join(apiDir, doc), buf.Bytes(), defaultFileMode); err != nil {
261+
if err := writeFileAndPrint(filepath.Join(apiDir, doc), buf.Bytes(), defaultFileMode); err != nil {
261262
return err
262263
}
263264

264265
buf = &bytes.Buffer{}
265266
if err := renderAPIRegisterFile(buf, kind, groupName, version); err != nil {
266267
return err
267268
}
268-
if err := ioutil.WriteFile(filepath.Join(apiDir, register), buf.Bytes(), defaultFileMode); err != nil {
269+
if err := writeFileAndPrint(filepath.Join(apiDir, register), buf.Bytes(), defaultFileMode); err != nil {
269270
return err
270271
}
271272

272273
buf = &bytes.Buffer{}
273274
if err := renderAPITypesFile(buf, kind, version); err != nil {
274275
return err
275276
}
276-
return ioutil.WriteFile(filepath.Join(apiDir, types), buf.Bytes(), defaultFileMode)
277+
return writeFileAndPrint(filepath.Join(apiDir, types), buf.Bytes(), defaultFileMode)
277278
}
278279

279280
func renderStubFiles(stubDir string) error {
280281
buf := &bytes.Buffer{}
281282
if err := renderHandlerFile(buf); err != nil {
282283
return err
283284
}
284-
return ioutil.WriteFile(filepath.Join(stubDir, handler), buf.Bytes(), defaultFileMode)
285+
return writeFileAndPrint(filepath.Join(stubDir, handler), buf.Bytes(), defaultFileMode)
285286
}
286287

287288
// version extracts the VERSION from the given apiVersion ($GROUP_NAME/$VERSION).
@@ -302,3 +303,11 @@ func groupName(apiVersion string) string {
302303
func apiDirName(apiVersion string) string {
303304
return strings.Split(groupName(apiVersion), ".")[0]
304305
}
306+
307+
func writeFileAndPrint(filePath string, data []byte, fileMode os.FileMode) error {
308+
if err := ioutil.WriteFile(filePath, data, fileMode); err != nil {
309+
return err
310+
}
311+
fmt.Printf("Create %v \n", filePath)
312+
return nil
313+
}

0 commit comments

Comments
 (0)