Makefile: change make test to run just unit tests (#1151)

* Makefile: change make test to run just unit tests

While working on the operator-sdk, I often type make test expecting to
run unit tests to do a quick verification. Sadly it would run ALL tests
causing a very long turn around time.

I updated the docs to let folks know to run make test for unit tests.
And removed the unit.sh script as it wasn't doing anything helpful.

* remove unit script from doc

* feedback: fix missing link for unit tests

* address review comment

Author: jmrodri

Makefile

@@ -71,7 +71,9 @@ build/%.asc:
 
 .PHONY: install release_x86_64 release
 
-test: dep test/markdown test/sanity test/unit install test/subcommand test/e2e
+test: test/unit
+
+test-ci: test/markdown test/sanity test/unit install test/subcommand test/e2e
 
 test/ci-go: test/subcommand test/e2e/go
 
@@ -83,7 +85,8 @@ test/sanity:
 	./hack/tests/sanity-check.sh
 
 test/unit:
-	./hack/tests/unit.sh
+	$(Q)go test -count=1 -short ./commands/...
+	$(Q)go test -count=1 -short ./pkg/...
 
 test/subcommand: test/subcommand/test-local test/subcommand/scorecard
 
@@ -110,7 +113,7 @@ test/e2e/helm: image/build/helm
 test/markdown:
 	./hack/ci/marker --root=doc
 
-.PHONY: test test/sanity test/unit test/subcommand test/e2e test/e2e/go test/e2e/ansible test/e2e/ansible-molecule test/e2e/helm test/ci-go test/ci-ansible test/ci-helm test/markdown
+.PHONY: test test-ci test/sanity test/unit test/subcommand test/e2e test/e2e/go test/e2e/ansible test/e2e/ansible-molecule test/e2e/helm test/ci-go test/ci-ansible test/ci-helm test/markdown
 
 image: image/build image/push
 

doc/dev/developer_guide.md

@@ -34,6 +34,12 @@ The SDK includes many tests that are run as part of CI.
 To build the binary and run all tests (assuming you have a correctly configured environment),
 you can simple run:
 
+```sh
+$ make test-ci
+```
+
+If you simply want to run the unit tests, you can run:
+
 ```sh
 $ make test
 ```

doc/dev/testing/travis-build.md

@@ -32,7 +32,8 @@ The Go, Ansible, and Helm tests then differ in what tests they run.
     2. Check that all source files have a license.
     3. Check that all error messages start with a lower case alphabetical character and do not end with punctuation, and log messages start with an upper case alphabetical character.
     4. Make sure the repo is in a clean state (this is particularly useful for making sure the `Gopkg.lock` file up to date after `dep ensure`).
-2. Run [unit tests][unit].
+2. Run unit tests.
+    1. Run `make test`.
 3. Run [subcommand tests][subcommand].
     1. Run `test local` with no flags enabled.
     2. Run `test local` with most configuration flags enabled.
@@ -112,7 +113,6 @@ The markdown test does not create a new cluster and runs in a barebones Travis V
 [pr-builds]: https://travis-ci.org/operator-framework/operator-sdk/pull_requests
 [script]: ../../../hack/ci/setup-openshift.sh
 [sanity]: ../../../hack/tests/sanity-check.sh
-[unit]: ../../../hack/tests/unit.sh
 [subcommand]: ../../../hack/tests/test-subcommand.sh
 [go-e2e]: ../../../hack/tests/e2e-go.sh
 [tls-tests]: ../../../test/e2e/tls_util_test.go