Run generate before prerelease (#4952)

* Run generate before prerelease

Signed-off-by: Fabian von Feilitzsch <[email protected]>

* Update website/content/en/docs/contribution-guidelines/releasing.md

Co-authored-by: Jesus Rodriguez <[email protected]>
Signed-off-by: Fabian von Feilitzsch <[email protected]>

Co-authored-by: Jesus Rodriguez <[email protected]>

Author: fabianvf

Makefile

@@ -110,7 +110,7 @@ release: ## Release target. See 'make -f release/Makefile help' for more informa
 	$(MAKE) -f release/Makefile $@
 
 .PHONY: prerelease
-prerelease: ## Write release commit changes. See 'make -f release/Makefile help' for more information.
+prerelease: generate ## Write release commit changes. See 'make -f release/Makefile help' for more information.
 ifneq ($(RELEASE_VERSION),$(IMAGE_VERSION))
 	$(error "IMAGE_VERSION "$(IMAGE_VERSION)" must be updated to match RELEASE_VERSION "$(RELEASE_VERSION)" prior to creating a release commit")
 endif

website/content/en/docs/contribution-guidelines/releasing.md

@@ -101,15 +101,17 @@ make prerelease
 
 The following changes should be present:
 
+- `Makefile`: IMAGE_VERSION should be modified to the upcoming release tag. (This variable ensures sampleprojects have been tagged correctly prior to the release commit.)
 - `changelog/generated/v1.3.0.md`: commit changes (created by changelog generation).
 - `changelog/fragments/*`: commit deleted fragment files (deleted by changelog generation).
 - `website/content/en/docs/upgrading-sdk-version/v1.3.0.md`: commit changes (created by changelog generation).
 - `website/config.toml`: commit changes (modified by release script).
+- `testdata/*`: Generated sample code.
 
 Commit these changes and push to your remote (assuming your remote is named `origin`):
 
 ```sh
-git add --all
+git add Makefile changelog website testdata
 git commit -m "Release $RELEASE_VERSION"
 git push -u origin release-$RELEASE_VERSION
 ```
@@ -210,9 +212,6 @@ following commands from the root of the project.
 sed -i -E 's/(IMAGE_VERSION = ).+/\1v1\.3\.1/g' Makefile
 #  Run the pre-release `make` target:
 make prerelease
-# Regenerate testdata (samples).
-# NOTE: The sanity test will fail but scaffolding should complete.
-make test-sanity
 ```
 
 All of the following changes should be present (and no others).
@@ -225,7 +224,7 @@ All of the following changes should be present (and no others).
 Commit these changes and push these changes **to your fork**:
 
 ```sh
-git add --all
+git add Makefile changelog website testdata
 git commit -sm "Release $RELEASE_VERSION"
 git push -u origin release-$RELEASE_VERSION
 ```