*: Replace 'docker build . -t ${IMG}' with '-t ${IMG} .' (#4466)

Because folks may have 'docker' aliased to 'podman', and Podman
prefers options before positional arguments:

  $ podman build --help | grep CONTEXT-DIRECTORY
     podman build [command options] CONTEXT-DIRECTORY | URL

We can't change the v2 sample since it still uses the old format.

Co-authored-by: W. Trevor King <[email protected]>
Signed-off-by: jesus m. rodriguez <[email protected]>

Co-authored-by: W. Trevor King <[email protected]>

Author: jmrodri

changelog/fragments/reorder-docker-args.yaml

@@ -0,0 +1,28 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      (ansible/v1, helm/v1) Post-fixed positional directory argument `.` in `docker-build` make target to align with `podman`
+    kind: "change"
+    breaking: false
+
+    # Migration can be defined to automatically add a section to
+    # the migration guide. This is required for breaking changes.
+    migration:
+      header: Move positional directory argument `.` in `docker-build` make target
+      body: >
+        The directory argument `.` in the `docker-build` make target was moved to the
+        last positional argument to align with `podman`'s expectations, making substitution
+        cleaner. In your `Makefile`, change:
+
+            docker build . -t ${IMG}
+
+        to
+             docker build -t ${IMG} .
+
+        Alternatively, you could replace it programmatically
+
+        ```sh
+        sed -i 's/docker build . -t ${IMG}/docker build -t ${IMG} ./' $(git grep -l 'docker.*build \. ')
+        ```
+

internal/plugins/ansible/v1/scaffolds/internal/templates/makefile.go

@@ -93,7 +93,7 @@ undeploy: kustomize
 
 # Build the docker image
 docker-build:
-	docker build . -t ${IMG}
+	docker build -t ${IMG} .
 
 # Push the docker image
 docker-push:

internal/plugins/helm/v1/scaffolds/internal/templates/makefile.go

@@ -93,7 +93,7 @@ undeploy: kustomize
 
 # Build the docker image
 docker-build:
-	docker build . -t ${IMG}
+	docker build -t ${IMG} .
 
 # Push the docker image
 docker-push:

testdata/ansible/memcached-operator/Makefile

@@ -56,7 +56,7 @@ undeploy: kustomize
 
 # Build the docker image
 docker-build:
-	docker build . -t ${IMG}
+	docker build -t ${IMG} .
 
 # Push the docker image
 docker-push:

testdata/helm/memcached-operator/Makefile

@@ -56,7 +56,7 @@ undeploy: kustomize
 
 # Build the docker image
 docker-build:
-	docker build . -t ${IMG}
+	docker build -t ${IMG} .
 
 # Push the docker image
 docker-push: