*: remove lll linter (#3362)

Author: Eric Stroczynski

cmd/operator-sdk/add/controller.go

@@ -30,22 +30,21 @@ var (
 	crdVersion      string
 )
 
-//nolint:lll
 func newAddControllerCmd() *cobra.Command {
 	controllerCmd := &cobra.Command{
 		Use:   "controller",
 		Short: "Adds a new controller pkg",
 		Long: `
 Add a new controller package to your operator project.
 
-This command creates a new controller package under pkg/controller/<kind> that, by default, reconciles on a custom resource for the specified apiversion and kind. The controller will expect to use the custom resource type that should already be defined under pkg/apis/<group>/<version> via the "operator-sdk add api" command. 
+This command creates a new controller package under pkg/controller/<kind> that, by default, reconciles on a custom resource for the specified apiversion and kind. The controller will expect to use the custom resource type that should already be defined under pkg/apis/<group>/<version> via the "operator-sdk add api" command.
 
 Note that, if the controller pkg for that Kind already exists at pkg/controller/<kind> then the command will not overwrite and return an error.
 
 This command MUST be run from the project root directory.`,
 
 		Example: `
-The following example will create a controller to manage, watch and reconcile as primary resource the <v1.AppService> from the domain <app.example.com>.    
+The following example will create a controller to manage, watch and reconcile as primary resource the <v1.AppService> from the domain <app.example.com>.
 
 Example:
 
@@ -57,7 +56,7 @@ Example:
 	│   └── appservice_controller.go
 	└── controller.go
 
-The following example will create a controller to manage, watch and reconcile as a primary resource the <v1.Deployment> from the domain <k8s.io.api>, which is not defined in the project (external). Note that, it can be used to create controllers for any External API. 	
+The following example will create a controller to manage, watch and reconcile as a primary resource the <v1.Deployment> from the domain <k8s.io.api>, which is not defined in the project (external). Note that, it can be used to create controllers for any External API.
 
 Example:
 
@@ -66,7 +65,7 @@ Example:
 	pkg/controller/
 	├── add_deployment.go
 	├── deployment
-	│   └── deployment_controller.go 
+	│   └── deployment_controller.go
 	└── controller.go
 		`,
 		RunE: controllerRun,

cmd/operator-sdk/bundle/create.go

@@ -43,7 +43,6 @@ type bundleCreateCmd struct {
 
 // newCreateCmd returns a command that will build operator bundle image or
 // generate metadata for them.
-//nolint:lll
 func newCreateCmd() *cobra.Command {
 	c := &bundleCreateCmd{}
 

cmd/operator-sdk/generate/bundle/bundle.go

@@ -47,7 +47,6 @@ More information on bundles:
 https://github.com/operator-framework/operator-registry/#manifest-format
 `
 
-	//nolint:lll
 	examples = `
   # Generate bundle files and build your bundle image with these 'make' recipes:
   $ make bundle

cmd/operator-sdk/generate/csv.go

@@ -42,7 +42,6 @@ type csvCmd struct {
 	interactive      bool
 }
 
-//nolint:lll
 func newGenerateCSVCmd() *cobra.Command {
 	c := &csvCmd{}
 	cmd := &cobra.Command{

cmd/operator-sdk/generate/kustomize/manifests.go

@@ -37,7 +37,6 @@ This command will interactively ask for UI metadata, an important component of m
 by default unless a base already exists or you set '--interactive=false'.
 `
 
-//nolint:lll
 const examples = `
   $ operator-sdk generate kustomize manifests
 

cmd/operator-sdk/generate/packagemanifests/packagemanifests.go

@@ -46,7 +46,6 @@ More information on the package manifests format:
 https://github.com/operator-framework/operator-registry/#manifest-format
 `
 
-	//nolint:lll
 	examples = `
   # Generate manifests then create the package manifests base:
   $ make manifests

hack/generate/changelog/util/fragment.go

@@ -176,7 +176,6 @@ func (g *gitPullRequestNumberGetter) GetPullRequestNumberFor(filename string) (u
 }
 
 func (g *gitPullRequestNumberGetter) getCommitMessage(filename string) (string, error) {
-	//nolint:lll
 	args := fmt.Sprintf("log --follow --pretty=format:%%s --diff-filter=A --find-renames=90%% %s", filename)
 	line, err := exec.Command("git", strings.Split(args, " ")...).CombinedOutput()
 	if err != nil {

hack/tests/check-lint.sh

@@ -61,9 +61,7 @@ golangci-lint run --disable-all \
     --enable=dupl \
     --enable=unparam \
     --enable=golint \
-    --enable=lll \
     --enable=staticcheck \
     --enable=unused \
     --enable=gosimple \
     ${LINTERS[@]}
-

hack/tests/scaffolding/scaffold-memcached.go

@@ -119,7 +119,7 @@ func main() {
 	if err != nil {
 		log.Fatalf("Error: %v\nCommand Output: %s\n", err, string(cmdOut))
 	}
-	//nolint:lll
+
 	tmplFiles := map[string]string{
 		filepath.Join(localSDKPath, "example/memcached-operator/memcached_controller.go.tmpl"): "pkg/controller/memcached/memcached_controller.go",
 		filepath.Join(localSDKPath, "test/e2e/_incluster-test-code/main_test.go"):              "test/e2e/main_test.go",

internal/generate/collector/collect.go

@@ -100,7 +100,6 @@ func (c *Manifests) UpdateFromDirs(deployDir, crdsDir string) error {
 
 	// Add CRDs from input.
 	if isDirExist(crdsDir) {
-		//nolint:lll
 		c.V1CustomResourceDefinitions, c.V1beta1CustomResourceDefinitions, err = k8sutil.GetCustomResourceDefinitions(crdsDir)
 		if err != nil {
 			return fmt.Errorf("error adding CustomResourceDefinitions to manifest collector: %v", err)