fix: only print controller comment for Go projects (#4742)

Author: jmrodri

go.mod

@@ -36,7 +36,7 @@ require (
 	rsc.io/letsencrypt v0.0.3 // indirect
 	sigs.k8s.io/controller-runtime v0.8.2
 	sigs.k8s.io/controller-tools v0.5.0
-	sigs.k8s.io/kubebuilder/v3 v3.0.0-alpha.0.0.20210407152553-d5e70a57ccb0
+	sigs.k8s.io/kubebuilder/v3 v3.0.0-rc.0
 	sigs.k8s.io/yaml v1.2.0
 )
 

go.sum

@@ -1557,8 +1557,8 @@ sigs.k8s.io/controller-tools v0.4.1 h1:VkuV0MxlRPmRu5iTgBZU4UxUX2LiR99n3sdQGRxZF
 sigs.k8s.io/controller-tools v0.4.1/go.mod h1:G9rHdZMVlBDocIxGkK3jHLWqcTMNvveypYJwrvYKjWU=
 sigs.k8s.io/controller-tools v0.5.0 h1:3u2RCwOlp0cjCALAigpOcbAf50pE+kHSdueUosrC/AE=
 sigs.k8s.io/controller-tools v0.5.0/go.mod h1:JTsstrMpxs+9BUj6eGuAaEb6SDSPTeVtUyp0jmnAM/I=
-sigs.k8s.io/kubebuilder/v3 v3.0.0-alpha.0.0.20210407152553-d5e70a57ccb0 h1:7xXfjzq8NfOwBEo3ZGa/+G5uABPfHIDXdoy3ERn5kxQ=
-sigs.k8s.io/kubebuilder/v3 v3.0.0-alpha.0.0.20210407152553-d5e70a57ccb0/go.mod h1:eVtLdWzmvL1ixDYLlVrvQe8wjpikJVoSOg5PghTk2Lw=
+sigs.k8s.io/kubebuilder/v3 v3.0.0-rc.0 h1:FGgl/3O6kt4eKpCQR5LFMZdbYwD8jqSbw/lisIuP9FI=
+sigs.k8s.io/kubebuilder/v3 v3.0.0-rc.0/go.mod h1:eVtLdWzmvL1ixDYLlVrvQe8wjpikJVoSOg5PghTk2Lw=
 sigs.k8s.io/kustomize v2.0.3+incompatible h1:JUufWFNlI44MdtnjUqVnvh29rR37PQFzPbLXqhyOyX0=
 sigs.k8s.io/kustomize v2.0.3+incompatible/go.mod h1:MkjgH3RdOWrievjo6c9T245dYlB5QeXV4WCbnt/PEpU=
 sigs.k8s.io/kustomize/kyaml v0.10.10 h1:caAxDDkaXZp+0kDsZVik4leFJV8LCy09PdVqpaoNeF4=

internal/cmd/operator-sdk/alpha/config3alphato3/convert_config_3-alpha_to_3.go

@@ -34,8 +34,14 @@ var (
 	versionRe = regexp.MustCompile(`version:[ ]*(?:")?3-alpha(?:")?`)
 )
 
+type templObj struct {
+	IsGo      bool
+	Resources []resource.Resource
+}
+
 // convertConfig3AlphaTo3 returns cfgBytes converted to 3 iff cfgBytes is version 3-alpha.
 func convertConfig3AlphaTo3(cfgBytes []byte) (_ []byte, err error) {
+	tObj := templObj{}
 	cfgObj := make(map[string]interface{}, 5)
 	if err := yaml.Unmarshal(cfgBytes, &cfgObj); err != nil {
 		return nil, err
@@ -109,9 +115,12 @@ func convertConfig3AlphaTo3(cfgBytes []byte) (_ []byte, err error) {
 			}
 		}
 
+		tObj.Resources = resources
+		tObj.IsGo = isGo
+
 		out := bytes.Buffer{}
 		t := template.Must(template.New("").Parse(tmpl))
-		if err := t.Execute(&out, resources); err != nil {
+		if err := t.Execute(&out, tObj); err != nil {
 			return nil, err
 		}
 
@@ -152,7 +161,8 @@ var getModulePath = func() (string, error) {
 
 // Comment-heavy "resources" template.
 const tmpl = `resources:
-{{- range $i, $res := . }}
+{{- $isGo := .IsGo }}
+{{- range $i, $res := .Resources }}
 -{{- if $res.API }} api:
     {{- if $res.API.CRDVersion }}
     crdVersion: {{ $res.API.CRDVersion }}
@@ -163,8 +173,10 @@ const tmpl = `resources:
     # TODO(user): Uncomment the below line if this resource's CRD is namespace scoped, else delete it.
     # namespaced: true
   {{- end }}
+  {{- if $isGo }}
   # TODO(user): Uncomment the below line if this resource implements a controller, else delete it.
   # controller: true
+  {{- end }}
   {{- if $res.Domain }}
   domain: {{ $res.Domain }}
   {{- end }}