fix: Fix error faced when the ansible.operator-sdk/verbosity annotation for Ansible based-operators is 0 or less. (#2651)

Fix error faced when the `ansible.operator-sdk/verbosity` annotation for Ansible based-operators is 0 or less. 
Closes: #2627

Author: camilamacedo86

CHANGELOG.md

@@ -48,6 +48,7 @@
 - Fixed a regression in the `operator-sdk run` command that caused `--local` flags to be ignored ([#2478](https://github.com/operator-framework/operator-sdk/issues/2478))
 - Fix command `operator-sdk run --local` which was not working on Windows. ([#2481](https://github.com/operator-framework/operator-sdk/pull/2481))
 - Fix `ServiceMonitor` creation when the operator is cluster-scoped and the environment variable `WATCH_NAMESPACE` has a different value than the namespace where the operator is deployed. ([#2601](https://github.com/operator-framework/operator-sdk/pull/2601))
+- Fix error faced when the `ansible.operator-sdk/verbosity` annotation for Ansible based-operators is 0 or less. ([#2651](https://github.com/operator-framework/operator-sdk/pull/2651))
 - Fix missing error status when the error faced in the Ansible do not return an event status. ([#2661](https://github.com/operator-framework/operator-sdk/pull/2661))
 
 ## v0.15.2

pkg/ansible/runner/runner.go

@@ -57,26 +57,42 @@ type Runner interface {
 	GetFinalizer() (string, bool)
 }
 
+// ansibleVerbosityString will return the string with the -v* levels
 func ansibleVerbosityString(verbosity int) string {
 	if verbosity > 0 {
+		// the default verbosity is 0
+		// more info: https://docs.ansible.com/ansible/latest/reference_appendices/config.html#default-verbosity
 		return fmt.Sprintf("-%v", strings.Repeat("v", verbosity))
 	}
+	// Return default verbosity
 	return ""
 }
 
 type cmdFuncType func(ident, inputDirPath string, maxArtifacts, verbosity int) *exec.Cmd
 
 func playbookCmdFunc(path string) cmdFuncType {
 	return func(ident, inputDirPath string, maxArtifacts, verbosity int) *exec.Cmd {
-		return exec.Command("ansible-runner", ansibleVerbosityString(verbosity), "--rotate-artifacts",
+		// check the verbosity since the exec.Command will fail if an arg as "" or " " be informed
+		if verbosity > 0 {
+			return exec.Command("ansible-runner", ansibleVerbosityString(verbosity), "--rotate-artifacts",
+				fmt.Sprintf("%v", maxArtifacts), "-p", path, "-i", ident, "run", inputDirPath)
+		}
+		return exec.Command("ansible-runner", "--rotate-artifacts",
 			fmt.Sprintf("%v", maxArtifacts), "-p", path, "-i", ident, "run", inputDirPath)
+
 	}
 }
 
 func roleCmdFunc(path string) cmdFuncType {
 	rolePath, roleName := filepath.Split(path)
 	return func(ident, inputDirPath string, maxArtifacts, verbosity int) *exec.Cmd {
-		return exec.Command("ansible-runner", ansibleVerbosityString(verbosity), "--rotate-artifacts",
+		// check the verbosity since the exec.Command will fail if an arg as "" or " " be informed
+		if verbosity > 0 {
+			return exec.Command("ansible-runner", ansibleVerbosityString(verbosity), "--rotate-artifacts",
+				fmt.Sprintf("%v", maxArtifacts), "--role", roleName, "--roles-path", rolePath, "--hosts",
+				"localhost", "-i", ident, "run", inputDirPath)
+		}
+		return exec.Command("ansible-runner", "--rotate-artifacts",
 			fmt.Sprintf("%v", maxArtifacts), "--role", roleName, "--roles-path", rolePath, "--hosts",
 			"localhost", "-i", ident, "run", inputDirPath)
 	}

pkg/ansible/runner/runner_test.go

@@ -219,7 +219,7 @@ func TestAnsibleVerbosityString(t *testing.T) {
 	for _, tc := range testCases {
 		gotString := ansibleVerbosityString(tc.verbosity)
 		if tc.expectedString != gotString {
-			t.Fatalf("Unexpected string %v expected %v", gotString, tc.expectedString)
+			t.Fatalf("Unexpected string %v for  expected %v from verbosity %v", gotString, tc.expectedString, tc.verbosity)
 		}
 	}
 }

test/ansible/deploy/crds/test.example.com_v1_inventorytest_cr.yaml

@@ -2,6 +2,8 @@ apiVersion: test.example.com/v1
 kind: InventoryTest
 metadata:
   name: example-inventorytest
+  annotations:
+    "ansible.operator-sdk/verbosity": "3"
 spec:
   # Add fields here
   size: 3

test/ansible/deploy/crds/test.example.com_v1alpha1_inventory_cr.yaml

@@ -3,7 +3,7 @@ kind: Inventory
 metadata:
   name: example-inventory
   annotations:
-    "ansible.operator-sdk/verbosity": "3"
+    "ansible.operator-sdk/verbosity": "0"
 spec:
   # Add fields here
   size: 3