[webhook] Modify ordering of webhook based on name (#5301)

When there are multiple webhooks of the same type, the
ordering is not fixed. This PR modifies the ordering of webhooks
in a webhookdefinition based on the name, instead of the type.

Signed-off-by: varshaprasad96 <[email protected]>

Author: varshaprasad96

changelog/fragments/fix-wh-ordering-csv.yaml

@@ -0,0 +1,17 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      The list of webhooks in `webhookdescription` was previously sorted based on `webhookType`. It is now being sorted
+      based on webhook names.
+
+    # kind is one of:
+    # - addition
+    # - change
+    # - deprecation
+    # - removal
+    # - bugfix
+    kind: "bugfix"
+
+    # Is this a breaking change?
+    breaking: false

internal/generate/clusterserviceversion/clusterserviceversion_updaters.go

@@ -338,7 +338,7 @@ func applyWebhooks(c *collector.Manifests, csv *operatorsv1alpha1.ClusterService
 	}
 	// Sorts the WebhookDescriptions based on natural order of webhookDescriptions Type
 	sort.Slice(webhookDescriptions, func(i, j int) bool {
-		return webhookDescriptions[i].Type < webhookDescriptions[j].Type
+		return webhookDescriptions[i].GenerateName < webhookDescriptions[j].GenerateName
 	})
 	csv.Spec.WebhookDefinitions = webhookDescriptions
 }