Various molecule scaffolding tweaks (#3661)

Author: asmacdo

internal/plugins/ansible/v1/scaffolds/internal/templates/config/testing/kustomization.go

@@ -52,7 +52,6 @@ namePrefix: osdk-
 
 patchesStrategicMerge:
 - manager_image.yaml
-- pull_policy/Never.yaml
 - debug_logs_patch.yaml
 - ../default/manager_auth_proxy_patch.yaml
 

internal/plugins/ansible/v1/scaffolds/internal/templates/molecule/mdefault/verify.go

@@ -44,6 +44,9 @@ const verifyTemplate = `---
   collections:
     - community.kubernetes
 
+  vars:
+    ctrl_label: control-plane=controller-manager
+
   tasks:
     - block:
         - name: Import all test files from tasks/
@@ -71,7 +74,8 @@ const verifyTemplate = `---
           k8s_log:
             name: '{{ "{{ item.metadata.name }}" }}'
             namespace: '{{ "{{ namespace }}" }}'
-          loop: "{{ "{{ q('k8s', api_version='v1', kind='Pod', namespace=namespace) }}" }}"
+            container: manager
+          loop: "{{ "{{ q('k8s', api_version='v1', kind='Pod', namespace=namespace, label_selector=ctrl_label) }}" }}"
           register: debug_logs
 
         - name: Output gathered resources

internal/plugins/ansible/v1/scaffolds/internal/templates/molecule/mkind/destroy.go

@@ -47,4 +47,9 @@ const destroyTemplate = `---
   tasks:
     - name: Destroy test kind cluster
       command: kind delete cluster --name osdk-test --kubeconfig {{ "{{ kubeconfig }}" }}
+
+    - name: Unset pull policy
+      command: '{{ "{{ kustomize }}" }} edit remove patch pull_policy/{{ "{{ operator_pull_policy }}" }}.yaml'
+      args:
+        chdir: '{{ "{{ config_dir }}" }}/testing'
 `