[olm] Remove olm-namespace flag from install sub-command (#3670)

Remove 'olm-namespace' flag from 'operator-sdk olm install' command.

Reason: The OLM manifests which are used to install olm-operator have
hardcoded namespace value.

Author: varshaprasad96

changelog/fragments/remove-olm-namespace-flag.yaml

@@ -0,0 +1,11 @@
+entries:
+  - description: Removed `olm-namespace` flag from `operator-sdk olm install` command
+    kind: removal
+    breaking: true
+    migration:
+      header: Remove `olm-namespace` flag from `operator-sdk olm install` command
+      body: |
+        The `olm-namespace` flag has been removed from `operator-sdk olm install`
+        command, as the olm manifests published in github have a hardcoded
+        namespace value. Hence, the olm operators can only be installed in `olm`
+        namespace using this command.

internal/cmd/operator-sdk/olm/install.go

@@ -35,8 +35,6 @@ func newInstallCmd() *cobra.Command {
 	}
 
 	cmd.Flags().StringVar(&mgr.Version, "version", olm.DefaultVersion, "version of OLM resources to install")
-	cmd.Flags().StringVar(&mgr.OLMNamespace, "olm-namespace", olm.DefaultOLMNamespace,
-		"namespace where OLM is to be installed.")
 	mgr.AddToFlagSet(cmd.Flags())
 	return cmd
 }

internal/cmd/operator-sdk/olm/install_test.go

@@ -32,11 +32,6 @@ var _ = Describe("Running an olm install command", func() {
 			Expect(flag).NotTo(BeNil())
 			Expect(flag.DefValue).To(Equal(olm.DefaultVersion))
 			Expect(flag.Usage).NotTo(BeNil())
-
-			flag = cmd.Flags().Lookup("olm-namespace")
-			Expect(flag).NotTo(BeNil())
-			Expect(flag.DefValue).To(Equal(olm.DefaultOLMNamespace))
-			Expect(flag.Usage).NotTo(BeNil())
 		})
 	})
 })

website/content/en/docs/cli/operator-sdk_olm_install.md

@@ -16,10 +16,9 @@ operator-sdk olm install [flags]
 ### Options
 
 ```
-  -h, --help                   help for install
-      --olm-namespace string   namespace where OLM is to be installed. (default "olm")
-      --timeout duration       time to wait for the command to complete before failing (default 2m0s)
-      --version string         version of OLM resources to install (default "latest")
+  -h, --help               help for install
+      --timeout duration   time to wait for the command to complete before failing (default 2m0s)
+      --version string     version of OLM resources to install (default "latest")
 ```
 
 ### Options inherited from parent commands

website/content/en/docs/olm-integration/quickstart-bundle.md

@@ -30,7 +30,7 @@ Ensure OLM is enabled on your cluster before following this guide. [`operator-sd
 has several subcommands that can install, uninstall, and check the status of particular OLM versions in a cluster.
 
 **Note:** Certain cluster types may already have OLM enabled, but under a non-default (`"olm"`) namespace,
-which can be configured by setting `--olm-namespace=[non-default-olm-namespace]` for `operator-sdk olm` subcommands.
+which can be configured by setting `--olm-namespace=[non-default-olm-namespace]` for `operator-sdk olm status|uninstall` subcommands.
 
 You can check if OLM is already installed by running the following command,
 which will detect the installed OLM version automatically (0.15.1 in this example):