Skip to content

Commit bf1e736

Browse files
authored
Merge pull request #197 from fanminshi/add_contribution_guide
*: add CONTRIBUTING.MD
2 parents 6ceeb4a + 68b0380 commit bf1e736

File tree

3 files changed

+125
-0
lines changed

3 files changed

+125
-0
lines changed

CONTRIBUTING.MD

Lines changed: 64 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,64 @@
1+
# How to contribute
2+
3+
Operator SDK is Apache 2.0 licensed and accepts contributions via GitHub pull requests. This document outlines some of the conventions on commit message formatting, contact points for developers, and other resources to help get contributions into operator-sdk.
4+
5+
# Email and Chat
6+
7+
- Email: [operator-framework][operator_framework]
8+
9+
## Getting started
10+
11+
- Fork the repository on GitHub
12+
- See the [developer guide](./doc/dev/developer_guide.md) for build instructions
13+
14+
## Reporting bugs and creating issues
15+
16+
Reporting bugs is one of the best ways to contribute. However, a good bug report has some very specific qualities, so please read over our short document on [reporting bugs](./doc/dev/reporting_bugs.md) before submitting a bug report. This document might contain links to known issues, another good reason to take a look there before reporting a bug.
17+
18+
## Contribution flow
19+
20+
This is a rough outline of what a contributor's workflow looks like:
21+
22+
- Create a topic branch from where to base the contribution. This is usually master.
23+
- Make commits of logical units.
24+
- Make sure commit messages are in the proper format (see below).
25+
- Push changes in a topic branch to a personal fork of the repository.
26+
- Submit a pull request to coreos/operator-sdk.
27+
- The PR must receive a LGTM from two maintainers found in the MAINTAINERS file.
28+
29+
Thanks for contributing!
30+
31+
### Code style
32+
33+
The coding style suggested by the Golang community is used in operator-sdk. See the [style doc](https://github.com/golang/go/wiki/CodeReviewComments) for details.
34+
35+
Please follow this style to make operator-sdk easy to review, maintain and develop.
36+
37+
### Format of the commit message
38+
39+
We follow a rough convention for commit messages that is designed to answer two
40+
questions: what changed and why. The subject line should feature the what and
41+
the body of the commit should describe the why.
42+
43+
```
44+
scripts: add the test-cluster command
45+
46+
this uses tmux to setup a test cluster that can easily be killed and started for debugging.
47+
48+
Fixes #38
49+
```
50+
51+
The format can be described more formally as follows:
52+
53+
```
54+
<subsystem>: <what changed>
55+
<BLANK LINE>
56+
<why this change was made>
57+
<BLANK LINE>
58+
<footer>
59+
```
60+
61+
The first line is the subject and should be no longer than 70 characters, the second line is always blank, and other lines should be wrapped at 80 characters. This allows the message to be easier to read on GitHub as well as in various git tools.
62+
63+
64+
[operator_framework]: https://groups.google.com/forum/#!forum/operator-framework

doc/dev/developer_guide.md

Lines changed: 39 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,39 @@
1+
# Developer guide
2+
3+
This document explains how to setup your dev environment.
4+
5+
## Download Operator SDK
6+
7+
Go to https://github.com/coreos/operator-sdk and follow the [fork guide][fork_guide] to fork, clone, and setup the local operator-sdk repository.
8+
9+
## Vendor dependencies
10+
11+
We use [dep](https://github.com/golang/dep) to manage dependencies.
12+
Run the following in the project root directory to update the vendored dependencies:
13+
14+
```sh
15+
$ cd $GOPATH/src/github.com/coreos/operator-sdk
16+
$ dep ensure
17+
```
18+
19+
## Build the Operator SDK CLI
20+
21+
Requirement:
22+
- Go 1.9+
23+
24+
Build the Operator SDK CLI `operator-sdk` binary:
25+
26+
```sh
27+
# TODO: replace this with the ./build script.
28+
$ go install github.com/coreos/operator-sdk/commands/operator-sdk
29+
```
30+
31+
## Testing
32+
33+
Run unit tests:
34+
35+
```sh
36+
TODO: use ./test script
37+
```
38+
39+
[fork_guide]:https://help.github.com/articles/fork-a-repo/

doc/dev/reporting_bugs.md

Lines changed: 22 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,22 @@
1+
# Reporting bugs
2+
3+
If any part of the operator-sdk project has bugs or documentation mistakes, please let us know by [opening an issue][operator-sdk-issue]. We treat bugs and mistakes very seriously and believe no issue is too small. Before creating a bug report, please check that an issue reporting the same problem does not already exist.
4+
5+
To make the bug report accurate and easy to understand, please try to create bug reports that are:
6+
7+
- Specific. Include as much details as possible: which version, what environment, what configuration, etc.
8+
9+
- Reproducible. Include the steps to reproduce the problem. We understand some issues might be hard to reproduce, please includes the steps that might lead to the problem.
10+
11+
- Isolated. Please try to isolate and reproduce the bug with minimum dependencies. It would significantly slow down the speed to fix a bug if too many dependencies are involved in a bug report. Debugging external systems that rely on operator-sdk is out of scope, but we are happy to provide guidance in the right direction or help with using operator-sdk itself.
12+
13+
- Unique. Do not duplicate existing bug report.
14+
15+
- Scoped. One bug per report. Do not follow up with another bug inside one report.
16+
17+
It may be worthwhile to read [Elika Etemad’s article on filing good bug reports][filing-good-bugs] before creating a bug report.
18+
19+
We might ask for further information to locate a bug. A duplicated bug report will be closed.
20+
21+
[operator-sdk-issue]: https://github.com/coreos/operator-sdk/issues/new
22+
[filing-good-bugs]: http://fantasai.inkedblade.net/style/talks/filing-good-bugs/

0 commit comments

Comments
 (0)