[v0.19.x] internal/registry/labels.go: FindMetadataDir fix (#3829)

Co-authored-by: Joe Lanford <[email protected]>

Author: openshift-cherrypick-robot

changelog/fragments/fix-find-metadata-dir.yaml

@@ -0,0 +1,7 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      Fixed issue that caused scorecard to fail loading local bundle due to a
+      bug search method for the bundle metadata directory.
+    kind: bugfix

internal/registry/labels.go

@@ -90,9 +90,8 @@ func FindMetadataDir(bundleRoot string) (metadataDir string, err error) {
 		_, err = os.Stat(filepath.Join(path, registrybundle.AnnotationsFile))
 		if err == nil || errors.Is(err, os.ErrExist) {
 			metadataDir = path
-			return nil
 		}
-		return err
+		return nil
 	})
 	if err != nil {
 		return "", err