fix bundle validate subcommand bug (#6274)

that would cause a 0 exit code even if there were validation failures

fixes #6247

Signed-off-by: Bryce Palmer <[email protected]>

Author: everettraven

changelog/fragments/6247-bundle-validate-exit-code.yaml

@@ -0,0 +1,8 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      For `operator-sdk bundle validate`: Fix a bug that would make the command exit with a 0 exit code even if there
+      were validation failures.
+    kind: "bugfix"
+    breaking: false

internal/cmd/operator-sdk/bundle/validate/cmd.go

@@ -159,10 +159,11 @@ func NewCmd() *cobra.Command {
 			}
 
 			// if a test failed don't print that it was successful
-			if !failed {
-				logger.Info("All validation tests have completed successfully")
+			if failed {
+				os.Exit(1)
 			}
 
+			logger.Info("All validation tests have completed successfully")
 			return nil
 		},
 	}