Skip to content

Commit dabb596

Browse files
authored
Bug 1874736: pkg/{ansible,helm}: add git commit logging (#3850)
1 parent afd46ce commit dabb596

File tree

3 files changed

+23
-15
lines changed

3 files changed

+23
-15
lines changed
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
entries:
2+
- description: >
3+
In `ansible-operator` and `helm-operator`, print git commit
4+
when logging version information.
5+
kind: "change"
6+
breaking: false

pkg/ansible/run.go

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -23,19 +23,6 @@ import (
2323
"strconv"
2424
"strings"
2525

26-
"github.com/operator-framework/operator-sdk/pkg/ansible/controller"
27-
aoflags "github.com/operator-framework/operator-sdk/pkg/ansible/flags"
28-
proxy "github.com/operator-framework/operator-sdk/pkg/ansible/proxy"
29-
"github.com/operator-framework/operator-sdk/pkg/ansible/proxy/controllermap"
30-
"github.com/operator-framework/operator-sdk/pkg/ansible/runner"
31-
"github.com/operator-framework/operator-sdk/pkg/ansible/watches"
32-
"github.com/operator-framework/operator-sdk/pkg/k8sutil"
33-
kubemetrics "github.com/operator-framework/operator-sdk/pkg/kube-metrics"
34-
"github.com/operator-framework/operator-sdk/pkg/leader"
35-
"github.com/operator-framework/operator-sdk/pkg/metrics"
36-
sdkVersion "github.com/operator-framework/operator-sdk/version"
37-
"sigs.k8s.io/controller-runtime/pkg/healthz"
38-
3926
v1 "k8s.io/api/core/v1"
4027
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
4128
"k8s.io/apimachinery/pkg/runtime/schema"
@@ -44,9 +31,22 @@ import (
4431
"sigs.k8s.io/controller-runtime/pkg/cache"
4532
"sigs.k8s.io/controller-runtime/pkg/client"
4633
"sigs.k8s.io/controller-runtime/pkg/client/config"
34+
"sigs.k8s.io/controller-runtime/pkg/healthz"
4735
logf "sigs.k8s.io/controller-runtime/pkg/log"
4836
"sigs.k8s.io/controller-runtime/pkg/manager"
4937
"sigs.k8s.io/controller-runtime/pkg/manager/signals"
38+
39+
"github.com/operator-framework/operator-sdk/pkg/ansible/controller"
40+
aoflags "github.com/operator-framework/operator-sdk/pkg/ansible/flags"
41+
proxy "github.com/operator-framework/operator-sdk/pkg/ansible/proxy"
42+
"github.com/operator-framework/operator-sdk/pkg/ansible/proxy/controllermap"
43+
"github.com/operator-framework/operator-sdk/pkg/ansible/runner"
44+
"github.com/operator-framework/operator-sdk/pkg/ansible/watches"
45+
"github.com/operator-framework/operator-sdk/pkg/k8sutil"
46+
kubemetrics "github.com/operator-framework/operator-sdk/pkg/kube-metrics"
47+
"github.com/operator-framework/operator-sdk/pkg/leader"
48+
"github.com/operator-framework/operator-sdk/pkg/metrics"
49+
sdkVersion "github.com/operator-framework/operator-sdk/version"
5050
)
5151

5252
var (
@@ -60,7 +60,8 @@ var (
6060
func printVersion() {
6161
log.Info(fmt.Sprintf("Go Version: %s", runtime.Version()))
6262
log.Info(fmt.Sprintf("Go OS/Arch: %s/%s", runtime.GOOS, runtime.GOARCH))
63-
log.Info(fmt.Sprintf("Version of operator-sdk: %v", sdkVersion.Version))
63+
log.Info(fmt.Sprintf("Version of ansible-operator: %v", sdkVersion.Version))
64+
log.Info(fmt.Sprintf("Git commit of ansible-operator: %v", sdkVersion.GitCommit))
6465
}
6566

6667
// Run will start the ansible operator and proxy, blocking until one of them

pkg/helm/run.go

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -56,7 +56,8 @@ var log = logf.Log.WithName("cmd")
5656
func printVersion() {
5757
log.Info(fmt.Sprintf("Go Version: %s", runtime.Version()))
5858
log.Info(fmt.Sprintf("Go OS/Arch: %s/%s", runtime.GOOS, runtime.GOARCH))
59-
log.Info(fmt.Sprintf("Version of operator-sdk: %v", sdkVersion.Version))
59+
log.Info(fmt.Sprintf("Version of helm-operator: %v", sdkVersion.Version))
60+
log.Info(fmt.Sprintf("Git commit of helm-operator: %v", sdkVersion.GitCommit))
6061
}
6162

6263
// Run runs the helm operator

0 commit comments

Comments
 (0)