Skip to content

Commit e3005bf

Browse files
Increased the helm operator verbosity threshold for release diffs (#5307)
Signed-off-by: Venkat Ramaraju <[email protected]>
1 parent eccd240 commit e3005bf

File tree

2 files changed

+20
-3
lines changed

2 files changed

+20
-3
lines changed
Lines changed: 17 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,17 @@
1+
# entries is a list of entries to include in
2+
# release notes and/or the migration guide
3+
entries:
4+
- description: >
5+
Helm operator reconciliation diffs are now logged only at the zap
6+
debug level.
7+
8+
# kind is one of:
9+
# - addition
10+
# - change
11+
# - deprecation
12+
# - removal
13+
# - bugfix
14+
kind: "removal"
15+
16+
# Is this a breaking change?
17+
breaking: false

internal/helm/controller/reconcile.go

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -130,7 +130,7 @@ func (r HelmOperatorReconciler) Reconcile(ctx context.Context, request reconcile
130130
log.Info("Release not found")
131131
} else {
132132
log.Info("Uninstalled release")
133-
if log.V(0).Enabled() && uninstalledRelease != nil {
133+
if log.V(1).Enabled() && uninstalledRelease != nil {
134134
fmt.Println(diff.Generate(uninstalledRelease.Manifest, ""))
135135
}
136136
if !wait {
@@ -252,7 +252,7 @@ func (r HelmOperatorReconciler) Reconcile(ctx context.Context, request reconcile
252252
}
253253

254254
log.Info("Installed release")
255-
if log.V(0).Enabled() {
255+
if log.V(1).Enabled() {
256256
fmt.Println(diff.Generate("", installedRelease.Manifest))
257257
}
258258
log.V(1).Info("Config values", "values", installedRelease.Config)
@@ -315,7 +315,7 @@ func (r HelmOperatorReconciler) Reconcile(ctx context.Context, request reconcile
315315
}
316316

317317
log.Info("Upgraded release", "force", force)
318-
if log.V(0).Enabled() {
318+
if log.V(1).Enabled() {
319319
fmt.Println(diff.Generate(previousRelease.Manifest, upgradedRelease.Manifest))
320320
}
321321
log.V(1).Info("Config values", "values", upgradedRelease.Config)

0 commit comments

Comments
 (0)