fix: printout errors even if we have a timeout (#5628)

Signed-off-by: jesus m. rodriguez <[email protected]>

Author: jmrodri

changelog/fragments/scorecard-deadline.yaml

@@ -0,0 +1,17 @@
+# entries is a list of entries to include in
+# release notes and/or the migration guide
+entries:
+  - description: >
+      scorecard will now printout test results, if any, even when there is a context timeout.
+      This will allow underlying errors from a test to be shown helping users address the issues.
+
+    # kind is one of:
+    # - addition
+    # - change
+    # - deprecation
+    # - removal
+    # - bugfix
+    kind: "change"
+
+    # Is this a breaking change?
+    breaking: false

internal/cmd/operator-sdk/scorecard/cmd.go

@@ -233,6 +233,12 @@ func (c *scorecardCmd) run() (err error) {
 
 		scorecardTests, err = o.Run(ctx)
 		if err != nil {
+			// if we got a timeout; printout the test results if there are any
+			if err == context.DeadlineExceeded {
+				if errpo := c.printOutput(scorecardTests); errpo != nil {
+					log.Fatal(errpo)
+				}
+			}
 			return fmt.Errorf("error running tests %w", err)
 		}
 	}