Merge pull request #20480 from opf/fix/documents-blocknotejs-avatars-preload

ba1ash · web-flow · commit 078d40af7b67 · 2025-10-01T10:07:14.000+02:00
Preload user attachments before creating avatar_url list.
diff --git a/lib/primer/open_project/forms/block_note_editor.rb b/lib/primer/open_project/forms/block_note_editor.rb
@@ -51,7 +51,7 @@ def initialize(input:, value:, document_id:)
           super()
           @input = input
           @value = value
-          @users = User.active.map do |user|
+          @users = User.active.preload(:attachments).map do |user|
             {
               id: user.id,
               username: user.name,

Original file line number	Diff line number	Diff line change
`@@ -51,7 +51,7 @@ def initialize(input:, value:, document_id:)`
`51`	`51`	`super()`
`52`	`52`	`@input = input`
`53`	`53`	`@value = value`
`54`		`- @users = User.active.map do \|user\|`
	`54`	`+ @users = User.active.preload(:attachments).map do \|user\|`
`55`	`55`	`{`
`56`	`56`	`id: user.id,`
`57`	`57`	`username: user.name,`