[#73188] Remove EE guards from boards

Make action boards available in Community Edition by removing
board_view-based frontend gating and aligning boards feature coverage
with the new default behavior.

https://community.openproject.org/wp/73188

Author: myabc

frontend/src/app/core/setup/globals/onboarding/onboarding_tour.ts

@@ -92,28 +92,18 @@ function workPackageFullViewTour() {
   });
 }
 
-function ganttTour(configuration:ConfigurationService) {
+function ganttTour(_configuration:ConfigurationService) {
   initializeTour('ganttTourFinished');
 
   const boardsDemoDataAvailable = getMetaContent('boards_demo_data_available') === 'true';
   const teamPlannerDemoDataAvailable = getMetaContent('demo_view_of_type_team_planner_seeded') === 'true';
-  const eeTokenAvailable = configuration.availableFeatures.includes('board_view');
 
   waitForElement('.work-package--results-tbody', '#content', () => {
     let steps:OnboardingStep[] = ganttOnboardingTourSteps();
-    // Check for EE edition
-    if (eeTokenAvailable) {
-      // ... and available seed data of boards.
-      // Then add boards to the tour, otherwise skip it.
-      if (boardsDemoDataAvailable && moduleVisible('boards')) {
-        steps = steps.concat(navigateToBoardStep('enterprise'));
-      } else if (teamPlannerDemoDataAvailable && moduleVisible('team-planner-view')) {
-        steps = steps.concat(navigateToTeamPlannerStep());
-      } else {
-        steps = steps.concat(menuTourSteps());
-      }
-    } else if (boardsDemoDataAvailable && moduleVisible('boards')) {
-      steps = steps.concat(navigateToBoardStep('basic'));
+    if (boardsDemoDataAvailable && moduleVisible('boards')) {
+      steps = steps.concat(navigateToBoardStep('enterprise'));
+    } else if (teamPlannerDemoDataAvailable && moduleVisible('team-planner-view')) {
+      steps = steps.concat(navigateToTeamPlannerStep());
     } else {
       steps = steps.concat(menuTourSteps());
     }
@@ -122,14 +112,13 @@ function ganttTour(configuration:ConfigurationService) {
   });
 }
 
-function boardTour(configuration:ConfigurationService) {
+function boardTour(_configuration:ConfigurationService) {
   initializeTour('boardsTourFinished');
 
   const teamPlannerDemoDataAvailable = getMetaContent('demo_view_of_type_team_planner_seeded') === 'true';
-  const eeTokenAvailable = configuration.availableFeatures.includes('board_view');
 
   waitForElement('wp-single-card', '#content', () => {
-    let steps:OnboardingStep[] = eeTokenAvailable ? boardTourSteps('enterprise') : boardTourSteps('basic');
+    let steps:OnboardingStep[] = boardTourSteps('enterprise');
 
     // Available seed data of team planner.
     // Then add Team planner to the tour, otherwise skip it.

frontend/src/app/features/boards/board/board-actions/board-actions-registry.service.ts

@@ -1,6 +1,5 @@
 import { Injectable } from '@angular/core';
 import { BoardActionService } from 'core-app/features/boards/board/board-actions/board-action.service';
-import { BannersService } from 'core-app/core/enterprise/banners.service';
 
 export interface ITileViewEntry {
   text:string;
@@ -13,10 +12,6 @@ export interface ITileViewEntry {
 
 @Injectable({ providedIn: 'root' })
 export class BoardActionsRegistryService {
-  constructor(
-    private bannersService:BannersService,
-  ) {}
-
   private mapping:Record<string, BoardActionService> = {};
 
   public add(attribute:string, service:BoardActionService):void {
@@ -30,7 +25,6 @@ export class BoardActionsRegistryService {
       icon: '',
       description: '',
       image: '',
-      disabled: !this.bannersService.allowsTo('board_view'),
     }));
   }
 

frontend/src/app/features/boards/board/board-partitioned-page/board-list-container.component.html

@@ -1,57 +1,49 @@
 @if ((board$ | async); as board) {
-  @if (!board.isFree) {
-    <op-enterprise-banner-frame class="boards-list--enterprise-banner"
-      feature="board_view"
-      [dismissable]="true"
-     />
-  }
-  @if (available) {
-    <div
-      class="boards-list--container"
-      [ngClass]="{ '-free' : board.isFree }"
-      #container
-      cdkDropList
-      [cdkDropListDisabled]="!board.editable"
-      cdkDropListOrientation="horizontal"
-      (cdkDropListDropped)="moveList(board, $event)"
-      >
-      @for (boardWidget of boardWidgets; track trackByQueryId($index, boardWidget)) {
-        <div
-          class="boards-list--item"
-          cdkDrag
-          [cdkDragData]="boardWidget"
-          >
-          @if (board.editable) {
-            <span
-              class="boards-list-item-handle icon icon-drag-handle"
-            cdkDragHandle></span>
-          }
-          <board-list [resource]="boardWidget"
-            [board]="board"
-            (onRemove)="removeList(board, boardWidget)"
-            (visibilityChange)="changeVisibilityOfList(board, boardWidget, $event)" />
+  <div
+    class="boards-list--container"
+    [ngClass]="{ '-free' : board.isFree }"
+    #container
+    cdkDropList
+    [cdkDropListDisabled]="!board.editable"
+    cdkDropListOrientation="horizontal"
+    (cdkDropListDropped)="moveList(board, $event)"
+    >
+    @for (boardWidget of boardWidgets; track trackByQueryId($index, boardWidget)) {
+      <div
+        class="boards-list--item"
+        cdkDrag
+        [cdkDragData]="boardWidget"
+        >
+        @if (board.editable) {
+          <span
+            class="boards-list-item-handle icon icon-drag-handle"
+          cdkDragHandle></span>
+        }
+        <board-list [resource]="boardWidget"
+          [board]="board"
+          (onRemove)="removeList(board, boardWidget)"
+          (visibilityChange)="changeVisibilityOfList(board, boardWidget, $event)" />
+      </div>
+    }
+    @if (showHiddenListWarning) {
+      <span
+        class="boards-list--tooltip tooltip--right"
+        [attr.data-tooltip]="text.hiddenListWarning">
+        <i class="icon icon-attention"></i>
+      </span>
+    }
+    @if (board.editable) {
+      <div class="boards-list--add-item -no-text-select"
+        role="button"
+        tabindex="0"
+        (click)="addList(board)"
+        (keydown.enter)="addList(board)"
+        (keydown.space)="addList(board)">
+        <div class="boards-list--add-item-text">
+          <op-icon icon-classes="icon-add icon-context" />
+          <span [textContent]="text.addList"></span>
         </div>
-      }
-      @if (showHiddenListWarning) {
-        <span
-          class="boards-list--tooltip tooltip--right"
-          [attr.data-tooltip]="text.hiddenListWarning">
-          <i class="icon icon-attention"></i>
-        </span>
-      }
-      @if (board.editable) {
-        <div class="boards-list--add-item -no-text-select"
-          role="button"
-          tabindex="0"
-          (click)="addList(board)"
-          (keydown.enter)="addList(board)"
-          (keydown.space)="addList(board)">
-          <div class="boards-list--add-item-text">
-            <op-icon icon-classes="icon-add icon-context" />
-            <span [textContent]="text.addList"></span>
-          </div>
-        </div>
-      }
-    </div>
-  }
+      </div>
+    }
+  </div>
 }

frontend/src/app/features/boards/board/board-partitioned-page/board-list-container.component.ts

@@ -17,7 +17,6 @@ import { HalResourceNotificationService } from 'core-app/features/hal/services/h
 import { BoardListsService } from 'core-app/features/boards/board/board-list/board-lists.service';
 import { OpModalService } from 'core-app/shared/components/modal/modal.service';
 import { BoardService } from 'core-app/features/boards/board/board.service';
-import { BannersService } from 'core-app/core/enterprise/banners.service';
 import { DragAndDropService } from 'core-app/shared/helpers/drag-and-drop/drag-and-drop.service';
 import { QueryUpdatedService } from 'core-app/features/boards/board/query-updated/query-updated.service';
 import { UntilDestroyedMixin } from 'core-app/shared/helpers/angular/until-destroyed.mixin';
@@ -89,8 +88,6 @@ export class BoardListContainerComponent extends UntilDestroyedMixin implements
 
   showHiddenListWarning = false;
 
-  available = this.Banner.allowsTo('board_view');
-
   private currentQueryUpdatedMonitoring:Subscription;
 
   constructor(
@@ -105,7 +102,6 @@ readonly I18n:I18nService,
     readonly injector:Injector,
     readonly apiV3Service:ApiV3Service,
     readonly Boards:BoardService,
-    readonly Banner:BannersService,
     readonly boardListCrossSelectionService:BoardListCrossSelectionService,
     readonly wpStatesInitialization:WorkPackageStatesInitializationService,
     readonly Drag:DragAndDropService,
@@ -126,10 +122,6 @@ readonly I18n:I18nService,
         tap((board) => this.setupQueryUpdatedMonitoring(board)),
       );
 
-    this.board$.subscribe((board) => {
-      this.available = this.Banner.allowsTo('board_view') || board.isFree;
-    });
-
     this.Boards.currentBoard$.next(id);
 
     this.boardListCrossSelectionService

modules/boards/spec/features/board_enterprise_spec.rb

@@ -32,15 +32,10 @@
 require_relative "support/board_index_page"
 require_relative "support/board_page"
 
-RSpec.describe "Boards enterprise spec", :js do
+RSpec.describe "Boards availability", :js do
   shared_let(:admin) { create(:admin) }
 
   shared_let(:project) { create(:project, enabled_module_names: %i[work_package_tracking board_view]) }
-  shared_let(:priority) { create(:default_priority) }
-  shared_let(:status) { create(:default_status) }
-
-  let(:board_index) { Pages::BoardIndex.new(project) }
-
   shared_let(:manual_board) { create(:board_grid_with_query, name: "My board", project:) }
   shared_let(:action_board) do
     create(:subproject_board,
@@ -49,61 +44,30 @@
            projects_columns: [])
   end
 
-  context "when EE inactive" do
-    before do
-      login_as(admin)
-      board_index.visit!
-    end
-
-    it "disabled all action boards" do
-      page.find('[data-test-selector="add-board-button"]', text: "Board").click
-
-      expect(page).to have_css("#{test_selector('op-tile-block')}:not(.-disabled)", text: "Basic")
-      expect(page).to have_css("#{test_selector('op-tile-block')}.-disabled", count: 5)
-    end
-
-    it "shows a banner on the action board" do
-      # Expect both existing boards to show
-      expect(page).to have_content "My board"
-      expect(page).to have_content "Subproject board"
-
-      board_page = board_index.open_board(manual_board)
-      board_page.expect_query "My board"
-      wait_for_network_idle # wait for the banner to be loaded
-      expect(page).not_to have_enterprise_banner
+  let(:board_index) { Pages::BoardIndex.new(project) }
 
-      board_index.visit!
-      board_page = board_index.open_board(action_board)
-      board_page.expect_query "Subproject board"
-      expect(page).to have_enterprise_banner
-    end
+  before do
+    login_as(admin)
+    board_index.visit!
   end
 
-  context "when EE active", with_ee: %i[board_view] do
-    before do
-      login_as(admin)
-      board_index.visit!
-    end
+  it "enables all board types" do
+    page.find('[data-test-selector="add-board-button"]', text: "Board").click
 
-    it "enables all options" do
-      page.find('[data-test-selector="add-board-button"]', text: "Board").click
-
-      expect(page).to have_css("#{test_selector('op-tile-block')}:not(.-disabled)", count: 6)
-    end
+    expect(page).to have_css("#{test_selector('op-tile-block')}:not(.-disabled)", count: 6)
+  end
 
-    it "shows the action board" do
-      # Expect both existing boards to show
-      expect(page).to have_content "My board"
-      expect(page).to have_content "Subproject board"
+  it "renders action boards without an enterprise banner" do
+    expect(page).to have_content "My board"
+    expect(page).to have_content "Subproject board"
 
-      board_page = board_index.open_board(manual_board)
-      board_page.expect_query "My board"
-      expect(page).not_to have_enterprise_banner
+    board_page = board_index.open_board(manual_board)
+    board_page.expect_query "My board"
+    expect(page).not_to have_enterprise_banner
 
-      board_index.visit!
-      board_page = board_index.open_board(action_board)
-      board_page.expect_query "Subproject board"
-      expect(page).not_to have_enterprise_banner
-    end
+    board_index.visit!
+    board_page = board_index.open_board(action_board)
+    board_page.expect_query "Subproject board"
+    expect(page).not_to have_enterprise_banner
   end
 end