[#72942] Add explicit sprint task board creation

Split sprint task board access into explicit create and read paths.

- add POST taskboard route and controller action
- stop lazy board creation from taskboard show
- restore sprint menu task board actions with start sprint state
- update focused controller, routing, component, and service specs

https://community.openproject.org/wp/72942

Author: myabc

modules/backlogs/app/components/backlogs/sprint_menu_component.html.erb

@@ -36,6 +36,17 @@ See COPYRIGHT and LICENSE files for more details.
       tooltip_direction: :se
     )
 
+    if show_start_sprint_action?
+      menu.with_item(
+        label: t(".action_menu.start_sprint"),
+        tag: :button,
+        href: backlogs_project_sprint_taskboard_path(project, sprint),
+        form_arguments: { method: :post }
+      ) do |item|
+        item.with_leading_visual_icon(icon: :play)
+      end
+    end
+
     if user_allowed?(:create_sprints)
       menu.with_item(
         label: t(".action_menu.edit_sprint"),
@@ -74,15 +85,16 @@ See COPYRIGHT and LICENSE files for more details.
       item.with_leading_visual_icon(icon: :"op-view-list")
     end
 
-    # menu.with_item(
-    #   # TODO: what to do with the task board?
-    #   label: t(".action_menu.task_board"),
-    #   tag: :a,
-    #   href: backlogs_project_sprint_taskboard_path(project, sprint)
-    # ) do |item|
-    #   item.with_leading_visual_icon(icon: :"op-view-cards")
-    # end
-    #
+    if show_task_board_link?
+      menu.with_item(
+        label: t(".action_menu.task_board"),
+        tag: :a,
+        href: backlogs_project_sprint_taskboard_path(project, sprint)
+      ) do |item|
+        item.with_leading_visual_icon(icon: :"op-view-cards")
+      end
+    end
+
     # menu.with_item(
     #   # TODO: what to do with the burndown chart?
     #   label: t(".action_menu.burndown_chart"),

modules/backlogs/app/components/backlogs/sprint_menu_component.rb

@@ -48,6 +48,22 @@ def stories
 
     private
 
+    def scrum_projects_active?
+      OpenProject::FeatureDecisions.scrum_projects_active?
+    end
+
+    def task_board
+      @task_board ||= Boards::SprintTaskBoardCreateService.find(project:, sprint:)
+    end
+
+    def show_task_board_link?
+      !scrum_projects_active? || task_board.present?
+    end
+
+    def show_start_sprint_action?
+      scrum_projects_active? && task_board.blank? && user_allowed?(:start_complete_sprint)
+    end
+
     def user_allowed?(permission)
       current_user.allowed_in_project?(permission, project)
     end

modules/backlogs/app/controllers/rb_taskboards_controller.rb

@@ -33,11 +33,15 @@ class RbTaskboardsController < RbApplicationController
 
   helper :taskboards
 
-  before_action :load_or_create_board, if: -> { OpenProject::FeatureDecisions.scrum_projects_active? }
+  before_action :not_authorized_on_feature_flag_inactive, only: :create
 
   def show
     if OpenProject::FeatureDecisions.scrum_projects_active?
-      redirect_to project_work_package_board_path(@project, @board)
+      @board = Boards::SprintTaskBoardCreateService.find(project: @project, sprint: @sprint)
+
+      return redirect_to(project_work_package_board_path(@project, @board)) if @board
+
+      render_404
     else
       @statuses     = Type.find(Task.type).statuses
       @story_ids    = @sprint.stories(@project).map(&:id)
@@ -47,17 +51,34 @@ def show
     end
   end
 
-  private
-
-  def load_or_create_board
+  def create
     result = Boards::SprintTaskBoardCreateService
-      .ensure(user: current_user, project: @project, sprint: @sprint, name: @sprint.board_name)
+      .new(user: current_user)
+      .call(project: @project, sprint: @sprint, name: @sprint.board_name)
 
     if result.success?
-      @board = result.result
+      redirect_to project_work_package_board_path(@project, result.result)
     else
       flash[:error] = t(:error_task_board_creation_failed)
-      return redirect_back_or_to(backlogs_project_backlogs_path(@project)) # rubocop:disable Style/RedundantReturn
+      redirect_back_or_to(backlogs_project_backlogs_path(@project))
     end
   end
+
+  private
+
+  def load_sprint_and_project
+    @project = Project.visible.find(params[:project_id])
+
+    return unless (@sprint_id = params.delete(:sprint_id))
+
+    @sprint = if OpenProject::FeatureDecisions.scrum_projects_active?
+                Agile::Sprint.for_project(@project).visible.find(@sprint_id)
+              else
+                Sprint.visible.apply_to(@project).find(@sprint_id)
+              end
+  end
+
+  def not_authorized_on_feature_flag_inactive
+    render_404 unless OpenProject::FeatureDecisions.scrum_projects_active?
+  end
 end

modules/backlogs/config/locales/en.yml

@@ -131,6 +131,7 @@ en:
     sprint_menu_component:
       label_actions: "Sprint actions"
       action_menu:
+        start_sprint: "Start sprint"
         edit_sprint: "Edit sprint"
         new_story: "New story"
         stories_tasks: "Stories/Tasks"

modules/backlogs/config/routes.rb

@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 #-- copyright
 # OpenProject is an open source project management software.
 # Copyright (C) the OpenProject GmbH
@@ -59,7 +61,7 @@
       resources :sprints, controller: :rb_sprints, only: %i[update] do
         resource :query,            controller: :rb_queries,          only: :show
 
-        resource :taskboard,        controller: :rb_taskboards,       only: :show
+        resource :taskboard,        controller: :rb_taskboards,       only: %i[show create]
 
         resource :wiki,             controller: :rb_wikis,            only: %i[show edit]
 

modules/backlogs/lib/open_project/backlogs/engine.rb

@@ -95,7 +95,7 @@ def self.settings
                    dependencies: :view_sprints
 
         permission :start_complete_sprint,
-                   {},
+                   { rb_taskboards: :create },
                    permissible_on: :project,
                    require: :member,
                    dependencies: %i[view_sprints manage_board_views],

modules/backlogs/spec/components/backlogs/sprint_menu_component_spec.rb

@@ -36,27 +36,35 @@
 
   let(:project) { create(:project, types: [type_feature, type_task]) }
   let(:sprint) { create(:agile_sprint, project:, name: "Sprint 1", start_date: Date.yesterday, finish_date: Date.tomorrow) }
-  let(:stories) { [] }
   let(:user) { create(:user) }
   let(:permissions) { [] }
+  let(:board) { nil }
 
   before do
     allow(Setting)
       .to receive(:plugin_openproject_backlogs)
       .and_return("story_types" => [type_feature.id.to_s], "task_type" => type_task.id.to_s)
 
-    # Set up user with specific permissions
     create(:member,
            project:,
            principal: user,
            roles: [create(:project_role, permissions:)])
     login_as(user)
+
+    allow(Boards::SprintTaskBoardCreateService)
+      .to receive(:find)
+      .with(project:, sprint:)
+      .and_return(board)
   end
 
   def render_component
     render_inline(described_class.new(sprint:, project:, current_user: user))
   end
 
+  def menu_items
+    page.all(:role, :menu_item).map { it.text.squish }
+  end
+
   describe "permission-based items" do
     context "with :manage_sprint_items permission" do
       let(:permissions) { %i[view_sprints manage_sprint_items] }
@@ -102,6 +110,53 @@ def render_component
     end
   end
 
+  describe "task board actions" do
+    let(:permissions) { %i[view_sprints view_work_packages] }
+
+    context "with the feature flag inactive", with_flag: { scrum_projects: false } do
+      it "shows Task board after Stories/Tasks" do
+        render_component
+
+        expect(menu_items).to include("Stories/Tasks", "Task board")
+        expect(menu_items.index("Task board")).to be > menu_items.index("Stories/Tasks")
+      end
+    end
+
+    context "with the feature flag active", with_flag: { scrum_projects: true } do
+      context "when a board exists" do
+        let(:board) { build_stubbed(:board_grid, project:) }
+
+        it "shows Task board after Stories/Tasks" do
+          render_component
+
+          expect(menu_items).to include("Stories/Tasks", "Task board")
+          expect(menu_items.index("Task board")).to be > menu_items.index("Stories/Tasks")
+        end
+      end
+
+      context "when no board exists and the user can start the sprint" do
+        let(:permissions) { %i[view_sprints view_work_packages start_complete_sprint] }
+
+        it "shows Start sprint as the first item" do
+          render_component
+
+          expect(menu_items.first).to eq("Start sprint")
+          expect(page).to have_octicon(:play)
+          expect(page).to have_no_selector(:menuitem, text: "Task board")
+        end
+      end
+
+      context "when no board exists and the user cannot start the sprint" do
+        it "does not show task-board-related items" do
+          render_component
+
+          expect(page).to have_no_selector(:menuitem, text: "Start sprint")
+          expect(page).to have_no_selector(:menuitem, text: "Task board")
+        end
+      end
+    end
+  end
+
   describe "always-visible items" do
     let(:permissions) { [:view_sprints] }