Release OpenProject 12.0.1

Author: oliverguenther

Gemfile

@@ -188,9 +188,9 @@ gem 'mini_magick', '~> 4.11.0', require: false
 
 # Sentry error reporting, loaded on demand
 group :sentry do
-  gem "sentry-delayed_job", '~> 4.7.0', require: false
-  gem "sentry-rails", '~> 4.7.0', require: false
-  gem "sentry-ruby", '~> 4.7.0',  require: false
+  gem "sentry-delayed_job", '~> 4.8.0', require: false
+  gem "sentry-rails", '~> 4.8.0', require: false
+  gem "sentry-ruby", '~> 4.8.0',  require: false
 end
 
 group :test do

Gemfile.lock

@@ -875,17 +875,17 @@ GEM
       rexml (~> 3.2, >= 3.2.5)
       rubyzip (>= 1.2.2)
     semantic (1.6.1)
-    sentry-delayed_job (4.7.3)
+    sentry-delayed_job (4.8.0)
       delayed_job (>= 4.0)
-      sentry-ruby-core (~> 4.7.0)
-    sentry-rails (4.7.3)
+      sentry-ruby-core (~> 4.8.0)
+    sentry-rails (4.8.0)
       railties (>= 5.0)
-      sentry-ruby-core (~> 4.7.0)
-    sentry-ruby (4.7.3)
+      sentry-ruby-core (~> 4.8.0)
+    sentry-ruby (4.8.0)
       concurrent-ruby (~> 1.0, >= 1.0.2)
       faraday (>= 1.0)
-      sentry-ruby-core (= 4.7.3)
-    sentry-ruby-core (4.7.3)
+      sentry-ruby-core (= 4.8.0)
+    sentry-ruby-core (4.8.0)
       concurrent-ruby
       faraday
     shoulda-context (2.0.0)
@@ -1112,9 +1112,9 @@ DEPENDENCIES
   secure_headers (~> 6.3.0)
   selenium-webdriver (~> 4.0)
   semantic (~> 1.6.1)
-  sentry-delayed_job (~> 4.7.0)
-  sentry-rails (~> 4.7.0)
-  sentry-ruby (~> 4.7.0)
+  sentry-delayed_job (~> 4.8.0)
+  sentry-rails (~> 4.8.0)
+  sentry-ruby (~> 4.8.0)
   shoulda-context (~> 2.0)
   shoulda-matchers (~> 5.0)
   spring

app/controllers/errors_controller.rb

@@ -14,11 +14,17 @@ def unacceptable
   end
 
   def internal_error
-    render_500
+    render_500 error_options
   end
 
   private
 
+  def error_options
+    {
+      exception: request.env["action_dispatch.exception"] || request.env["sentry.rescued_exception"]
+    }.compact
+  end
+
   def use_layout
     'only_logo'
   end

app/models/mail_handler.rb

@@ -36,7 +36,7 @@ class UnauthorizedAction < StandardError; end
 
   class MissingInformation < StandardError; end
 
-  attr_reader :email, :user, :options
+  attr_reader :email, :sender_email, :user, :options
 
   ##
   # Code copied from base class and extended with optional options parameter
@@ -69,7 +69,7 @@ def self.with_options(options)
   # Returns the created object (eg. an issue, a message) or false
   def receive(email)
     @email = email
-    sender_email = email.from.to_a.first.to_s.strip
+    @sender_email = email.from.to_a.first.to_s.strip
     # Ignore emails received from the application emission address to avoid hell cycles
     if sender_email.downcase == Setting.mail_from.to_s.strip.downcase
       log "ignoring email from emission address [#{sender_email}]"

app/models/user.rb

@@ -66,6 +66,12 @@ class User < Principal
            class_name: 'Doorkeeper::Application',
            as: :owner
 
+  # Meeting memberships
+  has_many :meeting_participants,
+           class_name: 'MeetingParticipant',
+           inverse_of: :user,
+           dependent: :destroy
+
   has_many :notification_settings, dependent: :destroy
 
   # Users blocked via brute force prevention

config/initializers/sentry.rb

@@ -10,8 +10,6 @@
   # as we're dynamically loading it
   # https://github.com/getsentry/sentry-ruby/blob/master/sentry-rails/lib/sentry/rails/railtie.rb#L8-L13
   OpenProject::Application.configure do |app|
-    # need to be placed at first to capture as many errors as possible
-    app.config.middleware.insert 0, Sentry::Rails::CaptureExceptions
     # need to be placed at last to smuggle app exceptions via env
     app.config.middleware.use(Sentry::Rails::RescuedExceptionInterceptor)
   end
@@ -24,10 +22,24 @@ class SentryJob < Sentry::SendEventJob
 
   Sentry.init do |config|
     config.dsn = OpenProject::Logging::SentryLogger.sentry_dsn
-    config.breadcrumbs_logger = [:active_support_logger]
+    config.breadcrumbs_logger = OpenProject::Configuration.sentry_breadcrumb_loggers.map(&:to_sym)
 
-    # Submit events as delayed job
-    config.async = lambda { |event, hint| ::SentryJob.perform_later(event, hint) }
+    # Submit events as delayed job only when requested to do that
+    if ENV['OPENPROJECT_SENTRY_DELAYED_JOB'] == 'true'
+      config.async = lambda do |event, hint|
+        ::SentryJob.perform_later(event, hint)
+      end
+    end
+
+    # Output debug info for sentry
+    config.before_send = lambda do |event, hint|
+      Rails.logger.debug do
+        payload_sizes = event.to_json_compatible.transform_values { |v| JSON.generate(v).bytesize }.inspect
+        "[Sentry] will send event #{hint}. Payload sizes are #{payload_sizes.inspect}"
+      end
+
+      event
+    end
 
     # Don't send loaded modules
     config.send_modules = false

config/locales/crowdin/js-it.yml

@@ -291,7 +291,8 @@ it:
             standard:
               learn_about_link: https://www.openproject.org/blog/openproject-12-0-release
               new_features_html: >
-                The release contains various new features and improvements: <br> <ul class="%{list_styling_class}"> <li>With the new <b>in-app notifications</b> you receive all important updates directly in the application and don't get a flood of emails anymore.</li> <li>The new <b>notification center</b> shows all the changes, including intuitive filter options, e.g. by reason for notification or projects. It even allows editing directly in a split view.</li> <li>Improved <b>notification settings</b> allow to fine-tune for which actions and in which projects you want to receive a notification.</li> <li><b>Email reminders</b> can be configured to receive important updates via a daily email summary.</li> <li>The work package auto-completer for relations now also shows additional information (project name, status, ...) to easily identify the respective work package.</li> </ul>
+                La nuova versione contiene varie nuove funzionalità e miglioramenti: <br> <ul class="%{list_styling_class}"> <li>Con le nuove <b>notifiche in-app</b> ricevi tutti gli aggiornamenti importanti direttamente nell'applicazione e non riceverai più una marea di email.</li> <li>Il nuovo <b>centro notifiche</b> mostra tutte le modifiche, comprese le opzioni di filtro intuitive, ad es. per motivo di notifica o progetti. Consente anche la modifica direttamente in una vista divisa.</li> <li>Le <b>impostazioni di notifica</b> migliorate consentono di mettere a punto per quali azioni e in quali progetti si desidera ricevere una notifica.</li> <li><b>I promemoria email</b> possono essere configurati per ricevere aggiornamenti importanti tramite un riepilogo email giornaliero</li> <li>Il completamento automatico delle macro-attività per le relazioni ora mostra anche informazioni aggiuntive (nome del progetto, stato, ...) per identificare facilmente la rispettiva macro-attività.</li> </ul>
+
             bim:
               learn_about_link: https://www.openproject.org/blog/openproject-12-0-release
               new_features_html: >
@@ -557,7 +558,7 @@ it:
             description: 'Ricevi una notifica ogni volta che qualcuno ti menziona ovunque'
           involved:
             title: 'Assegnato a me o responsabile'
-            description: 'Receive notifications for all activities on work packages for which I am assignee or accountable'
+            description: 'Ricevi notifiche per tutte le attività sui pacchetti di lavoro di cui sei assegnatario o responsabile.'
           watched: 'Aggiornamenti sugli elementi osservati'
           work_package_commented: 'Tutti i nuovi commenti'
           work_package_created: 'Nuove macro-attività'
@@ -576,7 +577,7 @@ it:
           description: 'Queste impostazioni specifiche di progetto sostituiscono le impostazioni predefinite sopra'
           add: 'Aggiungi impostazione per il progetto'
           already_selected: 'Questo progetto è già selezionato'
-          remove: 'Remove project settings'
+          remove: 'Rimuovi impostazioni progetto'
     password_confirmation:
       field_description: 'È necessario inserire la password dell''account per confermare la modifica.'
       title: 'Confermare la password per continuare'

config/locales/crowdin/js-ru.yml

@@ -290,7 +290,7 @@ ru:
             standard:
               learn_about_link: https://www.openproject.org/blog/openproject-12-0-release
               new_features_html: >
-                The release contains various new features and improvements: <br> <ul class="%{list_styling_class}"> <li>With the new <b>in-app notifications</b> you receive all important updates directly in the application and don't get a flood of emails anymore.</li> <li>The new <b>notification center</b> shows all the changes, including intuitive filter options, e.g. by reason for notification or projects. It even allows editing directly in a split view.</li> <li>Improved <b>notification settings</b> allow to fine-tune for which actions and in which projects you want to receive a notification.</li> <li><b>Email reminders</b> can be configured to receive important updates via a daily email summary.</li> <li>The work package auto-completer for relations now also shows additional information (project name, status, ...) to easily identify the respective work package.</li> </ul>
+                Релиз содержит различные новые функции и улучшения: <br> <ul class="%{list_styling_class}"> <li>С новыми <b>уведомлениями в приложении</b> вы получаете все важные обновления непосредственно в приложении и больше не получать письма от спама.</li> <li>Новый <b>центр уведомлений</b> показывает все изменения, включая интуитивные настройки фильтра. по причинам для уведомлений или проектов. Это даже позволяет редактировать непосредственно в виде раздельного просмотра.</li> <li>Улучшено <b>настройка уведомлений</b> позволяет тонкости, для каких действий и в каких проектах вы хотите получать уведомления.</li> <li><b>напоминания электронной почты</b> могут быть настроены на получение важных обновлений ежедневно по электронной почте.</li> <li>Пакет работ автоматически дополняет отношения теперь также показывает дополнительную информацию (название проекта, статус, . ), чтобы легко определить соответствующий пакет работ.</li> </ul>
             bim:
               learn_about_link: https://www.openproject.org/blog/openproject-12-0-release
               new_features_html: >
@@ -558,7 +558,7 @@ ru:
             description: 'Получать уведомления каждый раз, когда кто-то упоминает меня в любом месте'
           involved:
             title: 'Назначен мне или подотчетен'
-            description: 'Receive notifications for all activities on work packages for which I am assignee or accountable'
+            description: 'Получать уведомления о всех видах деятельности в пакетах работ, с которыми я связан.'
           watched: 'Обновления просмотренных элементов'
           work_package_commented: 'Все новые комментарии'
           work_package_created: 'Новые пакеты работ'
@@ -577,7 +577,7 @@ ru:
           description: 'Эти настройки специфического проекта переопределяют настройки по умолчанию'
           add: 'Добавить настройку для проекта'
           already_selected: 'Этот проект уже выбран'
-          remove: 'Remove project settings'
+          remove: 'Удалить настройки проекта'
     password_confirmation:
       field_description: 'Необходимо ввести свой пароль для подтверждения изменений.'
       title: 'Для продолжения введите свой пароль'

config/locales/crowdin/ru.yml

@@ -1381,18 +1381,18 @@ ru:
         watched: "Вы просматриваете %{work_package}"
     update_info_mail:
       body: >
-        We are excited to announce the release of OpenProject 12.0. It's a major release that will hopefully significantly improve the way you use OpenProject.
+        Мы рады объявить о выпуске OpenProject 12.0. Это основной релиз, который, как мы надеемся, значительно улучшит процесс использования OpenProject.
 
-        Starting with this release, we are introducing in-app notifications. From now on, you will receive notifications for updates to work packages directly in OpenProject. You can mark these notifications as read, reply to a comment or even directly modify work package attributes without leaving the notification center.
+        Начиная с этого выпуска, мы представляем Центр уведомлений. Теперь вы будете получать уведомления об обновлениях для пакетов работ непосредственно в OpenProject. Вы можете отметить эти уведомления как прочитанные, ответить на комментарий или даже напрямую изменить атрибуты пакетов работ не выходя из Центра уведомлений.
 
-        This also means that we will no longer be using emails for notifications. We think the new notification center is a better place to view and act upon these updates. Nevertheless, if you would like continue receiving updates via email, you can choose to receive daily email reminders at particular times of your choosing.
+        Это также означает, что мы больше не будем использовать электронные письма для уведомлений. Мы считаем, что Центр уведомлений лучше просматривать и реагировать на эти обновления. Тем не менее, если вы хотите продолжать получать обновления по электронной почте, вы можете ежедневно получать напоминания по электронной почте в определенные моменты по вашему выбору.
 
-        Please make sure to verify your new default notification settings, and set your preferences for notifications and email reminders via your account settings. You can do this through the “Change email settings” button bellow.
+        Вы можете установить настройки уведомлений и напоминаний по электронной почте через настройки учетной записи, или оставить их без изменений, чтобы сохранить стандартные. Вы можете сделать это с помощью кнопки «Изменить настройки электронной почты» ниже.
 
-        We hope you find in-app notifications useful and that they makes you even more productive.
+        Мы надеемся, что вы найдете Центр уведомлений полезным и что он сделает вас еще более продуктивным.
 
-        Sincerely,
-        The OpenProject team
+        Искренне
+        Команда OpenProject
       body_header: 'Версия 12.0 с центром уведомлений'
       body_subheader: 'Новости'
       subject: 'Важные изменения в уведомлениях с релизом 12.0'

docs/api/apiv3/paths/group.yml

@@ -196,7 +196,7 @@ patch:
                 errorIdentifier: urn:openproject-org:api:v3:errors:NotFound
                 message: The requested resource could not be found.
       description: |-
-        Returned if the membership does not exist or the client does not have sufficient permissions
+        Returned if the group does not exist or the client does not have sufficient permissions
         to see it.
 
         **Required permission** If the user has the *manage members* permission in at least one project the user will be able to query all groups. If not, the user
@@ -224,7 +224,35 @@ patch:
       headers: {}
   tags:
   - Groups
-  description: Updates the given group by applying the attributes provided in the
+  description: |-
+    Updates the given group by applying the attributes provided in the
     body.
+
+    Please note that the `members` array provided will override the existing set of members (similar to a PUT). A client thus
+    has to provide the complete list of members the group is to have after the PATCH even if only one member is to be added.
   operationId: Update_group
+  requestBody:
+    content:
+      application/json:
+        schema:
+          example:
+            _links:
+              members:
+                - href: "/api/v3/users/363"
+                - href: "/api/v3/users/60"
+            name: The group
+          properties:
+            _links:
+              properties:
+                members:
+                  type: arrray
+                  items:
+                    type: object
+                    properties:
+                      href:
+                        type: string
+              type: object
+            name:
+              type: string
+          type: object
   summary: Update group