Merge pull request #22291 from opf/bug/72927-story-drag-and-drop-error-handling-dev

[#72927] Fix drag and drop error handling (dev follow-up)

Author: myabc

modules/backlogs/spec/components/backlogs/backlog_component_spec.rb

@@ -31,6 +31,8 @@
 require "rails_helper"
 
 RSpec.describe Backlogs::BacklogComponent, type: :component do
+  include Rails.application.routes.url_helpers
+
   shared_let(:type_feature) { create(:type_feature) }
   shared_let(:type_task) { create(:type_task) }
   shared_let(:default_status) { create(:default_status) }
@@ -115,6 +117,8 @@ def render_component
         render_component
 
         box = page.find(".Box")
+        expect(box["data-generic-drag-and-drop-target"]).to eq("container")
+        expect(box["data-target-container-accessor"]).to eq(":scope > ul")
         expect(box["data-target-id"]).to eq(sprint.id.to_s)
         expect(box["data-target-allowed-drag-type"]).to eq("story")
       end
@@ -125,7 +129,7 @@ def render_component
         story_row = page.find(".Box-row[id='story_#{story1.id}']")
         expect(story_row["data-draggable-id"]).to eq(story1.id.to_s)
         expect(story_row["data-draggable-type"]).to eq("story")
-        expect(story_row["data-drop-url"]).to include("move")
+        expect(story_row["data-drop-url"]).to end_with(move_backlogs_project_sprint_story_path(project, sprint, story1))
       end
 
       it "renders story rows with proper classes" do

modules/backlogs/spec/components/backlogs/sprint_component_spec.rb

@@ -31,6 +31,8 @@
 require "rails_helper"
 
 RSpec.describe Backlogs::SprintComponent, type: :component do
+  include Rails.application.routes.url_helpers
+
   shared_let(:type_feature) { create(:type_feature) }
   shared_let(:type_task) { create(:type_task) }
   shared_let(:default_status) { create(:default_status) }
@@ -106,6 +108,8 @@ def render_component
         render_component
 
         box = page.find(".Box")
+        expect(box["data-generic-drag-and-drop-target"]).to eq("container")
+        expect(box["data-target-container-accessor"]).to eq(":scope > ul")
         expect(box["data-target-id"]).to eq(sprint.id.to_s)
         expect(box["data-target-allowed-drag-type"]).to eq("story")
       end
@@ -116,7 +120,7 @@ def render_component
         story_row = page.find(".Box-row[id='work_package_#{story1.id}']")
         expect(story_row["data-draggable-id"]).to eq(story1.id.to_s)
         expect(story_row["data-draggable-type"]).to eq("story")
-        expect(story_row["data-drop-url"]).to include("move")
+        expect(story_row["data-drop-url"]).to end_with(move_backlogs_project_sprint_story_path(project, sprint, story1))
       end
 
       it "renders story rows with proper classes" do

modules/backlogs/spec/components/backlogs/story_component_spec.rb

@@ -97,6 +97,13 @@ def render_component
 
       expect(page).to have_css("action-menu")
     end
+
+    it "renders a drag handle compatible with GenericDragAndDropController" do
+      render_component
+
+      expect(page).to have_css(".DragHandle[role='button'][tabindex='0']")
+      expect(page).to have_css(".DragHandle[aria-label='Move Test Story Subject']")
+    end
   end
 
   describe "story points handling" do