Release OpenProject 12.2.1

Author: oliverguenther

.github/CODEOWNERS

@@ -0,0 +1,15 @@
+# Frontend rules
+*.js @opf/frontend
+*.ts @opf/frontend
+
+# Backend rules
+*.rb @opf/backend
+
+# docs rules
+/docs/ @opf/doc-writers
+
+# Tech doc rules
+/docs/development @opf/tech-writers 
+/docs/installation-and-operations @opf/tech-writers 
+/docs/system-admin-guide @opf/tech-writers 
+/docs/api @opf/tech-writers @opf/backend

app/helpers/static_links_helper.rb

@@ -37,4 +37,13 @@ def static_link_to(key, label: nil)
             class: 'openproject--static-link',
             target: '_blank', rel: 'noopener'
   end
+
+  ##
+  # Link to the correct installation guides for the current selected method
+  def installation_guide_link
+    val = OpenProject::Configuration.installation_type
+    link = OpenProject::Static::Links.links[:"#{val}_installation"] || OpenProject::Static::Links.links[:installation_guides]
+
+    link[:href]
+  end
 end

app/helpers/warning_bar_helper.rb

@@ -40,7 +40,7 @@ def render_host_and_protocol_mismatch?
   end
 
   def setting_protocol_mismatched?
-    request.ssl? != OpenProject::Configuration.secure_connection?
+    request.ssl? != OpenProject::Configuration.https?
   end
 
   def setting_hostname_mismatched?

app/models/journal.rb

@@ -101,6 +101,14 @@ def previous
     predecessor
   end
 
+  def successor
+    @successor ||= self.class
+                       .where(journable_type:, journable_id:)
+                       .where("#{self.class.table_name}.version > ?", version)
+                       .order(version: :asc)
+                       .first
+  end
+
   def noop?
     (!notes || notes&.empty?) && get_changes.empty?
   end

app/models/setting/aliases.rb

@@ -33,7 +33,7 @@ module Aliases
     ##
     # Restore the previous Setting.protocol now replaced by https?
     def protocol
-      if OpenProject::Configuration.secure_connection?
+      if OpenProject::Configuration.https?
         'https'
       else
         'http'

app/services/journals/create_service.rb

@@ -177,22 +177,25 @@ def create_journal_sql(predecessor, notes)
     def cleanup_predecessor_data(predecessor)
       cleanup_predecessor(predecessor,
                           data_table_name,
-                          :id)
+                          :id,
+                          :data_id)
     end
 
     def cleanup_predecessor_attachable(predecessor)
       cleanup_predecessor(predecessor,
                           'attachable_journals',
-                          :journal_id)
+                          :journal_id,
+                          :id)
     end
 
     def cleanup_predecessor_customizable(predecessor)
       cleanup_predecessor(predecessor,
                           'customizable_journals',
-                          :journal_id)
+                          :journal_id,
+                          :id)
     end
 
-    def cleanup_predecessor(predecessor, table_name, column)
+    def cleanup_predecessor(predecessor, table_name, column, referenced_id)
       return "SELECT 1" unless predecessor
 
       sql = <<~SQL
@@ -204,7 +207,7 @@ def cleanup_predecessor(predecessor, table_name, column)
       SQL
 
       sanitize sql,
-               column => predecessor.id
+               column => predecessor.send(referenced_id)
     end
 
     def update_or_insert_journal_sql(predecessor, notes)

app/views/warning_bar/_host_and_protocol_mismatch.html.erb

@@ -3,12 +3,13 @@
 
   <% if setting_protocol_mismatched? %>
     <p>
-      <strong><%= t 'warning_bar.protocol_mismatch.title' %></strong>
+      <strong><%= t 'warning_bar.https_mismatch.title' %></strong>
       <br/>
-      <%= t 'warning_bar.protocol_mismatch.text_html',
+      <%= t 'warning_bar.https_mismatch.text_html',
             set_protocol: Setting.protocol,
             actual_protocol: request.ssl? ? 'https' : 'http',
-            setting_path: admin_settings_general_path
+            setting_value: request.ssl? ? 'OPENPROJECT_HTTPS=true' : 'OPENPROJECT_HTTPS=false',
+            more_info_path: installation_guide_link
       %>
     </p>
   <% end %>

config/configuration.yml.example

@@ -208,9 +208,6 @@ default:
   #
   # rails_relative_url_root: ""
 
-  # whether to force ssl in production
-  rails_force_ssl: false
-
   # Absolute path to the directory where attachments are stored.
   # The default is the 'files' directory in your OpenProject instance.
   # Your OpenProject instance needs to have write permission on this

config/constants/settings/definition.rb

@@ -381,6 +381,8 @@ def load_yaml(source)
     def cast(value)
       return nil if value.nil?
 
+      value = value.call if value.respond_to?(:call)
+
       case format
       when :integer
         value.to_i
@@ -391,11 +393,7 @@ def cast(value)
       when :symbol
         value.to_sym
       else
-        if value.respond_to?(:call)
-          value.call
-        else
-          value
-        end
+        value
       end
     end
 

config/constants/settings/definitions.rb

@@ -666,16 +666,16 @@
       writable: false
 
   # Assume we're running in an TLS terminated connection.
-  # This does not affect HSTS, use +rails_force_ssl+ for that.
   add :https,
       format: :boolean,
-      default: Rails.env.production?,
+      default: -> { Rails.env.production? },
       writable: false
 
-  # Enable HTTPS and HSTS
-  add :rails_force_ssl,
+  # Allow disabling of HSTS headers and http -> https redirects
+  # for non-localhost hosts
+  add :hsts,
       format: :boolean,
-      default: Rails.env.production?,
+      default: true,
       writable: false
 
   add :registration_footer,