Show template selector from global meeting create form as well

Author: mrmir

modules/meeting/app/components/meetings/index/form_component.html.erb

@@ -1,27 +1,6 @@
 <%=
   component_wrapper do
-    primer_form_with(
-      scope: :meeting,
-      model: @meeting,
-      method: form_method,
-      data: {
-        turbo: true,
-        controller: [
-          "show-when-value-selected",
-          "show-when-checked",
-          @meeting.is_a?(RecurringMeeting) ? "recurring-meetings--form" : nil
-        ].compact.join(" "),
-        "recurring-meetings--form-persisted-value": @meeting.persisted?
-      },
-      html: {
-        id: "meeting-form"
-      },
-      url: {
-        controller: form_controller,
-        action: form_action,
-        project_id: @project
-      }
-    ) do |f|
+    primer_form_with(**form_options) do |f|
       flex_layout(mb: 3) do |modal_body|
         if @meeting.errors[:base].present?
           modal_body.with_row do
@@ -35,9 +14,9 @@
           end
         end
 
-        if creating_onetime_meeting? && no_preselection? && available_templates.any?
+        if show_template_selector?
           modal_body.with_row(mb: 3) do
-            render(Meeting::TemplateAutocompleter.new(f, project: @project))
+            render(Meeting::TemplateAutocompleter.new(f, project: effective_project, disabled: template_selector_disabled?, placeholder: template_selector_placeholder))
           end
         end
 

modules/meeting/app/components/meetings/index/form_component.rb

@@ -70,6 +70,29 @@ def form_action
       end
     end
 
+    def form_options
+      {
+        scope: :meeting,
+        model: @meeting,
+        method: form_method,
+        data: {
+          turbo: true,
+          controller: [
+            "show-when-value-selected",
+            "show-when-checked",
+            @meeting.is_a?(RecurringMeeting) ? "recurring-meetings--form" : nil,
+            "meetings--form",
+            use_refresh_on_form_changes? ? "refresh-on-form-changes" : nil
+          ].compact.join(" "),
+          "recurring-meetings--form-persisted-value": @meeting.persisted?,
+          "refresh-on-form-changes-target": "form",
+          "refresh-on-form-changes-turbo-stream-url-value": fetch_templates_url
+        },
+        html: { id: "meeting-form" },
+        url: { controller: form_controller, action: form_action, project_id: @project }
+      }
+    end
+
     def creating_onetime_meeting?
       return false unless EnterpriseToken.allows_to?(:meeting_templates)
 
@@ -80,10 +103,56 @@ def no_preselection?
       !@copy_from
     end
 
+    def show_template_selector?
+      return false unless creating_onetime_meeting? && no_preselection?
+
+      if @project.nil?
+        # Global context - show if user can see any templates
+        globally_visible_templates.any?
+      else
+        # Project context - only show if the project actually has templates
+        available_templates.any?
+      end
+    end
+
+    def template_selector_disabled?
+      effective_project.nil? || available_templates.empty?
+    end
+
+    def template_selector_placeholder
+      if effective_project.nil?
+        I18n.t(:placeholder_meeting_template_select_project_first)
+      elsif available_templates.empty?
+        I18n.t(:placeholder_meeting_template_no_templates_for_project)
+      end
+    end
+
+    def use_refresh_on_form_changes?
+      creating_onetime_meeting? && no_preselection? && @project.nil?
+    end
+
+    def fetch_templates_url
+      if @project
+        fetch_templates_project_meetings_path(@project)
+      else
+        fetch_templates_meetings_path
+      end
+    end
+
     def available_templates
-      return [] unless @project
+      @available_templates ||= if effective_project
+                                 Meeting.templates_visible_in_project(effective_project)
+                               else
+                                 Meeting.templates_visible_globally
+                               end
+    end
+
+    def globally_visible_templates
+      @globally_visible_templates ||= Meeting.templates_visible_globally
+    end
 
-      @available_templates ||= Meeting.templates_visible_in_project(@project)
+    def effective_project
+      @project || @meeting.project
     end
   end
 end

modules/meeting/app/controllers/meetings_controller.rb

@@ -34,13 +34,13 @@ class MeetingsController < ApplicationController
   before_action :determine_date_range, only: %i[history]
   before_action :determine_author, only: %i[history]
   before_action :build_meeting, only: %i[new new_dialog fetch_timezone]
-  before_action :find_meeting, except: %i[index new create new_dialog fetch_timezone]
+  before_action :find_meeting, except: %i[index new create new_dialog fetch_timezone fetch_templates]
   before_action :redirect_to_project, only: %i[show]
   before_action :set_activity, only: %i[history]
   before_action :find_copy_from_meeting, only: %i[create]
   before_action :convert_params, only: %i[create update]
   before_action :prevent_series_template_destruction, only: :destroy
-  before_action :check_for_enterprise_token, only: %i[create new_dialog]
+  before_action :check_for_enterprise_token, only: %i[create new_dialog fetch_templates]
 
   helper :watchers
   include MeetingsHelper
@@ -342,6 +342,17 @@ def fetch_timezone
     respond_with_turbo_streams
   end
 
+  def fetch_templates
+    selected_project = Project.visible.find_by(id: params.dig(:meeting, :project_id))
+    meeting = Meeting.new(project: selected_project)
+
+    update_via_turbo_stream(
+      component: Meetings::Index::FormComponent.new(meeting: meeting, project: nil)
+    )
+
+    respond_with_turbo_streams
+  end
+
   def generate_pdf_dialog
     respond_with_dialog Meetings::Exports::ModalDialogComponent.new(
       meeting: @meeting,

modules/meeting/app/forms/meeting/project_autocompleter.rb

@@ -42,6 +42,7 @@ class Meeting::ProjectAutocompleter < ApplicationForm
         dropdownPosition: "bottom",
         appendTo: "#new-meeting-dialog",
         filters: [{ name: "user_action", operator: "=", values: ["meetings/create"] }],
+        hiddenFieldAction: "change->refresh-on-form-changes#triggerTurboStream",
         data: {
           "test-selector": "project_id"
         }

modules/meeting/app/forms/meeting/template_autocompleter.rb

@@ -38,6 +38,8 @@ class Meeting::TemplateAutocompleter < ApplicationForm
         decorated: true,
         defaultData: false,
         multiple: false,
+        disabled: @disabled,
+        placeholder: @placeholder,
         appendTo: "#new-meeting-dialog",
         data: {
           "test-selector": "template_id"
@@ -53,14 +55,18 @@ class Meeting::TemplateAutocompleter < ApplicationForm
     end
   end
 
-  def initialize(project:)
+  def initialize(project:, disabled: false, placeholder: nil)
     super()
     @project = project
+    @disabled = disabled
+    @placeholder = placeholder
   end
 
   private
 
   def templates
+    return [] if @disabled
+
     Meeting.templates_visible_in_project(@project).order(:title)
   end
 end

modules/meeting/app/models/meeting.rb

@@ -155,6 +155,16 @@ def self.templates_visible_in_project(project, user = User.current)
       .or(available_onetime_templates.where(sharing: :system))
   end
 
+  def self.templates_visible_globally(user = User.current)
+    accessible = Project.allowed_to(user, :view_meetings).to_a
+    ancestor_ids = accessible.flat_map(&:ancestors).pluck(:id).uniq
+
+    available_onetime_templates
+      .where(project_id: accessible.map(&:id))
+      .or(available_onetime_templates.where(sharing: :descendants, project_id: ancestor_ids))
+      .or(available_onetime_templates.where(sharing: :system))
+  end
+
   def recurring?
     recurring_meeting_id.present?
   end

modules/meeting/config/locales/en.yml

@@ -215,6 +215,8 @@ en:
 
   caption_meeting_template_select: "Select a template to automatically copy its agenda items"
   caption_template_project_select: "Please select the project in which to create this meeting template"
+  placeholder_meeting_template_select_project_first: "Select a project first"
+  placeholder_meeting_template_no_templates_for_project: "No templates available for this project"
 
   meeting:
     participants:

modules/meeting/config/routes.rb

@@ -42,6 +42,7 @@
       get :new_dialog
       get "menu" => "meetings/menus#show"
       get :fetch_timezone
+      get :fetch_templates
 
       get "ical/:token", controller: "meetings/ical", action: :index, as: "ical_feed"
 
@@ -58,6 +59,7 @@
         get :new_dialog
         get "menu" => "meetings/menus#show"
         get :fetch_timezone
+        get :fetch_templates
 
         get "templates", action: :index, controller: "meeting_templates", as: "templates"
         get "templates/new_dialog", action: :new_dialog, controller: "meeting_templates", as: "new_dialog_template"

modules/meeting/lib/open_project/meeting/engine.rb

@@ -53,7 +53,7 @@ class Engine < ::Rails::Engine
                    permissible_on: :project
         permission :create_meetings,
                    {
-                     meetings: %i[new create copy new_dialog fetch_timezone],
+                     meetings: %i[new create copy new_dialog fetch_timezone fetch_templates],
                      recurring_meetings: %i[new create copy init template_completed],
                      "recurring_meetings/schedule": %i[update_text],
                      "meetings/menus": %i[show],

modules/meeting/spec/features/meeting_templates/create_meeting_from_template_spec.rb

@@ -199,6 +199,57 @@
     end
   end
 
+  describe "creating meeting from template using template selector from global index", with_ee: [:meeting_templates] do
+    let(:global_meetings_page) { Pages::Meetings::Index.new(project: nil) }
+    let(:template) { create(:onetime_template, project:, title: "Template") }
+
+    before do
+      global_meetings_page.visit!
+    end
+
+    it "shows a template selector when user has access to templates" do
+      template
+
+      global_meetings_page.click_on "add-meeting-button"
+      global_meetings_page.click_on "One-time"
+
+      expect(page).to have_dialog("New one-time meeting")
+
+      # Initially disabled
+      within_dialog "New one-time meeting" do
+        expect(page).to have_css('[data-test-selector="template_id"]', text: "Select a project first")
+      end
+
+      # Disabled when a project with no accessible templates is selected
+      global_meetings_page.set_project(other_project)
+      wait_for_network_idle
+
+      within_dialog "New one-time meeting" do
+        expect(page).to have_css('[data-test-selector="template_id"]', text: "Select a project first")
+      end
+
+      # Enabled when a project with accessible templates is selected
+      global_meetings_page.set_project(project)
+      wait_for_network_idle
+
+      within_dialog "New one-time meeting" do
+        find('[data-test-selector="template_id"]').click
+        expect(page).to have_text(template.title)
+      end
+    end
+
+    it "shows no template selector when user has access to no templates" do
+      global_meetings_page.click_on "add-meeting-button"
+      global_meetings_page.click_on "One-time"
+
+      expect(page).to have_dialog("New one-time meeting")
+
+      within_dialog "New one-time meeting" do
+        expect(page).to have_no_css('[data-test-selector="template_id"]')
+      end
+    end
+  end
+
   describe "creating meeting from template using 'Create from template' button" do
     context "without enterprise token" do
       let!(:template) { create(:onetime_template, project:, title: "Planning template") }