Release OpenProject 12.0.6

Author: oliverguenther

app/controllers/admin/settings/general_settings_controller.rb

@@ -32,6 +32,11 @@ module Admin::Settings
   class GeneralSettingsController < ::Admin::SettingsController
     menu_item :settings_general
 
+    def show
+      super
+      @guessed_host = request.host_with_port.dup
+    end
+
     def default_breadcrumb
       t(:label_general)
     end

app/models/users/scopes/having_reminder_mail_to_send.rb

@@ -69,9 +69,9 @@ def local_time_join(local_times)
         # * reminders are enabled
         # * any of the configured reminder time is the local time
         # * the local workday is enabled to receive a reminder on
-        # If no time zone is present, utc is assumed.
+        # If no time zone is present or if it is blank, the configured default time zone or UTC is assumed.
         # If no reminder settings are present, sending a reminder at 08:00 local time is assumed.
-        # If no workdays are specified, 1 - 5 is assumed which is represents Monday to Friday.
+        # If no workdays are specified, 1 - 5 is assumed which represents Monday to Friday.
         times_sql = arel_table
                       .grouping(Arel::Nodes::ValuesList.new(local_times))
                       .as('t(today_local, hours, zone, workday)')
@@ -80,7 +80,7 @@ def local_time_join(local_times)
 
         <<~SQL.squish
           JOIN (SELECT * FROM #{times_sql.to_sql}) AS local_times
-          ON COALESCE(user_preferences.settings->>'time_zone', #{default_timezone}, 'Etc/UTC') = local_times.zone
+          ON COALESCE(NULLIF(user_preferences.settings->>'time_zone',''), #{default_timezone}, 'Etc/UTC') = local_times.zone
           AND (
             user_preferences.settings->'workdays' @> to_jsonb(local_times.workday)
             OR (

app/workers/announcements/scheduler_job.rb

@@ -31,7 +31,7 @@ class SchedulerJob < ::ApplicationJob
     queue_with_priority :low
 
     def perform(**announcement)
-      User.active.find_each do |user|
+      User.admin.active.find_each do |user|
         AnnouncementMailer
           .announce(user, **announcement)
           .deliver_later

app/workers/backup_job.rb

@@ -161,23 +161,27 @@ def create_backup_archive!(file_name:, db_dump_file_name:, attachments: attachme
       zipfile.get_output_stream("openproject.sql") { |f| f.write File.read(db_dump_file_name) }
     end
 
-    # delete locally cached files that were downloaded just for the backup
-    paths_to_clean.each do |path|
-      FileUtils.rm_rf path
-    end
+    remove_paths! paths_to_clean # delete locally cached files that were downloaded just for the backup
 
     @archived = true
 
     file_name
   end
 
+  def remove_paths!(paths)
+    paths.each do |path|
+      FileUtils.rm_rf path
+    end
+  end
+
   def get_cache_folder_path(attachment)
     # expecting paths like /tmp/op_uploaded_files/1639754082-3468-0002-0911/file.ext
     # just making extra sure so we don't delete anything wrong later on
     unless attachment.diskfile.path =~ /#{attachment.file.cache_dir}\/[^\/]+\/[^\/]+/
       raise "Unexpected cache path for attachment ##{attachment.id}: #{attachment.diskfile}"
     end
 
+    # returning parent as each cached file is in a separate folder which shall be removed too
     Pathname(attachment.diskfile.path).parent.to_s
   end
 

docs/installation-and-operations/installation-faq/README.md

@@ -129,6 +129,18 @@ Another approach would be to restart OpenProject completely, especially after ch
 
 This will be done automatically in case the package based installation is used.
 
+
+
+### The packaged installation cannot be installed or upgraded due to errors. What could cause them?
+
+For packaged installations, the openproject package behaves just like every other system package (dpkg or rpm packages, depending on your distribution). If you encounter errors while trying to install or upgrade, please check the following pieces of information first.
+
+1. You have enough free space available on `/opt` or your root `/` partition. Verify that `df -h` has at least a few GB of free space.
+2. You have enough inodes on your partitions left. Verify with `df -i` . As OpenProject packages contains a high number of files, these might cause problems with low free inode counts.
+3. Make sure you do not have a virus scanner such as Sophos or other pieces of software blocking the installation of packages.
+
+
+
 ### After upgrading I receive the error message "Your OpenProject installation has pending database migrations. You have likely missed running the migrations on your last upgrade. Please check the upgrade guide to properly upgrade your installation." What does that mean?
 
 For some updates of OpenProject, the database layout needs to be adapted to support new features and fix bugs. These changes need to be carried out as part of the update process. This is why it is important to always run `sudo openproject configure`as part of the update process. 
@@ -148,6 +160,8 @@ Mind, that repository integration in the sense that you will be able to checkout
 
 ### How can I uninstall OpenProject (Community Edition or Enterprise on-premises)?
 
-The package based installation is intended to be run on a dedicated system. Dedicated in this case means that no other application software should be served by the server. The system can be either physical or virtual. Removing OpenProject is then equivalent with removing that system. 
+The package based installation is intended to be run on a dedicated system. Dedicated in this case means that no other application software should be served by the server. The system can be either physical or virtual. Removing OpenProject is then equivalent with removing that system or docker instances. 
+
 In case the database is stored on a different system, e.g. within a database cluster, it needs to be removed separately. The database URL can be found within the OpenProject installation, via `openproject config:get DATABASE_URL`.
+
 In case the attachments are stored on a different system, e.g. on an NFS or on S3, they also need to be removed separately.

docs/installation-and-operations/operation/upgrading/README.md

@@ -7,26 +7,25 @@ sidebar_navigation:
 # Upgrading your OpenProject installation
 
 <div class="alert alert-warning" role="alert">
-**Note**: In the rest of this guide, we assume that you have taken the necessary steps to [backup](../backing-up) your OpenProject installation before upgrading.
+**Note**: We strongly recommend that you have backed up your installation before upgrading OpenProject to a newer version, especially when performing multiple upgrades at once. Please follow the [backup](../backing-up) instructions.
 </div>
 
 | Topic                                                        | Content                                                     |
 | ------------------------------------------------------------ | ----------------------------------------------------------- |
 | [Package-based installation](#package-based-installation-debrpm) | How to upgrade a package-based installation of OpenProject. |
 | [Docker-based installation](#compose-based-installation)      | How to upgrade a Docker-based installation of OpenProject.  |
+| [Upgrade notes to 12.x](#upgrade-notes-to-12x)  | How to upgrade from OpenProject 9.x or greater to OpenProject 12.x.     |
 | [Upgrade notes for 8.x to 9.x](#upgrade-notes-for-8x-to-9x)  | How to upgrade from OpenProject 8.x to OpenProject 9.x.     |
 | [Upgrade notes for 7.x to 8.x](#upgrade-notes-for-openproject-7x-to-8x) | How to upgrade from OpenProject 7.x to OpenProject 8.x.     |
 
 ## Package-based installation (DEB/RPM)
 
-Upgrading OpenProject is as easy as installing a newer OpenProject package and
-running the `openproject configure` command.
+This section concerns upgrading of your OpenProject installation for packaged-based installation methods.
 
-<div class="alert alert-info" role="alert">
-
-Please note that the package-based installation uses different release channels for each MAJOR version of OpenProject. This means that if you want to switch from (e.g.) 9.x to 10.x, you will need to perform the steps described in the [installation section](../../installation/packaged) to update your package sources to point to the newer release channel. The rest of this section is only applicable if you want to upgrade a (e.g.) 10.x version to a 10.y version.
-
-</div>
+### Patch and minor releases
+Upgrading to a newer patch or minor version of OpenProject is as easy as installing a newer OpenProject package and
+running the `openproject configure` command. 
+Please follow the steps listed below according to your Linux distribution.
 
 ### Debian / Ubuntu
 
@@ -51,8 +50,34 @@ sudo zypper update openproject
 sudo openproject configure
 ```
 
+### Major upgrades
+
+OpenProject uses a different package repository for each Major version of OpenProject. 
+This means that if you want to switch from (e.g.) OpenProject 11.x to 12.x, you will need to explicitly update your package source to be able to install the newer versions.
+
+The necessary steps are the same as setting up the package source for the first time. You can also check the [installation guide](../../installation/packaged) for more information. Please follow the link below to see the appropriate steps for your Linux distribution.
+
+| Distribution (64 bits only)                 |
+| ------------------------------------------- |
+| [Ubuntu 20.04 Focal](../../installation/packaged/#ubuntu-2004)          |
+| [Ubuntu 18.04 Bionic Beaver](../../installation/packaged/#ubuntu-1804)  |
+| [Ubuntu 16.04 Xenial Xerus](../../installation/packaged/#ubuntu-1604)   |
+| [Debian 11 Bullseye](../../installation/packaged/#debian-11)            |
+| [Debian 10 Buster](../../installation/packaged/#debian-10)              |
+| [Debian 9 Stretch](../../installation/packaged/#debian-9)               |
+| [CentOS/RHEL 8.x](../../installation/packaged/#centos-8--rhel-8)        |
+| [CentOS/RHEL 7.x](../../installation/packaged/#centos-7--rhel-7)        |
+| [Suse Linux Enterprise Server 12](../../installation/packaged/#sles-12) |
+
+After following the steps to update the package source, updating the openproject package and running `openproject configure`, your system will be up to date.
+
+In case you experience issues, please note the exact steps you took, copy the output of all commands you ran and open a post in our [installation support forum](https://community.openproject.org/projects/openproject/forums/9).
+
+
+### Running openproject configure
+
+It is important that you run the `openproject configure` command after _every_ upgrade of OpenProject, as this will ensure your installation is being updated and necessary database migrations are being performed.
 
-<div class="alert alert-info" role="alert">
 Using `openproject configure`, the wizard will display new steps that weren't available yet or had not been configured in previous installations.
 
 If you want to perform changes to your configuration or are unsure what steps are available, you can safely run `openproject reconfigure` to walk through the entire configuration process again.
@@ -124,6 +149,13 @@ sudo chown -R 102 /volume1/openproject/*
 After that it's simply a matter of launching the new container mounted with the copied `pgdata` and `assets` folders
 as described in the [installation section](../../installation/docker/#one-container-per-process-recommended).
 
+## Upgrade notes to 12.x
+
+There are no special steps or caveats when upgrading to OpenProject 12.x or higher from any version greater than 9.x.
+
+Simply follow the upgrade steps outlined above for your type of installation.
+
+
 ## Upgrade notes for 8.x to 9.x
 
 These following points are some known issues regarding the update to 9.0.

docs/release-notes/12-0-5/README.md

@@ -16,3 +16,25 @@ The release contains several bug fixes and we recommend updating to the newest v
 <!--more-->
 #### Bug fixes and changes
 
+- Fixed: Uploaded IFC Model can't be set as Standard Model \[[#40187](https://community.openproject.com/wp/40187)\]
+- Fixed: Git "View Differences" results in 500 error in Repository module. \[[#40191](https://community.openproject.com/wp/40191)\]
+- Fixed: Impossible to identify errors when bulk moving / updating project \[[#40265](https://community.openproject.com/wp/40265)\]
+- Fixed: wrong position of "slice edit" - context menu \[[#40282](https://community.openproject.com/wp/40282)\]
+- Fixed: Incorrect label causes screenreader problems \[[#40296](https://community.openproject.com/wp/40296)\]
+- Fixed: Member updated mails cannot be surpressed \[[#40316](https://community.openproject.com/wp/40316)\]
+- Fixed: Try to open OpenProject  API: Failed to load API definition. \[[#40352](https://community.openproject.com/wp/40352)\]
+- Fixed: Remote attachments cache isn't cleared \[[#40356](https://community.openproject.com/wp/40356)\]
+- Fixed: Form configuration query can not be edited if invalid \[[#40374](https://community.openproject.com/wp/40374)\]
+- Fixed: Seeding with relative URL root creates invalid welcome text \[[#40376](https://community.openproject.com/wp/40376)\]
+- Fixed: Users created from synchronized group have no notification settings \[[#40433](https://community.openproject.com/wp/40433)\]
+- Fixed: Unpaginated api/v3/relations end point \[[#40434](https://community.openproject.com/wp/40434)\]
+- Fixed: Header-based SSO does not allow entering missing attributes \[[#40511](https://community.openproject.com/wp/40511)\]
+
+#### Contributions
+A big thanks to community members for reporting bugs and helping us identifying and providing fixes.
+
+Special thanks for reporting and finding bugs go to
+
+Valentin Ege, Rene Diekstra, Jonas Plum, Frank Schmid
+
+

docs/release-notes/12-0-6/README.md

@@ -0,0 +1,38 @@
+---
+title: OpenProject 12.0.6
+sidebar_navigation:
+    title: 12.0.6
+release_version: 12.0.6
+release_date: 2022-01-17
+---
+
+# OpenProject 12.0.6
+
+Release date: 2022-01-17
+
+We released [OpenProject 12.0.6](https://community.openproject.com/versions/1504).
+The release contains several bug fixes and we recommend updating to the newest version.
+
+<!--more-->
+#### Bug fixes and changes
+
+- Fixed: Notification center empty state showing during loading \[[#39828](https://community.openproject.com/wp/39828)\]
+- Fixed: Notification images are cached for years without invalidation means - old images shown \[[#40143](https://community.openproject.com/wp/40143)\]
+- Fixed: Memory leak in work package split screen \[[#40164](https://community.openproject.com/wp/40164)\]
+- Fixed: Check and update the notifications API documentation \[[#40196](https://community.openproject.com/wp/40196)\]
+- Fixed: 429 OK Error on Administration > Users \[[#40213](https://community.openproject.com/wp/40213)\]
+- Fixed: Disable send_notifications on instantiating new project from template \[[#40348](https://community.openproject.com/wp/40348)\]
+- Fixed: Frontend including editor and time logging unusable when there are many activities \[[#40373](https://community.openproject.com/wp/40373)\]
+- Fixed: no "Example" for Host name in "Administration->General" \[[#40396](https://community.openproject.com/wp/40396)\]
+- Fixed: Don't receive email reminder \[[#40512](https://community.openproject.com/wp/40512)\]
+- Fixed: Only last N projects available for parent project selection \[[#40580](https://community.openproject.com/wp/40580)\]
+- Fixed: Change labels in Russian (expletive) \[[#40581](https://community.openproject.com/wp/40581)\]
+- Fixed: Dropdown menu of parent child board not showing all WPs \[[#40647](https://community.openproject.com/wp/40647)\]
+- Fixed: Backup feature does not work with relative URL root \[[#40656](https://community.openproject.com/wp/40656)\]
+
+#### Contributions
+A big thanks to community members for reporting bugs and helping us identifying and providing fixes.
+
+Special thanks for reporting and finding bugs go to
+
+Artur Neumann, Christina Vechkanova, George Plant

docs/release-notes/README.md

@@ -16,6 +16,13 @@ Stay up to date and get an overview of the new features included in the releases
 <!--- New release notes are generated below. Do not remove comment. -->
 <!--- RELEASE MARKER -->
 
+## 12.0.6
+
+Release date: 2022-01-17
+
+[Release Notes](12-0-6/)
+
+
 ## 12.0.5
 
 Release date: 2022-01-11

docs/system-admin-guide/authentication/saml/README.md

@@ -46,7 +46,7 @@ saml:
   icon: "auth_provider-saml.png"
 
   # omniauth-saml config
-  assertion_consumer_service_url: "https:/<YOUR OPENPROJECT HOSTNAME>/auth/saml/callback"
+  assertion_consumer_service_url: "https://<YOUR OPENPROJECT HOSTNAME>/auth/saml/callback"
   issuer: "https://<YOUR OPENPROJECT HOSTNAME>"
 
   # IF your SSL certificate on your SSO is not trusted on this machine, you need to add it here