Apply underscore fix to ProblematicIdentifiers after rebase

The underscore fix (allowing _ in identifiers per spec) needs to target
ProblematicIdentifiers instead of PreviewQuery after the extraction
refactor on the target branch.

Author: akabiru

app/services/work_packages/identifier_autofix/problematic_identifiers.rb

@@ -51,7 +51,7 @@ class ProblematicIdentifiers
         [:too_long, ->(id, max) { id.length > max }],
         [:numerical, ->(id, _) { id.match?(/\A\d+\z/) }],
         [:starts_with_number, ->(id, _) { id.match?(/\A\d/) }],
-        [:special_characters, ->(id, _) { id.match?(/[^a-zA-Z0-9]/) }],
+        [:special_characters, ->(id, _) { id.match?(/[^a-zA-Z0-9_]/) }],
         [:not_fully_uppercased, ->(id, _) { id != id.upcase }]
       ].freeze
 
@@ -80,7 +80,7 @@ def exclusion_set
       private
 
       def exceeds_max_length        = Project.where("length(identifier) > ?", max_identifier_length)
-      def contains_non_alphanumeric = Project.where("identifier ~ ?", "[^a-zA-Z0-9]")
+      def contains_non_alphanumeric = Project.where("identifier ~ ?", "[^a-zA-Z0-9_]")
       def starts_with_digit         = Project.where("identifier ~ ?", "^[0-9]")
       def not_fully_uppercased      = Project.where("identifier != UPPER(identifier)")
 

spec/services/work_packages/identifier_autofix/preview_query_spec.rb

@@ -61,9 +61,9 @@ def create_valid_project(name:, identifier:)
   context "when a project has underscores and lowercase in its identifier" do
     before { create_valid_project(name: "My Project", identifier: "my_proj") }
 
-    it "flags it as :not_uppercase (underscores are allowed per spec)" do
+    it "flags it as :not_fully_uppercased (underscores are allowed per spec)" do
       expect(result.total_count).to eq(1)
-      expect(result.projects_data.first[:error_reason]).to eq(:not_uppercase)
+      expect(result.projects_data.first[:error_reason]).to eq(:not_fully_uppercased)
     end
   end