Skip to content

Commit 78e3d31

Browse files
committed
[#69596] Use dataset where possible
1 parent a8c7e1b commit 78e3d31

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

frontend/src/stimulus/controllers/hover-card-trigger.controller.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -262,7 +262,7 @@ export default class HoverCardTriggerController extends ApplicationController {
262262
* When there is no URL or if the URL is invalid, will return an empty string.
263263
*/
264264
private parseHoverCardUrl(el:HTMLElement) {
265-
let url = el.getAttribute('data-hover-card-url');
265+
let url = el.dataset.hoverCardUrl;
266266
if (!url) { return ''; }
267267

268268
url = sanitizeUrl(url);
@@ -273,7 +273,7 @@ export default class HoverCardTriggerController extends ApplicationController {
273273
}
274274

275275
private getPopoverTemplateFromId(el:HTMLElement):HTMLTemplateElement|null {
276-
const id = el.getAttribute('data-hover-card-popover-template-id');
276+
const id = el.dataset.hoverCardPopoverTemplateId;
277277
if (!id) { return null; }
278278

279279
const element = document.getElementById(id);
@@ -335,7 +335,7 @@ export default class HoverCardTriggerController extends ApplicationController {
335335
private setPopoverAttributes(popover:HTMLElement) {
336336
popover.classList.add('op-hover-card');
337337
popover.setAttribute('popover', 'auto');
338-
popover.setAttribute('data-hover-card-trigger-target', 'card');
338+
popover.dataset.hoverCardTriggerTarget = 'card';
339339
}
340340

341341
/*

0 commit comments

Comments
 (0)