Skip to content

Commit 92c5ffd

Browse files
committed
rename border box filter bulkActionContainer target to hideWhenFiltering
1 parent 8411302 commit 92c5ffd

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

app/components/projects/settings/life_cycles/index_component.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@
3131
end
3232
end
3333
header_container.with_column(flex_layout: true, justify_content: :flex_end) do |actions_container|
34-
actions_container.with_column(data: { 'projects--settings--border-box-filter-target': 'bulkActionContainer' }) do
34+
actions_container.with_column(data: { 'projects--settings--border-box-filter-target': 'hideWhenFiltering' }) do
3535
render(Primer::Beta::Button.new(
3636
tag: :a,
3737
href: enable_all_project_settings_life_cycle_path(project_id: project),
@@ -45,7 +45,7 @@
4545
t('projects.settings.actions.label_enable_all')
4646
end
4747
end
48-
actions_container.with_column(data: { 'projects--settings--border-box-filter-target': 'bulkActionContainer' }) do
48+
actions_container.with_column(data: { 'projects--settings--border-box-filter-target': 'hideWhenFiltering' }) do
4949
render(Primer::Beta::Button.new(
5050
tag: :a,
5151
href: disable_all_project_settings_life_cycle_path(project_id: project),

app/components/projects/settings/project_custom_field_sections/show_component.html.erb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
end
1414
end
1515
section_header_container.with_column(flex_layout: true, justify_content: :flex_end) do |actions_container|
16-
actions_container.with_column(data: { 'projects--settings--border-box-filter-target': 'bulkActionContainer' }) do
16+
actions_container.with_column(data: { 'projects--settings--border-box-filter-target': 'hideWhenFiltering' }) do
1717
render(Primer::Beta::Button.new(
1818
tag: :a,
1919
href: enable_all_of_section_project_settings_project_custom_fields_path(
@@ -32,7 +32,7 @@
3232
t('projects.settings.actions.label_enable_all')
3333
end
3434
end
35-
actions_container.with_column(data: { 'projects--settings--border-box-filter-target': 'bulkActionContainer' }) do
35+
actions_container.with_column(data: { 'projects--settings--border-box-filter-target': 'hideWhenFiltering' }) do
3636
render(Primer::Beta::Button.new(
3737
tag: :a,
3838
href: disable_all_of_section_project_settings_project_custom_fields_path(

frontend/src/stimulus/controllers/dynamic/projects/settings/border-box-filter.controller.ts

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -32,10 +32,10 @@ import FilterListController from '../../filter/filter-list.controller';
3232

3333
export default class extends FilterListController {
3434
static targets = [
35-
'bulkActionContainer',
35+
'hideWhenFiltering',
3636
];
3737

38-
declare readonly bulkActionContainerTargets:HTMLInputElement[];
38+
declare readonly hideWhenFilteringTargets:HTMLInputElement[];
3939

4040
filterLists() {
4141
const query = this.filterTarget.value.toLowerCase();
@@ -56,13 +56,13 @@ export default class extends FilterListController {
5656
}
5757

5858
hideBulkActionContainers() {
59-
this.bulkActionContainerTargets.forEach((item) => {
59+
this.hideWhenFilteringTargets.forEach((item) => {
6060
this.setVisibility(item, false);
6161
});
6262
}
6363

6464
showBulkActionContainers() {
65-
this.bulkActionContainerTargets.forEach((item) => {
65+
this.hideWhenFilteringTargets.forEach((item) => {
6666
this.setVisibility(item, true);
6767
});
6868
}

0 commit comments

Comments
 (0)