Simplify identifier normalizer

akabiru · akabiru · commit 99a819e5900a · 2026-03-20T09:25:32.000+03:00
Use to_s.strip instead of type-checking guard clause.
diff --git a/app/models/projects/identifier.rb b/app/models/projects/identifier.rb
@@ -39,9 +39,7 @@ module Projects::Identifier
     extend FriendlyId
 
     normalizes :identifier, with: ->(value) {
-      next value unless value.is_a?(String)
-
-      stripped = value.strip
+      stripped = value.to_s.strip
       Setting::WorkPackageIdentifier.alphanumeric? ? stripped.upcase : stripped.downcase
     }
 

Original file line number	Diff line number	Diff line change
`@@ -39,9 +39,7 @@ module Projects::Identifier`
`39`	`39`	`extend FriendlyId`
`40`	`40`
`41`	`41`	`normalizes :identifier, with: ->(value) {`
`42`		`- next value unless value.is_a?(String)`
`43`		`-`
`44`		`- stripped = value.strip`
	`42`	`+ stripped = value.to_s.strip`
`45`	`43`	`Setting::WorkPackageIdentifier.alphanumeric? ? stripped.upcase : stripped.downcase`
`46`	`44`	`}`
`47`	`45`