Basic userSelect field for inplaceEditComponent

Author: HDinger

app/components/open_project/common/inplace_edit_fields/display_fields/display_field_component.rb

@@ -107,6 +107,16 @@ def boolean_display_value(value)
           def writable?
             writable && (@system_arguments[:readonly].nil? || @system_arguments[:readonly] == false)
           end
+
+          def custom_field_values
+            CustomValue
+              .includes(custom_field: :custom_options)
+              .where(
+                custom_field_id: custom_field&.id,
+                customized_id: model.id
+              )
+              .to_a
+          end
         end
       end
     end

app/components/open_project/common/inplace_edit_fields/display_fields/select_list_component.rb

@@ -42,7 +42,7 @@ def render_display_value
 
             if value.present? && value != [nil]
               if custom_field?
-                custom_field_values
+                formatted_custom_field_values
               else
                 value.is_a?(Array) ? value.map(&:to_s).join(", ") : value.to_s
               end
@@ -51,19 +51,12 @@ def render_display_value
             end
           end
 
-          def custom_field_values
-            return @custom_field_values if defined?(@custom_field_values)
+          def formatted_custom_field_values
+            return @formatted_custom_field_values if defined?(@formatted_custom_field_values)
 
-            values = CustomValue
-                       .includes(custom_field: :custom_options)
-                       .where(
-                         custom_field_id: custom_field&.id,
-                         customized_id: model.id
-                       )
-                       .to_a
-                       .map { |v| format_value(v.value, custom_field) }
+            values = custom_field_values.map { |v| format_value(v.value, custom_field) }
 
-            @custom_field_values = custom_field&.multi_value? ? values.join(", ") : values.first
+            @formatted_custom_field_values = custom_field&.multi_value? ? values.join(", ") : values.first
           end
         end
       end

app/components/open_project/common/inplace_edit_fields/display_fields/user_select_list_component.rb

@@ -0,0 +1,71 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+module OpenProject
+  module Common
+    module InplaceEditFields
+      module DisplayFields
+        class UserSelectListComponent < SelectListComponent
+          include CustomFieldsHelper
+
+          attr_reader :model, :attribute, :writable
+
+          def formatted_custom_field_values
+            return @formatted_custom_field_values if defined?(@formatted_custom_field_values)
+
+            cf_values = custom_field_values
+
+            users = cf_values.filter_map(&:typed_value)
+
+            @formatted_custom_field_values = if custom_field.multi_value?
+                                               flex_layout do |avatar_container|
+                                                 users.each do |user|
+                                                   avatar_container.with_row do
+                                                     render_avatar(user)
+                                                   end
+                                                 end
+                                               end
+                                             else
+                                               render_avatar(users.first)
+                                             end
+          end
+
+          private
+
+          def render_avatar(user)
+            return unless user
+
+            render(::Users::AvatarComponent.new(user:, size: :mini))
+          end
+        end
+      end
+    end
+  end
+end

app/components/open_project/common/inplace_edit_fields/user_select_list_component.rb

@@ -0,0 +1,66 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+module OpenProject
+  module Common
+    module InplaceEditFields
+      class UserSelectListComponent < SelectListComponent
+        attr_reader :form, :attribute, :model
+
+        def self.display_class
+          DisplayFields::UserSelectListComponent
+        end
+
+        def initialize(form:, attribute:, model:, **system_arguments)
+          super
+
+          unless custom_field?
+            assign_defaults!
+          end
+        end
+
+        private
+
+        def render_custom_field_input
+          input_class = if custom_field.multi_value?
+                          CustomFields::Inputs::MultiUserSelectList
+                        else
+                          CustomFields::Inputs::SingleUserSelectList
+                        end
+
+          # Use fields_for to create the proper context for custom field inputs
+          form.fields_for(:custom_field_values) do |builder|
+            input_class.new(builder, custom_field:, object: model)
+          end
+        end
+      end
+    end
+  end
+end

config/initializers/inplace_edit_fields.rb

@@ -46,7 +46,7 @@
     "hierarchy" => OpenProject::Common::InplaceEditFields::TextInputComponent, # TODO
     "weighted_item_list" => OpenProject::Common::InplaceEditFields::TextInputComponent, # TODO
     "list" => OpenProject::Common::InplaceEditFields::SelectListComponent,
-    "user" => OpenProject::Common::InplaceEditFields::TextInputComponent, # TODO
+    "user" => OpenProject::Common::InplaceEditFields::UserSelectListComponent,
     "version" => OpenProject::Common::InplaceEditFields::VersionSelectListComponent,
     "calculated_value" => OpenProject::Common::InplaceEditFields::CalculatedValueInputComponent
   }