[#71630] Also update Bim::Bcf::API::V2_1::ProjectsAPI

https://community.openproject.org/wp/71630

This one is an interesting case. The API documentation says an
identifier should be allowed as ID param here:
https://github.com/opf/openproject/blob/dev/docs/api/bcf/bcf-rest-api.md#41-project-services

However, the regex prevented that.
I removed the regex to be able to add the identifier redirect (and
specs for it). I fear that if I don't fix that now, eventually someone
else will find this some day, remove the constraint on the ID but will
not add the redirect.

Author: judithroth

modules/bim/app/controllers/bim/bcf/api/v2_1/projects_api.rb

@@ -41,10 +41,14 @@ def visible_projects
                                                        scope: -> { visible_projects })
                                              .mount
 
-      route_param :id, regexp: /\A(\d+)\z/ do
+      route_param :id do
+        helpers ::API::Helpers::HistoricalIdentifierRedirect
+
         after_validation do
           @project = visible_projects
                      .find(params[:id])
+
+          redirect_if_historical_identifier(:id, @project)
         end
 
         get &::Bim::Bcf::API::V2_1::Endpoints::Show.new(model: Project).mount

modules/bim/spec/requests/api/bcf/v2_1/projects_historical_identifier_redirect_spec.rb

@@ -0,0 +1,45 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+require "rack/test"
+
+RSpec.describe "BCF 2.1 projects historical identifier redirect", content_type: :json do
+  shared_let(:project) { create(:project, enabled_module_names: [:bim]) }
+  shared_let(:role) { create(:project_role, permissions: [:view_work_packages]) }
+  shared_let(:user) { create(:user, member_with_roles: { project => role }) }
+
+  current_user { user }
+
+  describe "GET /api/bcf/2.1/projects/:id" do
+    it_behaves_like "API redirects GET requests using a historical project identifier",
+                    "/api/bcf/2.1/projects/:id"
+  end
+end