Add receiving_projects scope and multi-project boards

Introduces `Agile::Sprint.receiving_projects(sprint)` scope
returning all projects with work packages on the sprint.

Updates `ensure_task_boards` to create boards for all receiving
projects. Moves `board_name` from model to service.

Author: myabc

modules/backlogs/app/models/agile/sprint.rb

@@ -48,6 +48,7 @@ class Sprint < ApplicationRecord
     scopes :for_project,
            :not_completed,
            :order_by_date,
+           :receiving_projects,
            :visible
 
     enum :status,
@@ -84,10 +85,6 @@ def duration
       Day.working.from_range(from: start_date, to: finish_date).count
     end
 
-    def board_name
-      "#{project.name}: #{name}"
-    end
-
     def task_board_for(project)
       task_boards.find_by(project:)
     end

modules/backlogs/app/models/agile/sprints/scopes/receiving_projects.rb

@@ -0,0 +1,40 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+module Agile::Sprints::Scopes::ReceivingProjects
+  extend ActiveSupport::Concern
+
+  class_methods do
+    def receiving_projects(sprint)
+      Project.where(id: sprint.project_id)
+        .or(Project.where(id: sprint.work_packages.select(:project_id)))
+    end
+  end
+end

modules/backlogs/app/services/sprints/start_service.rb

@@ -37,7 +37,7 @@ def initialize(user:, model:, contract_class: Sprints::StartContract)
   private
 
   def persist(service_call)
-    result = ensure_task_board
+    result = ensure_task_boards
     return result if result.failure?
 
     model.active!
@@ -48,13 +48,34 @@ def persist(service_call)
     ServiceResult.failure(result: model, errors: model.errors)
   end
 
-  def ensure_task_board
-    existing_board = model.task_board_for(model.project)
-    return ServiceResult.success(result: existing_board) if existing_board.present?
+  def ensure_task_boards
+    projects = Agile::Sprint.receiving_projects(model)
 
-    Boards::SprintTaskBoardCreateService
-      .new(user:)
-      .call(project: model.project, sprint: model, name: model.board_name)
+    results = projects.map do |project|
+      next ServiceResult.success if model.task_board_for(project).present?
+
+      # TODO: Consider using User.system for board creation so that boards
+      # are created even when the starting user lacks manage_board_views
+      # permission in receiving projects.
+      Boards::SprintTaskBoardCreateService
+        .new(user:)
+        .call(project:, sprint: model, name: board_name)
+    end
+
+    aggregate_failures(results)
+  end
+
+  def aggregate_failures(results)
+    failed = results.select(&:failure?)
+    return ServiceResult.success if failed.empty?
+
+    failed.each_with_object(ServiceResult.failure) do |result, combined|
+      combined.add_dependent!(result)
+    end
+  end
+
+  def board_name
+    "#{model.project.name}: #{model.name}"
   end
 
   def add_only_one_active_sprint_error

modules/backlogs/spec/models/agile/sprint_spec.rb

@@ -120,12 +120,6 @@
     it { is_expected.to belong_to(:project) }
   end
 
-  describe "#board_name" do
-    it "returns the project and sprint name" do
-      expect(sprint.board_name).to eq("#{project.name}: Sprint 1")
-    end
-  end
-
   describe "#task_board_for" do
     let(:sprint) { create(:agile_sprint, project:) }
     let(:other_project) { create(:project) }
@@ -151,7 +145,7 @@
     end
 
     context "when only same-name or same-filter boards exist" do
-      let!(:same_name_board) { create(:board_grid_with_query, project:, name: sprint.board_name) }
+      let!(:same_name_board) { create(:board_grid_with_query, project:, name: "#{project.name}: #{sprint.name}") }
       let!(:matching_filters_board) do
         create(:board_grid_with_query,
                project:,

modules/backlogs/spec/models/agile/sprints/scopes/receiving_projects_spec.rb

@@ -0,0 +1,85 @@
+# frozen_string_literal: true
+
+#-- copyright
+# OpenProject is an open source project management software.
+# Copyright (C) the OpenProject GmbH
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License version 3.
+#
+# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows:
+# Copyright (C) 2006-2013 Jean-Philippe Lang
+# Copyright (C) 2010-2013 the ChiliProject Team
+#
+# This program is free software; you can redistribute it and/or
+# modify it under the terms of the GNU General Public License
+# as published by the Free Software Foundation; either version 2
+# of the License, or (at your option) any later version.
+#
+# This program is distributed in the hope that it will be useful,
+# but WITHOUT ANY WARRANTY; without even the implied warranty of
+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+# GNU General Public License for more details.
+#
+# You should have received a copy of the GNU General Public License
+# along with this program; if not, write to the Free Software
+# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA  02110-1301, USA.
+#
+# See COPYRIGHT and LICENSE files for more details.
+#++
+
+require "spec_helper"
+
+RSpec.describe Agile::Sprints::Scopes::ReceivingProjects do
+  let(:project) { create(:project) }
+  let(:other_project) { create(:project) }
+  let(:sprint) { create(:agile_sprint, project:) }
+
+  describe ".receiving_projects" do
+    subject { Agile::Sprint.receiving_projects(sprint) }
+
+    context "when sprint has no work packages in other projects" do
+      it "returns only the owning project" do
+        expect(subject).to contain_exactly(project)
+      end
+    end
+
+    context "when sprint has work packages in another project" do
+      before do
+        create(:work_package, project: other_project, sprint:)
+      end
+
+      it "returns both the owning project and the receiving project" do
+        expect(subject).to contain_exactly(project, other_project)
+      end
+    end
+
+    context "when sprint has work packages in multiple other projects" do
+      let(:third_project) { create(:project) }
+
+      before do
+        create(:work_package, project: other_project, sprint:)
+        create(:work_package, project: third_project, sprint:)
+      end
+
+      it "returns all projects" do
+        expect(subject).to contain_exactly(project, other_project, third_project)
+      end
+    end
+
+    context "when sprint has work packages only in the owning project" do
+      before do
+        create(:work_package, project:, sprint:)
+      end
+
+      it "returns only the owning project without duplicates" do
+        expect(subject).to contain_exactly(project)
+      end
+    end
+
+    it "resolves in a single query" do
+      sprint # ensure factory queries are done
+      expect { Agile::Sprint.receiving_projects(sprint).load }.to have_a_query_limit(1)
+    end
+  end
+end

modules/backlogs/spec/services/sprints/start_service_spec.rb

@@ -157,4 +157,20 @@
       expect(sprint.reload).to be_in_planning
     end
   end
+
+  context "when work packages exist in a receiving project" do
+    let!(:receiving_project) { create(:project, types: [type_task]) }
+
+    before do
+      create(:work_package, project: receiving_project, type: type_task, sprint:)
+    end
+
+    it "creates boards for both owning and receiving projects", :aggregate_failures do
+      expect { result }.to change(Boards::Grid, :count).by(2)
+      expect(result).to be_success
+      expect(sprint.reload).to be_active
+      expect(sprint.task_board_for(project)).to be_present
+      expect(sprint.task_board_for(receiving_project)).to be_present
+    end
+  end
 end