|
-
-
-
-
- <%= Status.model_name.human %>
-
-
- |
-
-
-
-
-
- <%= t("backlogs.work_package_is_closed") %>
-
-
- |
-
|---|---|
| - <%= status.name %> - | -- <% checkbox_id = status.name.parameterize.underscore %> - <%= styled_label_tag checkbox_id, t("backlogs.label_is_done_status", status_name: status.name), class: "sr-only" %> - <%= (styled_check_box_tag "statuses[][status_id]", status.id.to_s, @statuses_done_for_project.include?(status.id), id: checkbox_id) %> - | -
<%= styled_button_tag t("backlogs.rebuild"), class: "-primary" %>
+<%= + settings_primer_form_with( + url: project_settings_backlogs_path(@project), + model: @project, + method: :patch + ) do |f| +%> + <%= render Projects::Settings::BacklogsSettingsForm.new(f) %> <% end %> diff --git a/modules/backlogs/config/locales/en.yml b/modules/backlogs/config/locales/en.yml index 9e58970b397f..3d26e7049272 100644 --- a/modules/backlogs/config/locales/en.yml +++ b/modules/backlogs/config/locales/en.yml @@ -69,6 +69,7 @@ en: any: "any" column_width: "Column width" definition_of_done: "Definition of Done" + definition_of_done_caption: "Work packages with these statuses are treated as completed in backlog views and reporting." impediment: "Impediment" label_versions_default_fold_state: "Show versions folded" caption_versions_default_fold_state: "Versions will not be expanded by default when viewing backlogs. Each one has to be manually expanded." diff --git a/modules/backlogs/spec/features/projects/backlogs_settings_spec.rb b/modules/backlogs/spec/features/projects/backlogs_settings_spec.rb new file mode 100644 index 000000000000..32e090f31376 --- /dev/null +++ b/modules/backlogs/spec/features/projects/backlogs_settings_spec.rb @@ -0,0 +1,96 @@ +# frozen_string_literal: true + +#-- copyright +# OpenProject is an open source project management software. +# Copyright (C) the OpenProject GmbH +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License version 3. +# +# OpenProject is a fork of ChiliProject, which is a fork of Redmine. The copyright follows: +# Copyright (C) 2006-2013 Jean-Philippe Lang +# Copyright (C) 2010-2013 the ChiliProject Team +# +# This program is free software; you can redistribute it and/or +# modify it under the terms of the GNU General Public License +# as published by the Free Software Foundation; either version 2 +# of the License, or (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301, USA. +# +# See COPYRIGHT and LICENSE files for more details. +#++ + +require "spec_helper" +require_relative "../../support/pages/projects/settings/backlogs" + +RSpec.describe "Backlogs Project Settings", :js do + let!(:project) do + create(:project, + enabled_module_names: %w(backlogs)) + end + let!(:closed_status) { create(:status, name: "Closed", is_closed: true) } + let!(:closed_like_status) { create(:status, name: "Sorta kinda Finished", is_default: true) } + let(:role) do + create(:project_role, + permissions: %i[select_done_statuses]) + end + let!(:current_user) do + create(:user, + member_with_roles: { project => role }) + end + let(:settings_page) { Pages::Projects::Settings::Backlogs.new(project) } + let(:done_status_ids_autocompleter) { FormFields::Primerized::AutocompleteField.new("story_types", selector: "[data-test-selector='done_status_ids_autocomplete']") } + + before do + login_as current_user + end + + it "allows setting a status as done although it is not closed" do + settings_page.visit! + + expect(page).to have_heading "Backlogs" + + wait_for_network_idle + wait_for_autocompleter_options_to_be_loaded + + done_status_ids_autocompleter.expect_blank + done_status_ids_autocompleter.select_option "Closed" + done_status_ids_autocompleter.select_option "Sorta kinda Finished" + + done_status_ids_autocompleter.expect_selected "Closed" + done_status_ids_autocompleter.expect_selected "Sorta kinda Finished" + done_status_ids_autocompleter.expect_not_disabled "Definition of Done" + + done_status_ids_autocompleter.close_autocompleter + + click_button "Save" + + expect_flash(type: :success, message: "Successful update") + + wait_for_network_idle + wait_for_autocompleter_options_to_be_loaded + + done_status_ids_autocompleter.expect_selected "Closed" + done_status_ids_autocompleter.expect_selected "Sorta kinda Finished" + + done_status_ids_autocompleter.deselect_option "Sorta kinda Finished" + + click_button "Save" + + wait_for_network_idle + wait_for_autocompleter_options_to_be_loaded + + expect_flash(type: :success, message: "Successful update") + + done_status_ids_autocompleter.expect_selected "Closed" + done_status_ids_autocompleter.expect_not_selected "Sorta kinda Finished" + end +end