Merge pull request #231 from opf/fix/danger-preview

Fix the dangerDialog form previews

Author: myabc

.changeset/young-doors-explode.md

@@ -0,0 +1,5 @@
+---
+'@openproject/primer-view-components': patch
+---
+
+Fix form preview of DangerConfirmationDialog

previews/primer/open_project/danger_confirmation_dialog_preview.rb

@@ -72,6 +72,18 @@ def custom_icon
           dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed")
         end
       end
+
+      # @label With form using FormBuilder for testing puposes
+      # @hidden
+      def with_form_builder_form_test(route_format: :html)
+        render_with_template(locals: { route_format: route_format })
+      end
+
+      # @label With form for testing purposes
+      # @hidden
+      def with_form_test(route_format: :html)
+        render_with_template(locals: { route_format: route_format })
+      end
     end
   end
 end

previews/primer/open_project/danger_confirmation_dialog_preview/with_form.html.erb

@@ -1,6 +1,6 @@
 <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
     title: "Delete dialog",
-    form_arguments: { action: generic_form_submission_path(format: route_format) }
+    form_arguments: { action: "" } # Use the correct form action here.
   )) do |dialog| %>
   <% dialog.with_show_button { "Click me" } %>
   <% dialog.with_confirmation_message do |message|

previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form.html.erb

@@ -1,4 +1,5 @@
-<%= form_with(url: generic_form_submission_path(format: route_format)) do |f| %>
+<!-- Use the correct form URL here. -->
+<%= form_with(url: "") do |f| %>
   <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
         title: "Delete dialog",
         form_arguments: { builder: f, name: "confirm_very_dangerous_action" }

previews/primer/open_project/danger_confirmation_dialog_preview/with_form_builder_form_test.html.erb

@@ -0,0 +1,13 @@
+<%= form_with(url: generic_form_submission_path(route_format)) do |f| %>
+  <%= render(Primer::OpenProject::DangerConfirmationDialog.new(
+        title: "Delete dialog",
+        form_arguments: { builder: f, name: "confirm_very_dangerous_action" }
+      )) do |dialog| %>
+    <% dialog.with_show_button { "Click me" } %>
+    <% dialog.with_confirmation_message do |message|
+        message.with_heading(tag: :h2).with_content("Permanently delete?")
+        message.with_description_content("This action is not reversible. Please proceed with caution.")
+       end %>
+    <% dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed") %>
+  <% end %>
+<% end %>

previews/primer/open_project/danger_confirmation_dialog_preview/with_form_test.html.erb

@@ -0,0 +1,11 @@
+<%= render(Primer::OpenProject::DangerConfirmationDialog.new(
+    title: "Delete dialog",
+    form_arguments: { action: generic_form_submission_path(route_format) }
+  )) do |dialog| %>
+  <% dialog.with_show_button { "Click me" } %>
+  <% dialog.with_confirmation_message do |message|
+      message.with_heading(tag: :h2).with_content("Permanently delete?")
+      message.with_description_content("This action is not reversible. Please proceed with caution.")
+     end %>
+  <% dialog.with_confirmation_check_box_content("I understand that this deletion cannot be reversed") %>
+<% end %>

test/system/open_project/danger_confirmation_dialog_test.rb

@@ -34,7 +34,7 @@ def test_submit_button_enabled_when_confirmation_check_box_checked
   end
 
   def test_submit_button_submits_form
-    visit_preview(:with_form, route_format: :json)
+    visit_preview(:with_form_test, route_format: :json)
 
     click_button("Click me")
 
@@ -49,7 +49,7 @@ def test_submit_button_submits_form
   end
 
   def test_submit_button_submits_form_builder_form
-    visit_preview(:with_form_builder_form, route_format: :json)
+    visit_preview(:with_form_builder_form_test, route_format: :json)
 
     click_button("Click me")