Skip to content

Commit 5c871a0

Browse files
authored
Merge pull request #275 from opf/bug/63442-missing-space-when-putting-multiple-collapsiblesections-below-each-other
[634442] Missing space when putting multiple CollapsibleSections below each other
2 parents 73cac1d + 15c13c7 commit 5c871a0

File tree

4 files changed

+7
-3
lines changed

4 files changed

+7
-3
lines changed

.changeset/sad-planes-think.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@openproject/primer-view-components': patch
3+
---
4+
5+
Avoid useless space below collapsed CollapsibleSection
-918 Bytes
Loading
-918 Bytes
Loading

app/components/primer/open_project/collapsible_section.html.erb

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
<%= render(Primer::BaseComponent.new(**@system_arguments)) do %>
22
<%= render(Primer::OpenProject::FlexLayout.new) do |flex| %>
3-
<%= flex.with_row(mb: 3,
4-
classes: "CollapsibleSection--triggerArea",
3+
<%= flex.with_row(classes: "CollapsibleSection--triggerArea",
54
data: { action: "click:collapsible-section#toggle" }) do %>
65
<%= render(Primer::OpenProject::FlexLayout.new(display: :flex, align_items: :center)) do |header| %>
76
<%= header.with_column do %>
@@ -19,7 +18,7 @@
1918
<% end %>
2019
<% end %>
2120
<% end %>
22-
<%= flex.with_row(data: { targets: "collapsible-section.collapsibleElements" }) do %>
21+
<%= flex.with_row(mt: 3, data: { targets: "collapsible-section.collapsibleElements" }) do %>
2322
<%= collapsible_content %>
2423
<% end %>
2524
<% end %>

0 commit comments

Comments
 (0)