Merge pull request #369 from opf/code-maintenance/68046-action-menu-refinements

HDinger · web-flow · commit af264e8e3d60 · 2025-10-09T15:15:47.000+02:00
Make the (lazy) action menu spinner aria label translatable and reduce it's size to small
diff --git a/.changeset/eleven-terms-see.md b/.changeset/eleven-terms-see.md
@@ -0,0 +1,5 @@
+---
+'@openproject/primer-view-components': patch
+---
+
+Make the (lazy) action menu spinner aria label translatable and reduce it's size to small
diff --git a/app/components/primer/alpha/action_menu/menu.html.erb b/app/components/primer/alpha/action_menu/menu.html.erb
@@ -13,7 +13,7 @@
               autofocus: true
             }
           ) do %>
-            <%= render Primer::Beta::Spinner.new(aria: { label: "Loading content..." }) %>
+            <%= render Primer::Beta::Spinner.new(aria: { label: I18n.t(:label_loading) }, size: :small) %>
           <% end %>
         <% end %>
       <% end %>

-Original file line number
+Diff line change
@@ @@ -0,0 +1,5 @@ @@
 +---
 +'@openproject/primer-view-components': patch
 +---
++
 +Make the (lazy) action menu spinner aria label translatable and reduce it's size to small
Original file line number	Diff line number	Diff line change
`@@ -13,7 +13,7 @@`
`13`	`13`	`autofocus: true`
`14`	`14`	`}`
`15`	`15`	`) do %>`
`16`		`- <%= render Primer::Beta::Spinner.new(aria: { label: "Loading content..." }) %>`
	`16`	`+ <%= render Primer::Beta::Spinner.new(aria: { label: I18n.t(:label_loading) }, size: :small) %>`
`17`	`17`	`<% end %>`
`18`	`18`	`<% end %>`
`19`	`19`	`<% end %>`