Skip to content

Commit d7fac57

Browse files
authored
Merge pull request #416 from opf/bug/69915-accessibility-primer-text-field-clear-button-aria-label-not-localized-2
[69915] Accessibility: Primer Text Field clear button ARIA label not localized
2 parents 7edfe65 + 8d48ced commit d7fac57

File tree

9 files changed

+7
-0
lines changed

9 files changed

+7
-0
lines changed

.changeset/forty-hounds-yawn.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
'@openproject/primer-view-components': patch
3+
---
4+
5+
add localized default label to close button in Subheader filter input
13 Bytes
Loading
-12 Bytes
Loading
12 Bytes
Loading
3 Bytes
Loading
-2 Bytes
Loading
1 Byte
Loading

app/components/primer/open_project/sub_header.rb

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -86,6 +86,7 @@ class SubHeader < Primer::Component
8686
system_arguments[:leading_visual] ||= { icon: :search }
8787
system_arguments[:visually_hide_label] ||= true
8888
system_arguments[:input_width] ||= :medium
89+
system_arguments[:clear_button_label] ||= I18n.t(:button_clear)
8990

9091
system_arguments[:data] ||= {}
9192
system_arguments[:data] = merge_data(

config/locales/en.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,7 @@
11
en:
22
button_back: "Back"
33
button_cancel: "Cancel"
4+
button_clear: "Clear"
45
button_close: "Close"
56
button_delete: "Delete"
67
button_delete_permanently: "Delete permanently"

0 commit comments

Comments
 (0)