Fix broken FeedbackDialog aria-describedby value

Was referencing a non-existent id

Author: myabc

app/components/primer/open_project/feedback_dialog.rb

@@ -16,6 +16,8 @@ class FeedbackDialog < Primer::Component
       # @param system_arguments [Hash] <%= link_to_system_arguments_docs %>
       renders_one :feedback_message, lambda { |icon_arguments: {}, **system_arguments|
         system_arguments[:border] = false
+        system_arguments[:id] = "#{@system_arguments[:id]}-description"
+
         Primer::OpenProject::FeedbackMessage.new(icon_arguments: icon_arguments, **system_arguments)
       }
 

test/components/primer/open_project/feedback_dialog_test.rb

@@ -19,6 +19,18 @@ def test_renders
     end
   end
 
+  def test_renders_aria_describedby
+    render_inline(Primer::OpenProject::FeedbackDialog.new(title: "Success message")) do |dialog|
+      dialog.with_feedback_message do |message|
+        message.with_heading(tag: :h2) { "Success" }
+      end
+    end
+
+    dialog_labelledby_id = page.find_css("dialog").first.attributes["aria-describedby"].value
+    feedback_message_id = page.find_css(".FeedbackMessage").first.attributes["id"].value
+    assert_equal dialog_labelledby_id, feedback_message_id
+  end
+
   def test_renders_additional_details
     render_inline(Primer::OpenProject::FeedbackDialog.new(title: "Success message")) do |dialog|
       dialog.with_feedback_message do |message|