Commit f324227
[61890] Advanced accessibility for the Danger Dialogs (with ARIA semantics to communicate contextual changes) (#351)
* add aria-descreibedby for confirm button
* set aria message message as a parameter
* update previews
* add a test case
* add a test case for checking and unchecking the checkbox
* Create two-windows-mix.md
* fix eslint errors
* fix eslint errors
* Generating component snapshots
* fix failing tests
* fix errors in lint
* Generating component snapshots
* change indentation
* use live region and attr
* Use a specific sentence for each action instead of configurable message
* Generating component snapshots
* Remove last occurences of customizable text and adapt tests
---------
Co-authored-by: Henriette Darge <[email protected]>1 parent e38702c commit f324227
File tree
27 files changed
+125
-27
lines changed- .changeset
- .playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/danger_dialog
- default
- with_confirmation_check_box_and_live_messages
- with_confirmation_check_box
- app/components/primer/open_project
- config/locales
- previews/primer/open_project
- test
- components/primer/open_project
- system/open_project
27 files changed
+125
-27
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
Lines changed: 2 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
7 | 7 | | |
8 | 8 | | |
9 | 9 | | |
10 | | - | |
| 10 | + | |
| 11 | + | |
0 commit comments