Skip to content

Commit f324227

Browse files
bsatarnejadHDinger
andauthored
[61890] Advanced accessibility for the Danger Dialogs (with ARIA semantics to communicate contextual changes) (#351)
* add aria-descreibedby for confirm button * set aria message message as a parameter * update previews * add a test case * add a test case for checking and unchecking the checkbox * Create two-windows-mix.md * fix eslint errors * fix eslint errors * Generating component snapshots * fix failing tests * fix errors in lint * Generating component snapshots * change indentation * use live region and attr * Use a specific sentence for each action instead of configurable message * Generating component snapshots * Remove last occurences of customizable text and adapt tests --------- Co-authored-by: Henriette Darge <[email protected]>
1 parent e38702c commit f324227

File tree

27 files changed

+125
-27
lines changed

27 files changed

+125
-27
lines changed

.changeset/two-windows-mix.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
---
2+
"@openproject/primer-view-components": patch
3+
---
4+
5+
[61890] Advanced accessibility for the Danger Dialogs (with ARIA semantics to communicate contextual changes)
104 Bytes
Loading
94 Bytes
Loading
-633 Bytes
Loading
-140 Bytes
Loading

.playwright/screenshots/snapshots.test.ts-snapshots/primer/open_project/danger_dialog/with_confirmation_check_box/aria-snapshot--after-interaction.yml

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,4 +7,5 @@
77
- checkbox "I understand that this deletion cannot be reversed": "1"
88
- text: I understand that this deletion cannot be reversed
99
- button "Cancel"
10-
- button "Delete permanently" [disabled]
10+
- button "Delete permanently" [disabled]
11+
- text: The button to proceed is now inactive. You need to tick the checkbox to continue.
116 Bytes
Loading
108 Bytes
Loading
-622 Bytes
Loading
Loading

0 commit comments

Comments
 (0)