Solve Junit5 sonar issues

Signed-off-by: freddidierRTE <[email protected]>

Author: freddidierRTE

backend/cards-consultation/src/test/java/org/opfab/cards/consultation/controllers/CardOperationsControllerShould.java

@@ -108,12 +108,12 @@ public CardOperationsControllerShould() {
     }
 
     @AfterEach
-    public void clean() {
+    void clean() {
         repository.deleteAll().subscribe();
     }
 
     @BeforeEach
-    public void initCardData() {
+    void initCardData() {
         service.clearSubscriptions();
         StepVerifier.create(repository.deleteAll()).expectComplete().verify();
         int processNo = 0;

backend/cards-consultation/src/test/java/org/opfab/cards/consultation/repositories/ArchivedCardRepositoryShould.java

@@ -33,8 +33,6 @@
 import java.util.List;
 import java.util.function.Predicate;
 
-import javax.smartcardio.Card;
-
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.junit.jupiter.api.Assertions.assertTrue;
 import static org.opfab.cards.consultation.TestUtilities.*;
@@ -80,12 +78,12 @@ public class ArchivedCardRepositoryShould {
     private ArchivedCardRepository repository;
 
     @AfterEach
-    public void clean() {
+    void clean() {
         repository.deleteAll().subscribe();
     }
 
     @BeforeAll
-    public static void initUsers() {
+    static void initUsers() {
         ComputedPerimeter perimeter = new ComputedPerimeter();
         perimeter.setProcess("PROCESS");
         perimeter.setState("anyState");
@@ -130,7 +128,7 @@ private CardsFilter getCardsFilter(List<FilterModel> filters) {
     }
 
     @BeforeEach
-    public void initCardData() {
+    void initCardData() {
 
         int processNo = 0;
         // create past cards

backend/cards-consultation/src/test/java/org/opfab/cards/consultation/routes/ArchivedCardRoutesShould.java

@@ -51,7 +51,7 @@ class ArchivedCardRoutesShould {
     private ArchivedCardRepository repository;
 
     @AfterEach
-    public void cleanArchivedCardRepository() {
+    void cleanArchivedCardRepository() {
         repository.deleteAll().subscribe();
 
     }

backend/cards-consultation/src/test/java/org/opfab/cards/consultation/routes/CardRoutesShould.java

@@ -55,7 +55,7 @@ class CardRoutesShould {
     private CardRepository repository;
 
     @AfterEach
-    public void cleanCardRepository() {
+    void cleanCardRepository() {
         repository.deleteAll().subscribe();
     }
 

backend/cards-consultation/src/test/java/org/opfab/cards/consultation/routes/ConnectionRoutesShould.java

@@ -57,7 +57,7 @@ public ConnectionRoutesShould() {
     }
 
     @BeforeEach
-    public void clearSubscriptions() {
+    void clearSubscriptions() {
         service.clearSubscriptions();
     }
 

backend/cards-publication/src/test/java/org/opfab/cards/publication/kafka/command/CreateCardCommandHandlerShould.java

@@ -42,7 +42,7 @@ class CreateCardCommandHandlerShould {
     private CreateCardCommandHandler cut;
 
     @BeforeAll
-    public void setUp() {
+    void setUp() {
         services = mock(Services.class);
         cardProcessingService = mock(CardProcessingService.class);
         objectMapper = mock(CardObjectMapper.class);

backend/cards-publication/src/test/java/org/opfab/cards/publication/kafka/command/DeleteCardCommandHandlerShould.java

@@ -45,7 +45,7 @@ class DeleteCardCommandHandlerShould {
     private DeleteCardCommandHandler cut;
 
     @BeforeAll
-    public void setUp() {
+    void setUp() {
         services = mock(Services.class);
         cardDeletionService = mock(CardDeletionService.class);
         objectMapper = mock(CardObjectMapper.class);
@@ -71,7 +71,7 @@ void executeCommand() throws JsonProcessingException {
         cut.executeCommand(cardCommandMock);
 
         verify(cardDeletionService, times(1))
-                .deleteCardById(any(),notNull(),any());
+                .deleteCardById(any(), notNull(), any());
     }
 
 }

backend/cards-publication/src/test/java/org/opfab/cards/publication/kafka/command/UpdateCardCommandHandlerShould.java

@@ -39,7 +39,7 @@ class UpdateCardCommandHandlerShould {
     private UpdateCardCommandHandler cut;
 
     @BeforeAll
-    public void setUp() {
+    void setUp() {
         services = mock(Services.class);
         cardProcessingService = mock(CardProcessingService.class);
         objectMapper = mock(CardObjectMapper.class);
@@ -55,7 +55,8 @@ void getCommandType() {
     @Test
     void executeCommand() throws JsonProcessingException {
         CardCommand cardCommandMock = mock(CardCommand.class);
-        org.opfab.cards.publication.model.Card cardPublicationDataMock = mock (org.opfab.cards.publication.model.Card.class);
+        org.opfab.cards.publication.model.Card cardPublicationDataMock = mock(
+                org.opfab.cards.publication.model.Card.class);
         Card cardMock = mock(Card.class);
         when(cardCommandMock.getCard()).thenReturn(cardMock);
         when(objectMapper.writeValueAsString(any())).thenReturn("");

backend/cards-publication/src/test/java/org/opfab/cards/publication/ratelimiter/CardSendingLimiterShould.java

@@ -24,23 +24,23 @@ class CardSendingLimiterShould {
     private final int limitPeriodInSec = 60;
 
     @BeforeEach
-    public void init() {
+    void init() {
         testClock = new TestClock(Clock.fixed(Instant.parse("2001-06-09T00:00:00.00Z"), ZoneId.systemDefault()));
         limiter = new CardSendingLimiter(limitCardCount, limitPeriodInSec, testClock);
     }
 
     @Test
     void isPermissionRefusedWhenLimitReached() {
-        for (int i=0; i<limitCardCount; i++) {
+        for (int i = 0; i < limitCardCount; i++) {
             limiter.isNewSendingAllowed("publisher1");
         }
 
         Assertions.assertFalse(limiter.isNewSendingAllowed("PUBLISHER1"));
     }
-    
+
     @Test
     void isLimiterReset() {
-        for (int i=0; i<limitCardCount; i++) {
+        for (int i = 0; i < limitCardCount; i++) {
             limiter.isNewSendingAllowed("publisher1");
         }
         Assertions.assertFalse(limiter.isNewSendingAllowed("PUBLISHER1"));
@@ -50,7 +50,7 @@ void isLimiterReset() {
 
     @Test
     void isPermissionAcceptedWhenWaitAfterLimitReached() {
-        for (int i=0; i<limitCardCount; i++) {
+        for (int i = 0; i < limitCardCount; i++) {
             limiter.isNewSendingAllowed("publisher1");
         }
 
@@ -60,13 +60,13 @@ void isPermissionAcceptedWhenWaitAfterLimitReached() {
 
     @Test
     void multiplePublishers() {
-        for (int i=0; i<limitCardCount; i++) {
+        for (int i = 0; i < limitCardCount; i++) {
             limiter.isNewSendingAllowed("publisher1");
         }
         testClock.offset(Duration.ofSeconds(30));
         Assertions.assertFalse(limiter.isNewSendingAllowed("PUBLISHER1"));
 
-        for (int i=0; i<limitCardCount; i++) {
+        for (int i = 0; i < limitCardCount; i++) {
             limiter.isNewSendingAllowed("publisher2");
         }
         testClock.offset(Duration.ofSeconds(31));

backend/cards-publication/src/test/java/org/opfab/cards/publication/services/CardDeletionServiceShould.java

@@ -83,7 +83,7 @@ class CardDeletionServiceShould {
     private Optional<Jwt> token = Optional.empty();
 
     @BeforeEach
-    public void init() {
+    void init() {
         eventBusSpy = new EventBusSpy();
         cardNotificationService = new CardNotificationService(eventBusSpy, objectMapper, null);
         cardTranslationService = new CardTranslationService(i18NRepositoryMock);