Skip to content

Commit 69cd1b8

Browse files
freddidierRTEfreddidierRTE
committed
Revert "add an async to a UI unit test to avoid flaky test"
This reverts commit efdf24c. Signed-off-by: freddidierRTE <[email protected]>
1 parent efdf24c commit 69cd1b8

File tree

1 file changed

+31
-31
lines changed

1 file changed

+31
-31
lines changed

‎frontend/src/app/components/notificationconfiguration/view/NotificationConfigurationView.spec.ts‎

Lines changed: 31 additions & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -7,14 +7,14 @@
77
* This file is part of the OperatorFabric project.
88
*/
99

10-
import { Process, State } from '@ofServices/processes/model/Processes';
11-
import { NotificationConfigurationView } from './NotificationConfigurationView';
12-
import { RightEnum } from '@ofServices/perimeters/model/Perimeter';
13-
import { ComputedPerimeter, UserWithPerimeters } from '@ofServices/users/model/UserWithPerimeters';
14-
import { ConfigService } from 'app/services/config/ConfigService';
15-
import { loadWebUIConf, setProcessConfiguration, setUserPerimeter } from '@tests/helpers';
16-
import { NotificationConfigurationPage } from './NotificationConfigurationPage';
17-
import { User } from '@ofServices/users/model/User';
10+
import {Process, State} from '@ofServices/processes/model/Processes';
11+
import {NotificationConfigurationView} from './NotificationConfigurationView';
12+
import {RightEnum} from '@ofServices/perimeters/model/Perimeter';
13+
import {ComputedPerimeter, UserWithPerimeters} from '@ofServices/users/model/UserWithPerimeters';
14+
import {ConfigService} from 'app/services/config/ConfigService';
15+
import {loadWebUIConf, setProcessConfiguration, setUserPerimeter} from '@tests/helpers';
16+
import {NotificationConfigurationPage} from './NotificationConfigurationPage';
17+
import {User} from '@ofServices/users/model/User';
1818

1919
describe('Notification configuration view ', () => {
2020
let notificationConfigurationPage: NotificationConfigurationPage;
@@ -23,23 +23,23 @@ describe('Notification configuration view ', () => {
2323
id: 'process1',
2424
version: 'v1',
2525
name: 'process name 1',
26-
states: new Map<string, State>([['state1_1', { name: 'State 1_1' }]])
26+
states: new Map<string, State>([['state1_1', {name: 'State 1_1'}]])
2727
},
2828
{
2929
id: 'process2',
3030
version: 'v2',
3131
name: 'process name 2',
3232
states: new Map<string, State>([
33-
['state2_1', { name: 'State 2_1' }],
34-
['state2_2', { name: 'State 2_2' }],
35-
['onlyChildState', { name: 'State 2_3', isOnlyAChildState: true }]
33+
['state2_1', {name: 'State 2_1'}],
34+
['state2_2', {name: 'State 2_2'}],
35+
['onlyChildState', {name: 'State 2_3', isOnlyAChildState: true}]
3636
])
3737
},
3838
{
3939
id: 'process3',
4040
version: 'v2',
4141
name: 'process name 3',
42-
states: new Map<string, State>([['state3_1', { name: 'State 3_1' }]])
42+
states: new Map<string, State>([['state3_1', {name: 'State 3_1'}]])
4343
},
4444
{
4545
id: 'process4',
@@ -50,7 +50,7 @@ describe('Notification configuration view ', () => {
5050
id: 'processWithNoName',
5151
version: 'v2',
5252
name: '',
53-
states: new Map<string, State>([['stateNoName_1', { name: 'State NoName_1' }]])
53+
states: new Map<string, State>([['stateNoName_1', {name: 'State NoName_1'}]])
5454
}
5555
];
5656

@@ -170,7 +170,7 @@ describe('Notification configuration view ', () => {
170170

171171
it('should not return process group with no process visible for user', async () => {
172172
expect(notificationConfigurationPage.processGroups).not.toContain(
173-
jasmine.objectContaining({ id: 'serviceNotVisibleForUser' })
173+
jasmine.objectContaining({id: 'serviceNotVisibleForUser'})
174174
);
175175
});
176176
});
@@ -233,35 +233,35 @@ describe('Notification configuration view ', () => {
233233
version: 'v1',
234234
name: 'process name 1',
235235
states: new Map<string, State>([
236-
['state1_1', { name: 'State 1_1' }],
237-
['state1_2', { name: 'State 1_2' }]
236+
['state1_1', {name: 'State 1_1'}],
237+
['state1_2', {name: 'State 1_2'}]
238238
])
239239
},
240240
{
241241
id: 'process2',
242242
version: 'v2',
243243
name: 'process name 2',
244244
states: new Map<string, State>([
245-
['state2_1', { name: 'State 2_1' }],
246-
['state2_2', { name: 'State 2_2' }]
245+
['state2_1', {name: 'State 2_1'}],
246+
['state2_2', {name: 'State 2_2'}]
247247
])
248248
},
249249
{
250250
id: 'process3',
251251
version: 'v2',
252252
name: 'process name 3',
253253
states: new Map<string, State>([
254-
['state3_1', { name: 'State 3_1' }],
255-
['state3_2', { name: 'State 3_2' }]
254+
['state3_1', {name: 'State 3_1'}],
255+
['state3_2', {name: 'State 3_2'}]
256256
])
257257
},
258258
{
259259
id: 'process4',
260260
version: 'v2',
261261
name: 'process name 4',
262262
states: new Map<string, State>([
263-
['state4_1', { name: 'State 4_1' }],
264-
['state4_2', { name: 'State 4_2' }]
263+
['state4_1', {name: 'State 4_1'}],
264+
['state4_2', {name: 'State 4_2'}]
265265
])
266266
}
267267
],
@@ -334,17 +334,17 @@ describe('Notification configuration view ', () => {
334334
version: 'v1',
335335
name: 'process name 1',
336336
states: new Map<string, State>([
337-
['state1_1', { name: 'State 1_1' }],
338-
['state1_2', { name: 'State 1_2' }]
337+
['state1_1', {name: 'State 1_1'}],
338+
['state1_2', {name: 'State 1_2'}]
339339
])
340340
},
341341
{
342342
id: 'process2',
343343
version: 'v2',
344344
name: 'process name 2',
345345
states: new Map<string, State>([
346-
['state2_1', { name: 'State 2_1' }],
347-
['state2_2', { name: 'State 2_2' }]
346+
['state2_1', {name: 'State 2_1'}],
347+
['state2_2', {name: 'State 2_2'}]
348348
])
349349
}
350350
]);
@@ -414,7 +414,7 @@ describe('Notification configuration view ', () => {
414414
});
415415
});
416416

417-
describe('email user settings', async () => {
417+
describe('email user settings', () => {
418418
it('email configuration should be enabled if email is from user instead of settings', async () => {
419419
await loadWebUIConf({});
420420
ConfigService.setConfigValue('settings.sendCardsByEmail', true);
@@ -446,9 +446,9 @@ describe('Notification configuration view ', () => {
446446
version: 'v1',
447447
name: 'process name 1',
448448
states: new Map<string, State>([
449-
['state1_1', { name: 'State 1_1' }],
450-
['state1_2', { name: 'State 1_2' }],
451-
['state1_3', { name: 'State 1_3' }]
449+
['state1_1', {name: 'State 1_1'}],
450+
['state1_2', {name: 'State 1_2'}],
451+
['state1_3', {name: 'State 1_3'}]
452452
])
453453
}
454454
]);

0 commit comments

Comments
 (0)