Skip to content

Commit b203b6e

Browse files
committed
feat: Add full support for
VERSION_USABLE_UNTI Co-authored-by: Gemini AI Assistant <https://gemini.google.com>
1 parent 5921a5b commit b203b6e

File tree

6 files changed

+12
-0
lines changed

6 files changed

+12
-0
lines changed

.github/workflows/test.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -168,6 +168,7 @@ jobs:
168168
description: 'An advanced plugin for comprehensive testing'
169169
cmk-min-version: '2.3.0p1'
170170
cmk-packaged-version: '2.3.0p34'
171+
version-usable-until: '2.4.0'
171172
download-url: 'https://github.com/test/advanced-plugin'
172173
output-dir: 'dist'
173174
validate-python: 'true'

.mkp-builderrc.example

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ PACKAGE_DESCRIPTION="A comprehensive CheckMK plugin that monitors awesome things
1010
# CheckMK Compatibility
1111
CMK_MIN_VERSION="2.3.0p1"
1212
CMK_PACKAGED_VERSION="2.3.0p34"
13+
VERSION_USABLE_UNTIL=""
1314

1415
# Optional settings
1516
DOWNLOAD_URL="https://github.com/yourusername/your-plugin-repo"

CHANGES.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
88
## [Unreleased]
99

1010
### New
11+
- Add full support for `VERSION_USABLE_UNTIL` including a command line argument, a GHA input and documentation.
1112

1213
### Changed
1314

README.md

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -105,6 +105,7 @@ jobs:
105105
| `cmk-min-version` | Minimum CheckMK version | ❌ | From config file |
106106
| `cmk-packaged-version` | CheckMK packaging version | ❌ | From config file |
107107
| `download-url` | Download URL | ❌ | From config file |
108+
| `version-usable-until` | The last CheckMK version this plugin is compatible with | ❌ | From config file |
108109
| `output-dir` | Output directory | ❌ | `.` |
109110
| `validate-python` | Validate Python files | ❌ | `true` |
110111
| `verbose` | Enable verbose output | ❌ | `false` |

action.yml

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -27,6 +27,9 @@ inputs:
2727
download-url:
2828
description: 'Download URL (default: from config file)'
2929
required: false
30+
version-usable-until:
31+
description: 'The last CheckMK version this plugin is compatible with (default: from config file)'
32+
required: false
3033
output-dir:
3134
description: 'Output directory for MKP file (default: current directory)'
3235
required: false
@@ -143,6 +146,7 @@ runs:
143146
[[ -n "${{ inputs.cmk-min-version }}" ]] && BUILD_ARGS+=("--cmk-min" "${{ inputs.cmk-min-version }}")
144147
[[ -n "${{ inputs.cmk-packaged-version }}" ]] && BUILD_ARGS+=("--cmk-packaged" "${{ inputs.cmk-packaged-version }}")
145148
[[ -n "${{ inputs.download-url }}" ]] && BUILD_ARGS+=("--download-url" "${{ inputs.download-url }}")
149+
[[ -n "${{ inputs.version-usable-until }}" ]] && BUILD_ARGS+=("--version-usable-until" "${{ inputs.version-usable-until }}")
146150
[[ -n "${{ inputs.output-dir }}" ]] && BUILD_ARGS+=("--output-dir" "${{ inputs.output-dir }}")
147151
148152
# Add validation flag

mkp-builder.py

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -451,6 +451,8 @@ def create_parser() -> argparse.ArgumentParser:
451451
help='CheckMK version used for packaging (default: from config)')
452452
parser.add_argument('--download-url',
453453
help='Download URL (default: from config)')
454+
parser.add_argument('--version-usable-until',
455+
help='The last CheckMK version this plugin is compatible with (default: from config)')
454456
parser.add_argument('--output-dir', default='.',
455457
help='Output directory (default: current directory)')
456458

@@ -493,6 +495,8 @@ def main() -> int:
493495
builder.config['cmk_packaged_version'] = getattr(args, 'cmk_packaged')
494496
if getattr(args, 'download_url'):
495497
builder.config['download_url'] = getattr(args, 'download_url')
498+
if getattr(args, 'version_usable_until'):
499+
builder.config['version_usable_until'] = getattr(args, 'version_usable_until')
496500
if args.output_dir:
497501
builder.config['output_dir'] = args.output_dir
498502

0 commit comments

Comments
 (0)