Skip to content

Commit bbd4f41

Browse files
alexandrebelloniopsiff
authored andcommitted
rtc: ds1307: stop disabling alarms on probe
[ Upstream commit dcec126 ] It is a bad practice to disable alarms on probe or remove as this will prevent alarms across reboots. Link: https://lore.kernel.org/r/[email protected] Signed-off-by: Alexandre Belloni <[email protected]> Signed-off-by: Sasha Levin <[email protected]> (cherry picked from commit c0acbeac2b287322780d7560e3d7f4ee6f2c46ae)
1 parent 995599c commit bbd4f41

File tree

1 file changed

+1
-3
lines changed

1 file changed

+1
-3
lines changed

drivers/rtc/rtc-ds1307.c

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1802,10 +1802,8 @@ static int ds1307_probe(struct i2c_client *client)
18021802
* For some variants, be sure alarms can trigger when we're
18031803
* running on Vbackup (BBSQI/BBSQW)
18041804
*/
1805-
if (want_irq || ds1307_can_wakeup_device) {
1805+
if (want_irq || ds1307_can_wakeup_device)
18061806
regs[0] |= DS1337_BIT_INTCN | chip->bbsqi_bit;
1807-
regs[0] &= ~(DS1337_BIT_A2IE | DS1337_BIT_A1IE);
1808-
}
18091807

18101808
regmap_write(ds1307->regmap, DS1337_REG_CONTROL,
18111809
regs[0]);

0 commit comments

Comments
 (0)