fix sequential load

Author: petercrocker

docs/docs/concepts.mdx

@@ -44,7 +44,7 @@ The demo uses composable building blocks to construct complex network architectu
 
 ### Composition model
 
-```
+```tree
 Topology Design
     ├─ Device Templates (spine, leaf, border-leaf)
     ├─ Connectivity Patterns (fabric peering)
@@ -256,7 +256,7 @@ Artifacts are the final outputs that deploy to devices. The demo generates confi
 
 ### Artifact generation flow
 
-```
+```text
 GraphQL Query → Transform → Template → Artifact
 ```
 
@@ -391,7 +391,7 @@ This allows generators to create infrastructure in parallel.
 
 Resource pools support hierarchy for delegation:
 
-```
+```tree
 Root Pool (10.0.0.0/8)
   ├─ Region 1 (10.0.0.0/16)
   │   ├─ DC-1 (10.0.0.0/20)

docs/docs/developer-guide.mdx

@@ -8,7 +8,7 @@ This guide provides a technical deep-dive into how the Infrahub demo works under
 
 The demo follows Infrahub's SDK pattern with five core component types working together:
 
-```
+```text
 Schemas → Data → Generators → Transforms → Configurations
                       ↓
                   Checks (Validation)
@@ -385,7 +385,7 @@ Bootstrap data provides initial objects like locations, platforms, and device ty
 
 ### Bootstrap structure
 
-```
+```tree
 objects/bootstrap/
 ├── 01_organizations.yml      # Organizations
 ├── 02_asn_pools.yml          # BGP ASN pools

generators/common.py

@@ -76,21 +76,23 @@ async def _create_in_batch(
         self,
         kind: str,
         data_list: list,
+        allow_upsert: bool = False,
     ) -> None:
         """
         Create objects of a specific kind and store in local store.
 
         Args:
             kind: The kind of object to create.
             data_list: List of data dictionaries for creation.
+            allow_upsert: Whether to allow upsert operations. Use False for new devices to prevent race conditions.
         """
         batch = await self.client.create_batch()
         for data in data_list:
             try:
                 obj = await self.client.create(
                     kind=kind, data=data.get("payload"), branch=self.branch
                 )
-                batch.add(task=obj.save, allow_upsert=True, node=obj)
+                batch.add(task=obj.save, allow_upsert=allow_upsert, node=obj)
                 if data.get("store_key"):
                     self.client.store.set(
                         key=data.get("store_key"), node=obj, branch=self.branch
@@ -110,6 +112,40 @@ async def _create_in_batch(
         except ValidationError as exc:
             self.log.debug(f"- Creation failed due to {exc}")
 
+    async def _create_sequentially(
+        self,
+        kind: str,
+        data_list: list,
+    ) -> None:
+        """
+        Create objects sequentially (one at a time) with upsert enabled.
+        This prevents race conditions while maintaining idempotency.
+
+        Args:
+            kind: The kind of object to create.
+            data_list: List of data dictionaries for creation.
+        """
+        for data in data_list:
+            try:
+                obj = await self.client.create(
+                    kind=kind, data=data.get("payload"), branch=self.branch
+                )
+                await obj.save(allow_upsert=True)
+                if data.get("store_key"):
+                    self.client.store.set(
+                        key=data.get("store_key"), node=obj, branch=self.branch
+                    )
+                object_reference = (
+                    " ".join(obj.hfid) if obj.hfid else obj.display_label
+                )
+                self.log.info(
+                    f"- Created [{obj.get_kind()}] {object_reference}"
+                    if object_reference
+                    else f"- Created [{obj.get_kind()}]"
+                )
+            except (GraphQLError, ValidationError) as exc:
+                self.log.debug(f"- Creation failed due to {exc}")
+
     async def _create(self, kind: str, data: dict) -> None:
         """
         Create an object of a specific kind and store in local store.
@@ -214,6 +250,7 @@ async def create_address_pools(self, subnets: list[dict]) -> None:
                 }
                 for pool in subnets
             ],
+            allow_upsert=True,
         )
 
     async def create_split_loopback_pools(self, technical_subnet_obj: Any) -> None:
@@ -382,7 +419,7 @@ async def create_devices(self) -> None:
             ("DcimVirtualDevice", virtual_devices),
         ]:
             if devices:
-                await self._create_in_batch(kind=kind, data_list=devices)
+                await self._create_sequentially(kind=kind, data_list=devices)
 
         self.devices = [
             self.client.store.get_by_hfid(f"DcimGenericDevice__{device[0]}")

scripts/bootstrap.sh

@@ -13,10 +13,10 @@ uv run infrahubctl object load objects/bootstrap/ --branch $BRANCH
 echo "Load security data"
 uv run infrahubctl object load objects/security/ --branch $BRANCH
 
-# echo "Add demo repository"
-# uv run infrahubctl repository add DEMO https://github.com/opsmill/infrahub-demo.git --ref main --read-only
+echo "Add demo repository"
+uv run infrahubctl repository add DEMO https://github.com/opsmill/infrahub-demo.git --ref main --read-only
 
 echo "Add event actions"
-sleep 30
+sleep 60
 uv run infrahubctl object load objects/events/ --branch $BRANCH