Fix issue with getting cable IDs from the database for cables not yet created.

Author: Phillip Simonds

generators/common.py

@@ -1142,11 +1142,21 @@ async def create_oob_connections(
             target_endpoint.description.value = f"Connection to {' -> '.join(source_endpoint.hfid or [])}"
 
             # Check if either endpoint already has a cable attached
+            # Note: Accessing .peer can raise ValueError if the related node exists
+            # but doesn't have an ID/HFID (e.g., hasn't been saved yet). We catch
+            # this and treat it as "no existing cable".
             existing_cable_id = None
-            if source_endpoint.connector.peer:
-                existing_cable_id = source_endpoint.connector.peer.id
-            elif target_endpoint.connector.peer:
-                existing_cable_id = target_endpoint.connector.peer.id
+            try:
+                if source_endpoint.connector.peer:
+                    existing_cable_id = source_endpoint.connector.peer.id
+            except ValueError:
+                pass  # No existing cable or peer doesn't have an ID
+            if not existing_cable_id:
+                try:
+                    if target_endpoint.connector.peer:
+                        existing_cable_id = target_endpoint.connector.peer.id
+                except ValueError:
+                    pass  # No existing cable or peer doesn't have an ID
 
             # Create or update cable to connect the endpoints
             cable_data: dict[str, Any] = {

generators/generate_dc.py

@@ -166,11 +166,21 @@ async def create_fabric_peering(self) -> None:
             target_endpoint.role.value = interface_role
 
             # Check if either endpoint already has a cable attached
+            # Note: Accessing .peer can raise ValueError if the related node exists
+            # but doesn't have an ID/HFID (e.g., hasn't been saved yet). We catch
+            # this and treat it as "no existing cable".
             existing_cable_id = None
-            if source_endpoint.connector.peer:
-                existing_cable_id = source_endpoint.connector.peer.id
-            elif target_endpoint.connector.peer:
-                existing_cable_id = target_endpoint.connector.peer.id
+            try:
+                if source_endpoint.connector.peer:
+                    existing_cable_id = source_endpoint.connector.peer.id
+            except ValueError:
+                pass  # No existing cable or peer doesn't have an ID
+            if not existing_cable_id:
+                try:
+                    if target_endpoint.connector.peer:
+                        existing_cable_id = target_endpoint.connector.peer.id
+                except ValueError:
+                    pass  # No existing cable or peer doesn't have an ID
 
             # Create or update cable object connecting both endpoints
             # Uses DAC (Direct Attach Copper) passive cables for fabric links