Skip to content

Commit 0238097

Browse files
committed
Fix unit tests
1 parent 46ceb9f commit 0238097

File tree

14 files changed

+79
-64
lines changed

14 files changed

+79
-64
lines changed

infrahub_sdk/client.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -50,7 +50,7 @@
5050
from .protocols_base import CoreNode, CoreNodeSync
5151
from .queries import get_commit_update_mutation
5252
from .query_groups import InfrahubGroupContext, InfrahubGroupContextSync
53-
from .schema import InfrahubSchema, InfrahubSchemaSync, NodeSchema
53+
from .schema import InfrahubSchema, InfrahubSchemaSync, NodeSchemaAPI
5454
from .store import NodeStore, NodeStoreSync
5555
from .timestamp import Timestamp
5656
from .types import AsyncRequester, HTTPMethod, SyncRequester
@@ -448,12 +448,12 @@ async def get(
448448
filters: MutableMapping[str, Any] = {}
449449

450450
if id:
451-
if not is_valid_uuid(id) and isinstance(schema, NodeSchema) and schema.default_filter:
451+
if not is_valid_uuid(id) and isinstance(schema, NodeSchemaAPI) and schema.default_filter:
452452
filters[schema.default_filter] = id
453453
else:
454454
filters["ids"] = [id]
455455
if hfid:
456-
if isinstance(schema, NodeSchema) and schema.human_friendly_id:
456+
if isinstance(schema, NodeSchemaAPI) and schema.human_friendly_id:
457457
filters["hfid"] = hfid
458458
else:
459459
raise ValueError("Cannot filter by HFID if the node doesn't have an HFID defined")
@@ -1916,12 +1916,12 @@ def get(
19161916
filters: MutableMapping[str, Any] = {}
19171917

19181918
if id:
1919-
if not is_valid_uuid(id) and isinstance(schema, NodeSchema) and schema.default_filter:
1919+
if not is_valid_uuid(id) and isinstance(schema, NodeSchemaAPI) and schema.default_filter:
19201920
filters[schema.default_filter] = id
19211921
else:
19221922
filters["ids"] = [id]
19231923
if hfid:
1924-
if isinstance(schema, NodeSchema) and schema.human_friendly_id:
1924+
if isinstance(schema, NodeSchemaAPI) and schema.human_friendly_id:
19251925
filters["hfid"] = hfid
19261926
else:
19271927
raise ValueError("Cannot filter by HFID if the node doesn't have an HFID defined")

infrahub_sdk/ctl/generator.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,7 @@
1010
from ..ctl.utils import execute_graphql_query, parse_cli_vars
1111
from ..exceptions import ModuleImportError
1212
from ..node import InfrahubNode
13-
from ..schema import InfrahubRepositoryConfig
13+
from ..schema.repository import InfrahubRepositoryConfig
1414

1515

1616
async def run(

infrahub_sdk/ctl/render.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from rich.console import Console
22

3-
from ..schema import InfrahubRepositoryConfig
3+
from ..schema.repository import InfrahubRepositoryConfig
44

55

66
def list_jinja2_transforms(config: InfrahubRepositoryConfig) -> None:

infrahub_sdk/ctl/repository.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,7 @@
1212
from ..ctl.exceptions import FileNotValidError
1313
from ..ctl.utils import init_logging
1414
from ..graphql import Mutation
15-
from ..schema import InfrahubRepositoryConfig
15+
from ..schema.repository import InfrahubRepositoryConfig
1616
from ._file import read_file
1717
from .parameters import CONFIG_PARAM
1818

infrahub_sdk/ctl/transform.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
from rich.console import Console
22

3-
from ..schema import InfrahubRepositoryConfig
3+
from ..schema.repository import InfrahubRepositoryConfig
44

55

66
def list_transforms(config: InfrahubRepositoryConfig) -> None:

infrahub_sdk/ctl/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -26,7 +26,7 @@
2626
ServerNotReachableError,
2727
ServerNotResponsiveError,
2828
)
29-
from ..schema import InfrahubRepositoryConfig
29+
from ..schema.repository import InfrahubRepositoryConfig
3030
from ..yaml import YamlFile
3131
from .client import initialize_client_sync
3232

infrahub_sdk/pytest_plugin/utils.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22

33
import yaml
44

5-
from ..schema import InfrahubRepositoryConfig
5+
from ..schema.repository import InfrahubRepositoryConfig
66
from .exceptions import FileNotValidError
77

88

infrahub_sdk/schema/__init__.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,6 +22,7 @@
2222
from .main import (
2323
AttributeSchema,
2424
AttributeSchemaAPI,
25+
BranchSupportType,
2526
GenericSchema,
2627
GenericSchemaAPI,
2728
NodeSchema,
@@ -34,7 +35,6 @@
3435
SchemaRoot,
3536
SchemaRootAPI,
3637
)
37-
from .repository import InfrahubRepositoryConfig
3838

3939
if TYPE_CHECKING:
4040
from ..client import InfrahubClient, InfrahubClientSync, SchemaType, SchemaTypeSync
@@ -46,9 +46,9 @@
4646
__all__ = [
4747
"AttributeSchema",
4848
"AttributeSchemaAPI",
49+
"BranchSupportType",
4950
"GenericSchema",
5051
"GenericSchemaAPI",
51-
"InfrahubRepositoryConfig",
5252
"NodeSchema",
5353
"NodeSchemaAPI",
5454
"ProfileSchemaAPI",

infrahub_sdk/schema/main.py

Lines changed: 15 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,6 @@
11
from __future__ import annotations
22

3+
import warnings
34
from enum import Enum
45
from typing import TYPE_CHECKING, Any, Optional, Union
56

@@ -41,6 +42,7 @@ class RelationshipDirection(str, Enum):
4142
class AttributeKind(str, Enum):
4243
ID = "ID"
4344
TEXT = "Text"
45+
STRING = "String" # deprecated
4446
TEXTAREA = "TextArea"
4547
DATETIME = "DateTime"
4648
NUMBER = "Number"
@@ -61,6 +63,15 @@ class AttributeKind(str, Enum):
6163
JSON = "JSON"
6264
ANY = "Any"
6365

66+
def __getattr__(self, name: str) -> Any:
67+
if name == "STRING":
68+
warnings.warn(
69+
f"{name} is deprecated and will be removed in future versions.",
70+
DeprecationWarning,
71+
stacklevel=2,
72+
)
73+
return super().__getattribute__(name)
74+
6475

6576
class SchemaState(str, Enum):
6677
PRESENT = "present"
@@ -252,7 +263,8 @@ def kind(self) -> str:
252263

253264

254265
class GenericSchema(BaseSchema, BaseSchemaAttrRel):
255-
pass
266+
def convert_api(self) -> GenericSchemaAPI:
267+
return GenericSchemaAPI(**self.model_dump())
256268

257269

258270
class GenericSchemaAPI(BaseSchema, BaseSchemaAttrRelAPI):
@@ -273,7 +285,8 @@ class BaseNodeSchema(BaseSchema):
273285

274286

275287
class NodeSchema(BaseNodeSchema, BaseSchemaAttrRel):
276-
pass
288+
def convert_api(self) -> NodeSchemaAPI:
289+
return NodeSchemaAPI(**self.model_dump())
277290

278291

279292
class NodeSchemaAPI(BaseNodeSchema, BaseSchemaAttrRelAPI):

infrahub_sdk/transfer/exporter/json.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
from ...client import InfrahubClient
1111
from ...queries import QUERY_RELATIONSHIPS
12-
from ...schema import MainSchemaTypesAPI, NodeSchema
12+
from ...schema import MainSchemaTypesAPI, NodeSchemaAPI
1313
from ..constants import ILLEGAL_NAMESPACES
1414
from ..exceptions import FileAlreadyExistsError, InvalidNamespaceError
1515
from .interface import ExporterInterface
@@ -113,7 +113,7 @@ async def export( # pylint: disable=too-many-branches
113113
node_schema_map = {
114114
kind: schema
115115
for kind, schema in node_schema_map.items()
116-
if isinstance(schema, NodeSchema)
116+
if isinstance(schema, NodeSchemaAPI)
117117
and schema.namespace not in illegal_namespaces
118118
and (not exclude or kind not in exclude)
119119
}

0 commit comments

Comments
 (0)