Improve error message when unable to convert to datetime

Author: dgarros

infrahub_sdk/timestamp.py

@@ -2,10 +2,12 @@
 
 import re
 import warnings
-from datetime import UTC, datetime
+from datetime import datetime, timezone
 
 from whenever import Date, Instant, Time, ZonedDateTime
 
+UTC = timezone.utc  # Required for older versions of Python
+
 REGEX_MAPPING = {
     "seconds": r"(\d+)(s|sec|second|seconds)",
     "minutes": r"(\d+)(m|min|minute|minutes)",
@@ -76,19 +78,17 @@ def __repr__(self) -> str:
     def to_string(self, with_z: bool = True) -> str:
         if with_z:
             return self._obj.instant().format_common_iso()
-        # iso8601_string = self._obj.format_common_iso()
-
-        # self.to_datetime().isoformat()
-        # if iso8601_string[-1] == "Z":
-        #     iso8601_string = iso8601_string[:-1] + "+00:00"
         return self.to_datetime().isoformat()
 
     def to_timestamp(self) -> int:
         return self._obj.timestamp()
 
     def to_datetime(self) -> datetime:
         time_str = self.to_string()
-        return datetime.strptime(time_str[:-1], "%Y-%m-%dT%H:%M:%S.%f").replace(tzinfo=UTC)
+        try:
+            return datetime.strptime(time_str[:-1], "%Y-%m-%dT%H:%M:%S.%f").replace(tzinfo=UTC)
+        except ValueError:
+            raise ValueError(f"Unable to convert {time_str} to datetime")
 
     def __eq__(self, other: object) -> bool:
         if not isinstance(other, Timestamp):

tests/unit/sdk/test_timestamp.py

@@ -1,10 +1,12 @@
-from datetime import UTC, datetime
+from datetime import datetime, timezone
 
 import pytest
 from whenever import Instant
 
 from infrahub_sdk.timestamp import Timestamp, TimestampFormatError
 
+UTC = timezone.utc  # Required for older versions of Python
+
 
 def test_init_empty():
     t1 = Timestamp()
@@ -47,6 +49,11 @@ def test_parse_string():
         pytest.param(
             "2023-12-31T23:59:59.999999Z", datetime(2023, 12, 31, 23, 59, 59, 999999, tzinfo=UTC), id="microseconds"
         ),
+        pytest.param(
+            "2025-02-25T05:58:54.524191Z",
+            datetime(2025, 2, 25, 5, 58, 54, 524191, tzinfo=UTC),
+            id="milliseconds_with_offset",
+        ),
     ],
 )
 def test_to_datetime(input_str, expected_datetime):