Improve error handling for unknown data processing strategies and add test for invalid object expansion strategy

Author: minitriga

infrahub_sdk/spec/object.py

@@ -238,7 +238,9 @@ class DataProcessorFactory:
     def get_processor(cls, strategy: ObjectStrategy) -> DataProcessor:
         processor_class = cls._processors.get(strategy)
         if not processor_class:
-            raise ValueError(f"Unknown strategy: {strategy}")
+            raise ValueError(
+                f"Unknown strategy: {strategy} - no processor found. Valid strategies are: {list(cls._processors.keys())}"
+            )
         return processor_class()
 
     @classmethod
@@ -699,14 +701,20 @@ class ObjectFile(InfrahubFile):
     @property
     def spec(self) -> InfrahubObjectFileData:
         if not self._spec:
-            self._spec = InfrahubObjectFileData(**self.data.spec)
+            try:
+                self._spec = InfrahubObjectFileData(**self.data.spec)
+            except Exception as exc:
+                raise ValidationError(identifier=str(self.location), message=str(exc))
         return self._spec
 
     def validate_content(self) -> None:
         super().validate_content()
         if self.kind != InfrahubFileKind.OBJECT:
             raise ValueError("File is not an Infrahub Object file")
-        self._spec = InfrahubObjectFileData(**self.data.spec)
+        try:
+            self._spec = InfrahubObjectFileData(**self.data.spec)
+        except Exception as exc:
+            raise ValidationError(identifier=str(self.location), message=str(exc))
 
     async def validate_format(self, client: InfrahubClient, branch: str | None = None) -> None:
         self.validate_content()

tests/unit/sdk/spec/test_object.py

@@ -228,3 +228,21 @@ async def test_get_relationship_info_tags(
     rel_info = await get_relationship_info(client, location_schema, "tags", data)
     assert rel_info.is_valid == is_valid
     assert rel_info.format == format
+
+
+async def test_invalid_object_expansion_strategy(
+    client: InfrahubClient, mock_schema_query_01: HTTPXMock, location_expansion
+) -> None:
+    obj = ObjectFile(location="some/path", content=location_expansion)
+
+    from infrahub_sdk.spec.object import DataProcessorFactory, ObjectStrategy  # noqa: PLC0415
+
+    # Patch _processors to remove the invalid strategy
+    original_processors = DataProcessorFactory._processors.copy()
+    try:
+        DataProcessorFactory._processors[ObjectStrategy.RANGE_EXPAND] = None
+        with pytest.raises(ValueError) as exc:
+            await obj.validate_format(client=client)
+        assert "Unknown strategy" in str(exc.value)
+    finally:
+        DataProcessorFactory._processors = original_processors